From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BB8C2BBCF for ; Thu, 17 Dec 2020 06:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30F82389E for ; Thu, 17 Dec 2020 06:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbgLQGBQ (ORCPT ); Thu, 17 Dec 2020 01:01:16 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:50399 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727064AbgLQGBK (ORCPT ); Thu, 17 Dec 2020 01:01:10 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CxLvJ0Q6Bz9sTv; Thu, 17 Dec 2020 17:00:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1608184828; bh=7b/4HdUoY4KqFQN7P8s4ld6mZkyQK98LyF3YI8eIOPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZJnJYKCkxkR+I5kadzvUCg8MjNbHrxVXQe7dMa8YfCJpuatfw6nmtVC3A6Mbt+D5j XVSDxVqdHVx9POMeiWsNZmQ1zBpwm5xAHMk1QFUWmPgmfneGY1q7m+GlgHNTjaouNr PP9M4GwQiDWVW7JtahYmJYgryIsabFwG9Y0WhvoQ= Date: Thu, 17 Dec 2020 16:47:36 +1100 From: David Gibson To: Cornelia Huck Cc: pair@us.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, brijesh.singh@amd.com, dgilbert@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost , qemu-ppc@nongnu.org, rth@twiddle.net, thuth@redhat.com, berrange@redhat.com, mdroth@linux.vnet.ibm.com, Marcelo Tosatti , "Michael S. Tsirkin" , Marcel Apfelbaum , david@redhat.com, Richard Henderson , borntraeger@de.ibm.com, kvm@vger.kernel.org, qemu-s390x@nongnu.org, pasic@linux.ibm.com Subject: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration Message-ID: <20201217054736.GH310465@yekko.fritz.box> References: <20201204054415.579042-1-david@gibson.dropbear.id.au> <20201204054415.579042-12-david@gibson.dropbear.id.au> <20201214182240.2abd85eb.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SdvjNjn6lL3tIsv0" Content-Disposition: inline In-Reply-To: <20201214182240.2abd85eb.cohuck@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org --SdvjNjn6lL3tIsv0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 14, 2020 at 06:22:40PM +0100, Cornelia Huck wrote: > On Fri, 4 Dec 2020 16:44:13 +1100 > David Gibson wrote: >=20 > > We haven't yet implemented the fairly involved handshaking that will be > > needed to migrate PEF protected guests. For now, just use a migration > > blocker so we get a meaningful error if someone attempts this (this is = the > > same approach used by AMD SEV). > >=20 > > Signed-off-by: David Gibson > > Reviewed-by: Dr. David Alan Gilbert > > --- > > hw/ppc/pef.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c > > index 3ae3059cfe..edc3e744ba 100644 > > --- a/hw/ppc/pef.c > > +++ b/hw/ppc/pef.c > > @@ -38,7 +38,11 @@ struct PefGuestState { > > }; > > =20 > > #ifdef CONFIG_KVM > > +static Error *pef_mig_blocker; > > + > > static int kvmppc_svm_init(Error **errp) >=20 > This looks weird? Oops. Not sure how that made it past even my rudimentary compile testing. > > + > > +int kvmppc_svm_init(SecurableGuestMemory *sgm, Error **errp) > > { > > if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURABLE_GUEST)) { > > error_setg(errp, > > @@ -54,6 +58,11 @@ static int kvmppc_svm_init(Error **errp) > > } > > } > > =20 > > + /* add migration blocker */ > > + error_setg(&pef_mig_blocker, "PEF: Migration is not implemented"); > > + /* NB: This can fail if --only-migratable is used */ > > + migrate_add_blocker(pef_mig_blocker, &error_fatal); >=20 > Just so that I understand: is PEF something that is enabled by the host > (and the guest is either secured or doesn't start), or is it using a > model like s390x PV where the guest initiates the transition into > secured mode? Like s390x PV it's initiated by the guest. > Asking because s390x adds the migration blocker only when the > transition is actually happening (i.e. guests that do not transition > into secure mode remain migratable.) This has the side effect that you > might be able to start a machine with --only-migratable that > transitions into a non-migratable machine via a guest action, if I'm > not mistaken. Without the new object, I don't see a way to block with > --only-migratable; with it, we should be able to do that. Not sure what > the desirable behaviour is here. Hm, I'm not sure what the best option is here either. >=20 > > + > > return 0; > > } > > =20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --SdvjNjn6lL3tIsv0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl/a8PcACgkQbDjKyiDZ s5J0JRAAm5k3JWI3ONab2QPJtkrHcY8gaAFoBdMG0O1TZ/qh6SQ99l6z2PNXbFac ecp3nNOfHcIvVQgeaT5Q6WHIH8st2K+qXufTr1PIftiTH8I+X/tkjEp9WsPlz+y5 dSSlEQSbdjQ6v1RnD9b7NGHxf8eTAhuCBQosDGPjoSNM39q9WaM6xLT+PMnXVekh dZwhpdQQWfP58oPRXuM3rgo4tnfB67PL44NxfqLrKHVQDxWqgGa4v+FMOvGrm6IT stwtIKamuZDgtXpXVl3HS89WbikLYlnfCZpD+BXdj0Rm7UCDC6es8ZM2NhUe1QaQ wtcwe4Uf2a64YTY/VJCjk1LVi4Fez1v4bMGTX23D+nbHupNoi+Llo/gi4+pqhc6H Yb3+jWv1vc9nC9BWCK0OzyJGBc7FvW4Ur8Bxhm3hmy6WwBQ0rPdxs3xrlhY3lXLO trOhBsA1Fue7O7DOxheEgRGuuMGugKCxcZKVuzh5LbRugLkHmu2e+yXhgxyveLtn l4Ypb2qRcClZuGT+fRbdWsRCaKwCZtc4c4obKNMiT/gDl2E/YsMrNDMkpX1cFgyL ijcgFCS7l/SELvrkjNt74TpBj55fzAnyb/mhLztlYWNanfPUherIFc7BhZ26sa7t Wx6w/6XPm0fozCzj9BvPg9svZPIr0ql+QtfiMa4CoriY+T6jIqU= =diPo -----END PGP SIGNATURE----- --SdvjNjn6lL3tIsv0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AC4C4361B for ; Thu, 17 Dec 2020 06:09:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8DE32371F for ; Thu, 17 Dec 2020 06:09:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8DE32371F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpmU3-0004dq-O3 for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 01:09:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpmLF-0000Mw-Nc; Thu, 17 Dec 2020 01:00:45 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:49089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpmL5-0001HH-Gm; Thu, 17 Dec 2020 01:00:40 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CxLvJ0Q6Bz9sTv; Thu, 17 Dec 2020 17:00:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1608184828; bh=7b/4HdUoY4KqFQN7P8s4ld6mZkyQK98LyF3YI8eIOPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZJnJYKCkxkR+I5kadzvUCg8MjNbHrxVXQe7dMa8YfCJpuatfw6nmtVC3A6Mbt+D5j XVSDxVqdHVx9POMeiWsNZmQ1zBpwm5xAHMk1QFUWmPgmfneGY1q7m+GlgHNTjaouNr PP9M4GwQiDWVW7JtahYmJYgryIsabFwG9Y0WhvoQ= Date: Thu, 17 Dec 2020 16:47:36 +1100 From: David Gibson To: Cornelia Huck Subject: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration Message-ID: <20201217054736.GH310465@yekko.fritz.box> References: <20201204054415.579042-1-david@gibson.dropbear.id.au> <20201204054415.579042-12-david@gibson.dropbear.id.au> <20201214182240.2abd85eb.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SdvjNjn6lL3tIsv0" Content-Disposition: inline In-Reply-To: <20201214182240.2abd85eb.cohuck@redhat.com> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pair@us.ibm.com, brijesh.singh@amd.com, frankja@linux.ibm.com, kvm@vger.kernel.org, "Michael S. Tsirkin" , Richard Henderson , Marcelo Tosatti , david@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com, thuth@redhat.com, pbonzini@redhat.com, rth@twiddle.net, mdroth@linux.vnet.ibm.com, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --SdvjNjn6lL3tIsv0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 14, 2020 at 06:22:40PM +0100, Cornelia Huck wrote: > On Fri, 4 Dec 2020 16:44:13 +1100 > David Gibson wrote: >=20 > > We haven't yet implemented the fairly involved handshaking that will be > > needed to migrate PEF protected guests. For now, just use a migration > > blocker so we get a meaningful error if someone attempts this (this is = the > > same approach used by AMD SEV). > >=20 > > Signed-off-by: David Gibson > > Reviewed-by: Dr. David Alan Gilbert > > --- > > hw/ppc/pef.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c > > index 3ae3059cfe..edc3e744ba 100644 > > --- a/hw/ppc/pef.c > > +++ b/hw/ppc/pef.c > > @@ -38,7 +38,11 @@ struct PefGuestState { > > }; > > =20 > > #ifdef CONFIG_KVM > > +static Error *pef_mig_blocker; > > + > > static int kvmppc_svm_init(Error **errp) >=20 > This looks weird? Oops. Not sure how that made it past even my rudimentary compile testing. > > + > > +int kvmppc_svm_init(SecurableGuestMemory *sgm, Error **errp) > > { > > if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURABLE_GUEST)) { > > error_setg(errp, > > @@ -54,6 +58,11 @@ static int kvmppc_svm_init(Error **errp) > > } > > } > > =20 > > + /* add migration blocker */ > > + error_setg(&pef_mig_blocker, "PEF: Migration is not implemented"); > > + /* NB: This can fail if --only-migratable is used */ > > + migrate_add_blocker(pef_mig_blocker, &error_fatal); >=20 > Just so that I understand: is PEF something that is enabled by the host > (and the guest is either secured or doesn't start), or is it using a > model like s390x PV where the guest initiates the transition into > secured mode? Like s390x PV it's initiated by the guest. > Asking because s390x adds the migration blocker only when the > transition is actually happening (i.e. guests that do not transition > into secure mode remain migratable.) This has the side effect that you > might be able to start a machine with --only-migratable that > transitions into a non-migratable machine via a guest action, if I'm > not mistaken. Without the new object, I don't see a way to block with > --only-migratable; with it, we should be able to do that. Not sure what > the desirable behaviour is here. Hm, I'm not sure what the best option is here either. >=20 > > + > > return 0; > > } > > =20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --SdvjNjn6lL3tIsv0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl/a8PcACgkQbDjKyiDZ s5J0JRAAm5k3JWI3ONab2QPJtkrHcY8gaAFoBdMG0O1TZ/qh6SQ99l6z2PNXbFac ecp3nNOfHcIvVQgeaT5Q6WHIH8st2K+qXufTr1PIftiTH8I+X/tkjEp9WsPlz+y5 dSSlEQSbdjQ6v1RnD9b7NGHxf8eTAhuCBQosDGPjoSNM39q9WaM6xLT+PMnXVekh dZwhpdQQWfP58oPRXuM3rgo4tnfB67PL44NxfqLrKHVQDxWqgGa4v+FMOvGrm6IT stwtIKamuZDgtXpXVl3HS89WbikLYlnfCZpD+BXdj0Rm7UCDC6es8ZM2NhUe1QaQ wtcwe4Uf2a64YTY/VJCjk1LVi4Fez1v4bMGTX23D+nbHupNoi+Llo/gi4+pqhc6H Yb3+jWv1vc9nC9BWCK0OzyJGBc7FvW4Ur8Bxhm3hmy6WwBQ0rPdxs3xrlhY3lXLO trOhBsA1Fue7O7DOxheEgRGuuMGugKCxcZKVuzh5LbRugLkHmu2e+yXhgxyveLtn l4Ypb2qRcClZuGT+fRbdWsRCaKwCZtc4c4obKNMiT/gDl2E/YsMrNDMkpX1cFgyL ijcgFCS7l/SELvrkjNt74TpBj55fzAnyb/mhLztlYWNanfPUherIFc7BhZ26sa7t Wx6w/6XPm0fozCzj9BvPg9svZPIr0ql+QtfiMa4CoriY+T6jIqU= =diPo -----END PGP SIGNATURE----- --SdvjNjn6lL3tIsv0--