From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB84DC4361B for ; Thu, 17 Dec 2020 06:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C23223884 for ; Thu, 17 Dec 2020 06:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727243AbgLQGqn (ORCPT ); Thu, 17 Dec 2020 01:46:43 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:19618 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgLQGqn (ORCPT ); Thu, 17 Dec 2020 01:46:43 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1608187582; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=4R3W6tc73OQ6y5EIJtBFGS1g5BY1uxW8ec6ZCFvffH0=; b=N2f2vC9W9+lUCKMUy1N/gCJQzlE4GtMU/ZODILHv0xMtUfAIhbaBoGqGqeJ3q4Il/FJr5H6C qLNGEpFrwsHmB2Rze6CGFfWd+HlaaAjC3uqZzTxSO8/QbHyOx1uCWV5j+1ahUkeKjvLubBrU GLM2QDRYISHzVoomVjfg/Lf7NZI= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5fdafe973d3433393d39d8e8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 17 Dec 2020 06:45:43 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EEE98C433C6; Thu, 17 Dec 2020 06:45:42 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 27134C433C6; Thu, 17 Dec 2020 06:45:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 27134C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] ath11k: add missing null check on allocated skb From: Kalle Valo In-Reply-To: <20201214232417.84556-1-colin.king@canonical.com> References: <20201214232417.84556-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , Jakub Kicinski , Carl Huang , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201217064542.EEE98C433C6@smtp.codeaurora.org> Date: Thu, 17 Dec 2020 06:45:42 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > Currently the null check on a newly allocated skb is missing and > this can lead to a null pointer dereference is the allocation fails. > Fix this by adding a null check and returning -ENOMEM. > > Addresses-Coverity: ("Dereference null return") > Fixes: 43ed15e1ee01 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 292bff9480c8 ath11k: add missing null check on allocated skb -- https://patchwork.kernel.org/project/linux-wireless/patch/20201214232417.84556-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 17 Dec 2020 06:45:42 +0000 Subject: Re: [PATCH][next] ath11k: add missing null check on allocated skb Message-Id: <20201217064542.EEE98C433C6@smtp.codeaurora.org> List-Id: References: <20201214232417.84556-1-colin.king@canonical.com> In-Reply-To: <20201214232417.84556-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: "David S . Miller" , Jakub Kicinski , Carl Huang , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin King wrote: > Currently the null check on a newly allocated skb is missing and > this can lead to a null pointer dereference is the allocation fails. > Fix this by adding a null check and returning -ENOMEM. > > Addresses-Coverity: ("Dereference null return") > Fixes: 43ed15e1ee01 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 292bff9480c8 ath11k: add missing null check on allocated skb -- https://patchwork.kernel.org/project/linux-wireless/patch/20201214232417.84556-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches