All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license
@ 2020-12-18  5:36 Yu, Mingli
  2020-12-18  7:47 ` [OE-core] " Alexander Kanavin
  0 siblings, 1 reply; 3+ messages in thread
From: Yu, Mingli @ 2020-12-18  5:36 UTC (permalink / raw)
  To: openembedded-core

From: Mingli Yu <mingli.yu@windriver.com>

packagegroup-core-base-utils repends on some packages which are
gplv3 compatilbe.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 .../packagegroups/packagegroup-core-base-utils.bb  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
index 1e63da7f16..0a3cb63bc2 100644
--- a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
+++ b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
@@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
     grep \
     gzip \
     ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "", "ifupdown", d)} \
-    inetutils \
-    inetutils-ping \
-    inetutils-telnet \
-    inetutils-tftp \
-    inetutils-traceroute \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-ping', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-telnet', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-tftp', d)} \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'inetutils-traceroute', d)} \
     iproute2 \
     ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd", "", d)} \
     kmod \
     less \
     ncurses-tools \
     net-tools \
-    parted \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'parted', d)} \
     patch \
     procps \
     psmisc \
@@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
     unzip \
     util-linux \
     ${VIRTUAL-RUNTIME_vim} \
-    wget \
+    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'wget', d)} \
     which \
     xz \
     "
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license
  2020-12-18  5:36 [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license Yu, Mingli
@ 2020-12-18  7:47 ` Alexander Kanavin
  2021-04-17 15:44   ` Randy MacLeod
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2020-12-18  7:47 UTC (permalink / raw)
  To: Yu, Mingli; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]

I’m not sure I like this approach. It doesn’t look like the right place to
decide whether to include or not some packages based on specific licensing
requirements, licenses for these and other items change over time, and
there may be more undesirable licenses than just this one.

Why not simply create a new package group?

Alex

On Fri 18. Dec 2020 at 6.37, Yu, Mingli <mingli.yu@windriver.com> wrote:

> From: Mingli Yu <mingli.yu@windriver.com>
>
> packagegroup-core-base-utils repends on some packages which are
> gplv3 compatilbe.
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  .../packagegroups/packagegroup-core-base-utils.bb  | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-extended/packagegroups/
> packagegroup-core-base-utils.bb b/meta/recipes-extended/packagegroups/
> packagegroup-core-base-utils.bb
> index 1e63da7f16..0a3cb63bc2 100644
> --- a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> +++ b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb
> @@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
>      grep \
>      gzip \
>      ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "", "ifupdown",
> d)} \
> -    inetutils \
> -    inetutils-ping \
> -    inetutils-telnet \
> -    inetutils-tftp \
> -    inetutils-traceroute \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-ping', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-telnet', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-tftp', d)} \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
> 'inetutils-traceroute', d)} \
>      iproute2 \
>      ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd", "", d)} \
>      kmod \
>      less \
>      ncurses-tools \
>      net-tools \
> -    parted \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'parted',
> d)} \
>      patch \
>      procps \
>      psmisc \
> @@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
>      unzip \
>      util-linux \
>      ${VIRTUAL-RUNTIME_vim} \
> -    wget \
> +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '', 'wget', d)}
> \
>      which \
>      xz \
>      "
> --
> 2.26.2
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 3929 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license
  2020-12-18  7:47 ` [OE-core] " Alexander Kanavin
@ 2021-04-17 15:44   ` Randy MacLeod
  0 siblings, 0 replies; 3+ messages in thread
From: Randy MacLeod @ 2021-04-17 15:44 UTC (permalink / raw)
  To: Alexander Kanavin, Yu, Mingli; +Cc: openembedded-core

On 2020-12-18 2:47 a.m., Alexander Kanavin wrote:
> I’m not sure I like this approach. It doesn’t look like the right place 
> to decide whether to include or not some packages based on specific 
> licensing requirements, licenses for these and other items change over 
> time, and there may be more undesirable licenses than just this one.
> 
> Why not simply create a new package group?
> 
> Alex

Makes sense to me, Mingli?

I'm replying months later because I see that we fixed this locally
without getting agreement with Alex and other oe-core devs. Not a
big deal but we want to minimize our collection of WR specific patches.

../Randy
> 
> On Fri 18. Dec 2020 at 6.37, Yu, Mingli <mingli.yu@windriver.com 
> <mailto:mingli.yu@windriver.com>> wrote:
> 
>     From: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
> 
>     packagegroup-core-base-utils repends on some packages which are
>     gplv3 compatilbe.
> 
>     Signed-off-by: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
>     ---
>       .../packagegroups/packagegroup-core-base-utils.bb
>     <http://packagegroup-core-base-utils.bb>  | 14 +++++++-------
>       1 file changed, 7 insertions(+), 7 deletions(-)
> 
>     diff --git
>     a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     index 1e63da7f16..0a3cb63bc2 100644
>     ---
>     a/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     +++
>     b/meta/recipes-extended/packagegroups/packagegroup-core-base-utils.bb <http://packagegroup-core-base-utils.bb>
>     @@ -33,18 +33,18 @@ RDEPENDS_${PN} = "\
>           grep \
>           gzip \
>           ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "",
>     "ifupdown", d)} \
>     -    inetutils \
>     -    inetutils-ping \
>     -    inetutils-telnet \
>     -    inetutils-tftp \
>     -    inetutils-traceroute \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-ping', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-telnet', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-tftp', d)} \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'inetutils-traceroute', d)} \
>           iproute2 \
>           ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "kbd",
>     "", d)} \
>           kmod \
>           less \
>           ncurses-tools \
>           net-tools \
>     -    parted \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'parted', d)} \
>           patch \
>           procps \
>           psmisc \
>     @@ -55,7 +55,7 @@ RDEPENDS_${PN} = "\
>           unzip \
>           util-linux \
>           ${VIRTUAL-RUNTIME_vim} \
>     -    wget \
>     +    ${@bb.utils.contains('INCOMPATIBLE_LICENSE', 'GPLv3', '',
>     'wget', d)} \
>           which \
>           xz \
>           "
>     -- 
>     2.26.2
> 
> 
> 
> 
> 
> 
> 
> 


-- 
# Randy MacLeod
# Wind River Linux

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-17 15:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18  5:36 [PATCH] packagegroup-core-base-utils.bb: check the gplv3 license Yu, Mingli
2020-12-18  7:47 ` [OE-core] " Alexander Kanavin
2021-04-17 15:44   ` Randy MacLeod

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.