From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7136BC2BBD5 for ; Fri, 18 Dec 2020 20:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C21323ACA for ; Fri, 18 Dec 2020 20:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387501AbgLRUSu (ORCPT ); Fri, 18 Dec 2020 15:18:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387497AbgLRUSt (ORCPT ); Fri, 18 Dec 2020 15:18:49 -0500 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92B7C06138C for ; Fri, 18 Dec 2020 12:18:06 -0800 (PST) Received: by mail-qk1-x72b.google.com with SMTP id c7so3257240qke.1 for ; Fri, 18 Dec 2020 12:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TN0YKydFOcwaoL0LprOHmYM5z1euEdDwBFvpqdblXvs=; b=UXAPftnZ62lfDQZO6VMuyWluH5OP9yuMUyZvxPCaFLZwji7q8uQx2BfJWYDrWiJkSJ ljf7wkT62mhdorwbCMReuNyHhVFCbjaxshGPm6PAtZkuM2BOpyPRIxaPRhKi83WaPoYT spywgkVUhBYFJLlpOUFnPmzhnifKoS9IdSIXC3m7pmPk5VAwxg/KTSVWsa0IKlqIBy8Y Db2RhAeWVe6NIOIdKwsI6pqwwlj4t8njKOJCZs1/Hqb1ihmSGicwfdC8jKJCb4lb6Grr /8nEpQMo721xvJfD972MCxnEkTbgdx62C5291zCTiBQspPyeLxXQUHts+Tsv/nQJdBWw V5aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TN0YKydFOcwaoL0LprOHmYM5z1euEdDwBFvpqdblXvs=; b=Xvg9twFLvVUsvK7+X5SvzRcAhdsJ1G1vxETlPgT673e5rhR8HLfTQTEKg6DrS8RPGO B6qsweulhyZQ8bvY3Woy7QeTSnMrA4XnLjRsK1SCAcxnocA8CBDGfKEpv5vs4y7KdZBQ SVAveOSQ4Dl5zrWrgiylHS0a263EXbL/Q3wWKsBb2hz+jdzoagrKBoJ/93tp6wq0HIW+ 5Ulqvqj/hTDlquyhor6xAo/8y3SPNd3mgQB8AYqlS/D1pvaIrnc2iYY7KgWyQSEj2dVy 1t89xK2jPtZ4/XW+EqcGRqPGnZ7QDlp4pVzlWDdZrWRErG6mT61GCcx67lR0f/7/CtWZ 1VZw== X-Gm-Message-State: AOAM533zYXefr+ZC/qWnoJwOQqtFEWhmqKbpTXxqJOPZU7HtSjZBKhJy n1wVC3U5ds06w873mxcoPabjDA== X-Google-Smtp-Source: ABdhPJzqt2OVq2gxNomgOEqcAGDJcT+MkbCR1AE0CrFP1EVr8TeDBcLZ4GpnxOxyn/dDv0ApFuP8pA== X-Received: by 2002:a37:b82:: with SMTP id 124mr6640244qkl.294.1608322686035; Fri, 18 Dec 2020 12:18:06 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id 60sm5782291qth.14.2020.12.18.12.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 12:18:05 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kqMCS-00Ctfw-PO; Fri, 18 Dec 2020 16:18:04 -0400 Date: Fri, 18 Dec 2020 16:18:04 -0400 From: Jason Gunthorpe To: Alexander Duyck Cc: Parav Pandit , David Ahern , Saeed Mahameed , "David S. Miller" , Jakub Kicinski , Leon Romanovsky , Netdev , "linux-rdma@vger.kernel.org" , David Ahern , Jacob Keller , Sridhar Samudrala , "Ertman, David M" , Dan Williams , Kiran Patil , Greg KH Subject: Re: [net-next v4 00/15] Add mlx5 subfunction support Message-ID: <20201218201804.GQ5487@ziepe.ca> References: <20201216175112.GJ552508@nvidia.com> <20201216203537.GM552508@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Dec 18, 2020 at 11:22:12AM -0800, Alexander Duyck wrote: > Also as far as the patch count complaints I have seen in a few threads > I would be fine with splitting things up so that the devlink and aux > device creation get handled in one set, and then we work out the > details of mlx5 attaching to the devices and spawning of the SF > netdevs in another since that seems to be where the debate is. It doesn't work like that. The aux device creates a mlx5_core and every mlx5_core can run mlx5_en. This really isn't the series to raise this feature request. Adding an optional short cut path to VF/SF is something that can be done later if up to date benchmarks show it has value. There is no blocker in this model to doing that. Jason