From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DA0C3526C for ; Fri, 18 Dec 2020 21:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 705D223B8C for ; Fri, 18 Dec 2020 21:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbgLRVRg (ORCPT ); Fri, 18 Dec 2020 16:17:36 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:39904 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgLRVRg (ORCPT ); Fri, 18 Dec 2020 16:17:36 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8EAAA20026; Fri, 18 Dec 2020 22:16:40 +0100 (CET) Date: Fri, 18 Dec 2020 22:16:38 +0100 From: Sam Ravnborg To: Arnd Bergmann Cc: David S Miller , sparclinux , Andreas Larsson , Alexey Dobriyan , Al Viro , Andrew Morton , Anshuman Khandual , Arvind Sankar , Christian Brauner , Denis Efremov , Dmitry Safonov <0x7f454c46@gmail.com>, Geert Uytterhoeven , Greg Kroah-Hartman , Ira Weiny , Lorenzo Pieralisi , Mark Rutland , Mike Rapoport , Pekka Enberg , Peter Zijlstra , Stephen Rothwell , Thomas Gleixner , Will Deacon , Willy Tarreau , "linux-kernel@vger.kernel.org" , debian-sparc@lists.debian.org Subject: Re: [PATCH v1 02/13] sparc32: Drop floppy support Message-ID: <20201218211638.GA2421393@ravnborg.org> References: <20201218184347.2180772-1-sam@ravnborg.org> <20201218184347.2180772-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=J1Y8HTJGAAAA:8 a=VwQbUJbxAAAA:8 a=Z4Rwk6OoAAAA:8 a=NufY4J3AAAAA:8 a=MYakio4dAAAA:8 a=fxJcL_dCAAAA:8 a=ebG-ZW-8AAAA:8 a=9jQWrajF32laIYKc0cIA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=AjGcO6oz07-iQ99wixmX:22 a=HkZW87K1Qel5hWWM3VKY:22 a=TPcZfFuj8SYsoCJAFAiX:22 a=cei-m1nUyINrUup_78-m:22 a=Bj2TwAA_C77lQ_X2_dkp:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 18, 2020 at 09:57:47PM +0100, Arnd Bergmann wrote: > On Fri, Dec 18, 2020 at 7:43 PM Sam Ravnborg wrote: > > > > LEON do not have floppy support so we can drop it > > > > Signed-off-by: Sam Ravnborg > > Cc: "David S. Miller" > > Cc: Sam Ravnborg > > Cc: Mike Rapoport > > Cc: Andrew Morton > > Cc: Denis Efremov > > Cc: Willy Tarreau > > Cc: Christian Brauner > > Cc: sparclinux@vger.kernel.org > > Cc: Arnd Bergmann > > Cc: Andreas Larsson > > --- > > arch/sparc/Kconfig | 2 +- > > arch/sparc/include/asm/floppy.h | 786 ++++++++++++++++++++++++++++- > > arch/sparc/include/asm/floppy_32.h | 393 --------------- > > arch/sparc/include/asm/floppy_64.h | 779 ---------------------------- > > Rather than renaming the floppy_64.h to floppy.h, it might be easier to just > remove the #else from floppy.h, similar to what asm/adi.h does. That is what I had first but then thought it pointless with a wrapper file. I will revert back to use floppy_64.h for now - we can always consolidate header files later. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Fri, 18 Dec 2020 21:16:38 +0000 Subject: Re: [PATCH v1 02/13] sparc32: Drop floppy support Message-Id: <20201218211638.GA2421393@ravnborg.org> List-Id: References: <20201218184347.2180772-1-sam@ravnborg.org> <20201218184347.2180772-3-sam@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: David S Miller , sparclinux , Andreas Larsson , Alexey Dobriyan , Al Viro , Andrew Morton , Anshuman Khandual , Arvind Sankar , Christian Brauner , Denis Efremov , Dmitry Safonov <0x7f454c46@gmail.com>, Geert Uytterhoeven , Greg Kroah-Hartman , Ira Weiny , Lorenzo Pieralisi , Mark Rutland , Mike Rapoport , Pekka Enberg , Peter Zijlstra , Stephen Rothwell , Thomas Gleixner , Will Deacon , Willy Tarreau , "linux-kernel@vger.kernel.org" , debian-sparc@lists.debian.org On Fri, Dec 18, 2020 at 09:57:47PM +0100, Arnd Bergmann wrote: > On Fri, Dec 18, 2020 at 7:43 PM Sam Ravnborg wrote: > > > > LEON do not have floppy support so we can drop it > > > > Signed-off-by: Sam Ravnborg > > Cc: "David S. Miller" > > Cc: Sam Ravnborg > > Cc: Mike Rapoport > > Cc: Andrew Morton > > Cc: Denis Efremov > > Cc: Willy Tarreau > > Cc: Christian Brauner > > Cc: sparclinux@vger.kernel.org > > Cc: Arnd Bergmann > > Cc: Andreas Larsson > > --- > > arch/sparc/Kconfig | 2 +- > > arch/sparc/include/asm/floppy.h | 786 ++++++++++++++++++++++++++++- > > arch/sparc/include/asm/floppy_32.h | 393 --------------- > > arch/sparc/include/asm/floppy_64.h | 779 ---------------------------- > > Rather than renaming the floppy_64.h to floppy.h, it might be easier to just > remove the #else from floppy.h, similar to what asm/adi.h does. That is what I had first but then thought it pointless with a wrapper file. I will revert back to use floppy_64.h for now - we can always consolidate header files later. Sam