CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201218210750.3455872-1-saravanak@google.com>
References: <20201218210750.3455872-1-saravanak@google.com>
TO: Saravana Kannan <saravanak@google.com>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
TO: Rob Herring <robh+dt@kernel.org>
TO: Frank Rowand <frowand.list@gmail.com>
CC: Saravana Kannan <saravanak@google.com>
CC: Marc Zyngier <maz@kernel.org>
CC: Kevin Hilman <khilman@baylibre.com>
CC: kernel-team(a)android.com
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

Hi Saravana,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.10 next-20201218]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Saravana-Kannan/of-property-Add-device-link-support-for-interrupts/20201219-051015
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-randconfig-m021-20201217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/of/property.c:1335 parse_interrupts() error: uninitialized symbol 'sup'.

vim +/sup +1335 drivers/of/property.c

e149573b2f84d05 Will Deacon     2019-11-20  1321  
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1322  static struct device_node *parse_interrupts(struct device_node *np,
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1323  					    const char *prop_name, int index)
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1324  {
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1325  	struct device_node *sup;
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1326  
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1327  	if (strcmp(prop_name, "interrupts") || index)
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1328  		return NULL;
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1329  
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1330  	of_node_get(np);
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1331  	while (np && !(sup = of_parse_phandle(np, "interrupt-parent", 0)))
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1332  		np = of_get_next_parent(np);
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1333  	of_node_put(np);
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1334  
12bb2bcf0f092e2 Saravana Kannan 2020-12-18 @1335  	return sup;
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1336  }
12bb2bcf0f092e2 Saravana Kannan 2020-12-18  1337  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org