From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CBBC433E0 for ; Mon, 21 Dec 2020 08:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C850229EF for ; Mon, 21 Dec 2020 08:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbgLUILA (ORCPT ); Mon, 21 Dec 2020 03:11:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgLUIK7 (ORCPT ); Mon, 21 Dec 2020 03:10:59 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED706C061285 for ; Mon, 21 Dec 2020 00:10:19 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id y23so10050376wmi.1 for ; Mon, 21 Dec 2020 00:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8twWC59nf0hTSYRSk++JzXeEHnzUQgXnLgzo/+5kK6g=; b=ak/30GTUKGf0uURuIBRwK+Z5nJM5LLKw2sFfAb3zHnm6/kGc8thcF/tq1Kdw0YgePc quZBt+/yN0XkBbH/2ISxoXBxFlrf5SW/EIvSLp7LpjmM6y7oCghJ+6XmDxWTJl9qxg7A VzpHTZ8yM97NEExXS00xYG2q8l7LBzVWExi8rJo5SamM2C1AiyixFAeHyWbzaC3Oxecd eQvcC33NzsBe5WsAH1lbD5KtPhsuAvtTZB/NUrsyFXtDYC94GeBeq5bwxYfsxYQqNV0I Qy7fowAljpu7XMO0oFZFeYq644ZHr47XXw/yhWS75H17Jk381f8jC5QBpVkeKsWhle4F guug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8twWC59nf0hTSYRSk++JzXeEHnzUQgXnLgzo/+5kK6g=; b=Bj/rFaTZoLRocXyh67+sSA3SpQYFXhdnZM14Kt3HkJ3cRUg3z1BpCmOJigvyQrJYMc ot/TfXwO5FgAJw9VpDZAEhT2hc9mJnyVZAn3sRRrqYOoAOsDY2tj6+KOSNKaWA7X3BA7 gXCR7798JCsozCecJH8rzsx2HohiyrXJGGUurnYg3Ng3RJR4Dm9GaetOUJrxNjdQ9O0V nhqA5yS8tWGnWGiND1D6K6DXBtcZveWPnxdnlsX0Aj3saTWw0JEfUq79WvJyOYFGBpRF LalmZtoJgbM6/rD9vEeFXXuQMNtAh66JG+sQ77IuXGAhXfVAP82ru7WHgAa1nL0rNhO3 PdGg== X-Gm-Message-State: AOAM530ZEzdQcvfcH33HRn2+OvgWnDgotk2NAhwwJExQztiu66cCy553 LaYCcMx7LamIuW9SNP3yMt+8Kg== X-Google-Smtp-Source: ABdhPJyzsu0gxJR0INTrbYFQFjvuiP/hGxunooQWgYOOw8WFVAyYSQeKqMfhChXQwTCsxaVthOHAwA== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr15647996wme.30.1608538218599; Mon, 21 Dec 2020 00:10:18 -0800 (PST) Received: from dell ([91.110.221.144]) by smtp.gmail.com with ESMTPSA id a62sm26520714wmh.40.2020.12.21.00.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 00:10:17 -0800 (PST) Date: Mon, 21 Dec 2020 08:10:15 +0000 From: Lee Jones To: Cristian Ciocaltea Cc: Rob Herring , Dmitry Torokhov , Sebastian Reichel , Mark Brown , Manivannan Sadhasivam , Liam Girdwood , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-actions@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs Message-ID: <20201221081015.GA4825@dell> References: <20201216101000.GD207743@dell> <20201217231731.GA104305@BV030612LT> <20201218132139.GR207743@dell> <20201218160710.GA134686@BV030612LT> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201218160710.GA134686@BV030612LT> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > On Fri, Dec 18, 2020 at 01:21:39PM +0000, Lee Jones wrote: > > On Fri, 18 Dec 2020, Cristian Ciocaltea wrote: > > > > > Hi Lee, > > > > > > Thank you for the detailed review! > > > > > > I will prepare a new revision, but there are still a couple of open > > > points.. > > > > Could you please snip your replies, leaving only the open points. > > > > Scrolling through lots of empty quotes or "done" comments is quite > > time consuming. Thanks. > > Sure, I'll take that into account. > > > [...] > > > > > > > + ret = regmap_read(atc260x->regmap, atc260x->rev_reg, &chip_rev); > > > > > + if (ret) { > > > > > + dev_err(dev, "Failed to get chip revision\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + if (chip_rev < 0 || chip_rev > 31) { > > > > > + dev_err(dev, "Unknown chip revision: %d\n", ret); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > This still seems limiting. > > > > > > This is based on the vendor implementation. Unfortunately I don't have > > > access to a data sheet or any other source of information about the > > > management of the chip revisions. > > > > So which versions does this driver work with? All 32? > > I'm not even sure there are so many revisions, I guess that's just a > rough validation for a vendor reserved range. > > For the moment, the only place where the functionality is affected > by the chip revision is in the regulator driver - there is a special > handling for the ATC2603C rev.B chip variant. > > I expect some additional handling might be required for new drivers > bringing support for the other functions provided by the hardware. The current patch seems to insinuate that 32 versions are currently supported. What is the chip_rev for the ATC2603C rev.B? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog