From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5496C433E0 for ; Mon, 21 Dec 2020 10:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81D9F22ADF for ; Mon, 21 Dec 2020 10:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbgLUKY3 (ORCPT ); Mon, 21 Dec 2020 05:24:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgLUKY2 (ORCPT ); Mon, 21 Dec 2020 05:24:28 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F97CC061793 for ; Mon, 21 Dec 2020 02:23:48 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krHMG-00085d-9s; Mon, 21 Dec 2020 10:20:00 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1krHMF-0007xo-Q4; Mon, 21 Dec 2020 10:19:59 +0100 Date: Mon, 21 Dec 2020 10:19:59 +0100 From: Michael Tretter To: Stephen Boyd Cc: devicetree@vger.kernel.org, dshah@xilinx.com, mturquette@baylibre.com, tejasp@xilinx.com, rajanv@xilinx.com, robh+dt@kernel.org, michals@xilinx.com, rvisaval@xilinx.com, kernel@pengutronix.de, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/12] soc: xilinx: vcu: Convert driver to clock provider Message-ID: <20201221091959.GB22033@pengutronix.de> References: <20201116075532.4019252-1-m.tretter@pengutronix.de> <160783860077.1580929.7577989890301235621@swboyd.mtv.corp.google.com> <20201215115632.GB23407@pengutronix.de> <160808624070.1580929.14530755991373122337@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160808624070.1580929.14530755991373122337@swboyd.mtv.corp.google.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:18:30 up 18 days, 21:45, 56 users, load average: 0.94, 0.79, 0.63 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 15 Dec 2020 18:37:20 -0800, Stephen Boyd wrote: > Quoting Michael Tretter (2020-12-15 03:56:32) > > On Sat, 12 Dec 2020 21:50:00 -0800, Stephen Boyd wrote: > > > Quoting Michael Tretter (2020-11-15 23:55:20) > > > > Hello, > > > > > > > > the xlnx_vcu soc driver is actually a clock provider of a PLL and four output > > > > clocks created from the PLL via dividers. > > > > > > > > This series reworks the xlnx_vcu driver to use the common clock framework to > > > > enable other drivers to use the clocks. I originally posted a series to expose > > > > the output clocks as fixed clocks [0]. This series now implements the full > > > > tree from the PLL to the output clocks. Therefore, I am sending a separate > > > > series that focuses on the clocks, but it depends on v4 of the previous series > > > > [1]. > > > > > > After this series is this anything besides a clk provider? If it's only > > > providing clks it would make sense to move the driver into drivers/clk/ > > > > > > > 1. The driver is also responsible for resetting the entire VCU (the > > VCU_GASKET_INIT register). This isn't something that an individual encoder or > > decoder driver should be doing. However, other clock drivers also implement a > > reset controller. > > Right. > > > > > 2. There are several registers for AXI performance monitoring in the VCU > > System-Level Control register space. Right now, these are not used by the > > driver and I have no plans to actually use them, but this might be an argument > > against the move. > > I suppose if/when that happens we can have a small parent driver that > probes the compatible string and makes two child platform devices, one > for the clk part and one for the PMU? That would let us keep the code in > drivers/clk/ for ease of find-ability. This assumes that the PMU > registers don't overlap with the clk/reset registers. We usually put the > clk and reset controllers together if they use the same registers and > need to make sure the frameworks don't stomp on each other. > > > > > I think it is OK to move the driver to drivers/clk/, but I don't have a strong > > opinion about it. > > > > Ok. I'm not too strong on it either, but drivers/soc/ is sort of a > dumping ground for random soc things. I'm not looking at it closely but > if the driver is in drivers/clk/ I'd be more inclined to look after the > clk bits. OK, I will move the driver to drivers/clk/xilinx/ Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD1AC433E0 for ; Mon, 21 Dec 2020 09:23:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7881922CA1 for ; Mon, 21 Dec 2020 09:23:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7881922CA1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MJZr+vvJnTEMLrsI9Hu9s+jrNGp5oVq4kacfIw0K4rM=; b=m96js17tj0djDyVJPblu9nIRv IHPNmQROaECNIZcAWXmRQhnWfR3f4cajtv+Awcz6e/BydaDhNREJZ182qZil9AMbzsQP5SQ9Ihqxh tl/x4mBSECcy5Kq1ZFZ4mBPwU721tYhJ5APf+5zTg+GCw0zCJdT0KWG3PsmoXaf01rLtMxo6zZch8 MdiIRrCKpXwO2UKG5HcLWOaQ/UoSGYJx4Vxmx6wrGWGPcOznbV0pPR4VzhYnm1VJJqSIEgE1u/9dz LaAxUK/WYuRRco4LqVXK9hg0g2gMcvYRlpkD+Th0Fl5CU3HhXk38pHRrFrH+fyl+vT5vwbcTNPQhy MtMIIQ4ug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krHO6-0004au-Ti; Mon, 21 Dec 2020 09:21:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krHO3-0004ZJ-11 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 09:21:51 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krHMG-00085d-9s; Mon, 21 Dec 2020 10:20:00 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1krHMF-0007xo-Q4; Mon, 21 Dec 2020 10:19:59 +0100 Date: Mon, 21 Dec 2020 10:19:59 +0100 From: Michael Tretter To: Stephen Boyd Subject: Re: [PATCH 00/12] soc: xilinx: vcu: Convert driver to clock provider Message-ID: <20201221091959.GB22033@pengutronix.de> References: <20201116075532.4019252-1-m.tretter@pengutronix.de> <160783860077.1580929.7577989890301235621@swboyd.mtv.corp.google.com> <20201215115632.GB23407@pengutronix.de> <160808624070.1580929.14530755991373122337@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160808624070.1580929.14530755991373122337@swboyd.mtv.corp.google.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:18:30 up 18 days, 21:45, 56 users, load average: 0.94, 0.79, 0.63 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_042151_127296_87638A1A X-CRM114-Status: GOOD ( 31.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, dshah@xilinx.com, tejasp@xilinx.com, mturquette@baylibre.com, rajanv@xilinx.com, robh+dt@kernel.org, michals@xilinx.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, linux-clk@vger.kernel.org, rvisaval@xilinx.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Dec 2020 18:37:20 -0800, Stephen Boyd wrote: > Quoting Michael Tretter (2020-12-15 03:56:32) > > On Sat, 12 Dec 2020 21:50:00 -0800, Stephen Boyd wrote: > > > Quoting Michael Tretter (2020-11-15 23:55:20) > > > > Hello, > > > > > > > > the xlnx_vcu soc driver is actually a clock provider of a PLL and four output > > > > clocks created from the PLL via dividers. > > > > > > > > This series reworks the xlnx_vcu driver to use the common clock framework to > > > > enable other drivers to use the clocks. I originally posted a series to expose > > > > the output clocks as fixed clocks [0]. This series now implements the full > > > > tree from the PLL to the output clocks. Therefore, I am sending a separate > > > > series that focuses on the clocks, but it depends on v4 of the previous series > > > > [1]. > > > > > > After this series is this anything besides a clk provider? If it's only > > > providing clks it would make sense to move the driver into drivers/clk/ > > > > > > > 1. The driver is also responsible for resetting the entire VCU (the > > VCU_GASKET_INIT register). This isn't something that an individual encoder or > > decoder driver should be doing. However, other clock drivers also implement a > > reset controller. > > Right. > > > > > 2. There are several registers for AXI performance monitoring in the VCU > > System-Level Control register space. Right now, these are not used by the > > driver and I have no plans to actually use them, but this might be an argument > > against the move. > > I suppose if/when that happens we can have a small parent driver that > probes the compatible string and makes two child platform devices, one > for the clk part and one for the PMU? That would let us keep the code in > drivers/clk/ for ease of find-ability. This assumes that the PMU > registers don't overlap with the clk/reset registers. We usually put the > clk and reset controllers together if they use the same registers and > need to make sure the frameworks don't stomp on each other. > > > > > I think it is OK to move the driver to drivers/clk/, but I don't have a strong > > opinion about it. > > > > Ok. I'm not too strong on it either, but drivers/soc/ is sort of a > dumping ground for random soc things. I'm not looking at it closely but > if the driver is in drivers/clk/ I'd be more inclined to look after the > clk bits. OK, I will move the driver to drivers/clk/xilinx/ Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel