From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 21 Dec 2020 14:04:32 +0200
Subject: [PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to
 increase readability
In-Reply-To: <CAPnjgZ2qWs6LHh+Lj9Si9LgYqyEFdxcOioYJUeQtHSr+GOxRow@mail.gmail.com>
References: <20201216231624.9724-1-andriy.shevchenko@linux.intel.com>
 <20201216231624.9724-5-andriy.shevchenko@linux.intel.com>
 <CAPnjgZ2qWs6LHh+Lj9Si9LgYqyEFdxcOioYJUeQtHSr+GOxRow@mail.gmail.com>
Message-ID: <20201221120432.GP4077@smile.fi.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Dec 18, 2020 at 07:29:21PM -0700, Simon Glass wrote:
> On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Refactor iomux_doenv() a bit in order to increase readability.
> > There is no change in code generation on x86.

...

> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks!

...

> event better:
> 
> if (temp)

I didn't get this. Can you elaborate what exactly you had in mind?
Because...

> > +               temp = strchr(temp, ',');
> > +               if (temp == NULL)

...here is a new code.

> > +                       break;
> > +
> > +               temp++;


Since you gave Rb tag I'll leave as is for now.

-- 
With Best Regards,
Andy Shevchenko