* [PATCH v2 0/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon
This is the initial series to support Engicam i.Core MX8M Mini SOM
and it's associated carrier board dts(i) support.
i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam.
i.Core MX8M Mini needs to mount on top of Engicam baseboards for
creating complete platform boards.
Possible baseboards are,
- EDIMM2.2
- C.TOUCH 2.0
Any inputs?
Jagan.
Jagan Teki (6):
arm64: defconfig: Enable REGULATOR_PF8X00
dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
.../devicetree/bindings/arm/fsl.yaml | 3 +
arch/arm64/boot/dts/freescale/Makefile | 2 +
.../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++
.../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 +
.../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +
.../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 ++
.../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 ++
.../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
arch/arm64/configs/defconfig | 1 +
9 files changed, 376 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
--
2.25.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2 0/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Catalin Marinas, linux-kernel,
Jagan Teki, linux-amarula, linux-arm-kernel, NXP Linux Team
This is the initial series to support Engicam i.Core MX8M Mini SOM
and it's associated carrier board dts(i) support.
i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam.
i.Core MX8M Mini needs to mount on top of Engicam baseboards for
creating complete platform boards.
Possible baseboards are,
- EDIMM2.2
- C.TOUCH 2.0
Any inputs?
Jagan.
Jagan Teki (6):
arm64: defconfig: Enable REGULATOR_PF8X00
dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
.../devicetree/bindings/arm/fsl.yaml | 3 +
arch/arm64/boot/dts/freescale/Makefile | 2 +
.../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++
.../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 +
.../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +
.../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 ++
.../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 ++
.../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
arch/arm64/configs/defconfig | 1 +
9 files changed, 376 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon
Enable PF8X00 regulator driver by default as it used in
some of i.MX8MM hardware platforms.
Engicam i.Core MX8M Mini SoM is using the PF8121A family PMIC.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index fae83673c3c3..e952c76ee970 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -594,6 +594,7 @@ CONFIG_REGULATOR_HI655X=y
CONFIG_REGULATOR_MAX77620=y
CONFIG_REGULATOR_MAX8973=y
CONFIG_REGULATOR_PCA9450=y
+CONFIG_REGULATOR_PF8X00=y
CONFIG_REGULATOR_PFUZE100=y
CONFIG_REGULATOR_PWM=y
CONFIG_REGULATOR_QCOM_RPMH=y
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Catalin Marinas, linux-kernel,
Jagan Teki, linux-amarula, linux-arm-kernel, NXP Linux Team
Enable PF8X00 regulator driver by default as it used in
some of i.MX8MM hardware platforms.
Engicam i.Core MX8M Mini SoM is using the PF8121A family PMIC.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index fae83673c3c3..e952c76ee970 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -594,6 +594,7 @@ CONFIG_REGULATOR_HI655X=y
CONFIG_REGULATOR_MAX77620=y
CONFIG_REGULATOR_MAX8973=y
CONFIG_REGULATOR_PCA9450=y
+CONFIG_REGULATOR_PF8X00=y
CONFIG_REGULATOR_PFUZE100=y
CONFIG_REGULATOR_PWM=y
CONFIG_REGULATOR_QCOM_RPMH=y
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
C.TOUCH 2.0 is a general purpose carrier board with capacitive
touch interface support.
i.Core MX8M Mini needs to mount on top of this Carrier board for
creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
Add bindings for it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 67980dcef66d..e653e0a43016 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -667,6 +667,8 @@ properties:
items:
- enum:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
+ - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
+ - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
- kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Catalin Marinas, linux-kernel,
Jagan Teki, linux-amarula, linux-arm-kernel, NXP Linux Team
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
C.TOUCH 2.0 is a general purpose carrier board with capacitive
touch interface support.
i.Core MX8M Mini needs to mount on top of this Carrier board for
creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
Add bindings for it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 67980dcef66d..e653e0a43016 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -667,6 +667,8 @@ properties:
items:
- enum:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
+ - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
+ - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
- kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon,
Matteo Lisi
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini
from Engicam.
General features:
- NXP i.MX8M Mini
- Up to 2GB LDDR4
- 8/16GB eMMC
- Gigabit Ethernet
- USB 2.0 Host/OTG
- PCIe Gen2 interface
- I2S
- MIPI DSI to LVDS
- rest of i.MX8M Mini features
i.Core MX8M Mini needs to mount on top of Engicam baseboards
for creating complete platform solutions.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
- add cpu nodes
- add fec1 node
- fixed pmic tree comments
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
.../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
1 file changed, 232 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
new file mode 100644
index 000000000000..e67865fd102a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
@@ -0,0 +1,232 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutons(India)
+ */
+
+/ {
+ compatible = "engicam,icore-mx8mm", "fsl,imx8mm";
+};
+
+&A53_0 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_1 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_2 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_3 {
+ cpu-supply = <®_buck4>;
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-handle = <ðphy>;
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy: ethernet-phy@3 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <3>;
+ reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ };
+ };
+};
+
+&i2c1 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+
+ pmic@8 {
+ compatible = "nxp,pf8121a";
+ reg = <0x08>;
+
+ regulators {
+ reg_ldo1: ldo1 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo2: ldo2 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo3: ldo3 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo4: ldo4 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck1: buck1 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck2: buck2 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck3: buck3 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck4: buck4 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck5: buck5 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck6: buck6 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck7: buck7 {
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_vsnvs: vsnvs {
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
+};
+
+&iomuxc {
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
+ MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3
+ MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f
+ MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f
+ MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f
+ MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f
+ MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
+ MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
+ MX8MM_IOMUXC_NAND_DATA01_GPIO3_IO7 0x19
+ >;
+ };
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_usdhc3: usdhc3grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d0
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d0
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d0
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d0
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x190
+ >;
+ };
+
+ pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d4
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d4
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d4
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d4
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x194
+ >;
+ };
+
+ pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d6
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d6
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d6
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d6
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x196
+ >;
+ };
+};
+
+/* eMMC */
+&usdhc3 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc3>;
+ pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+ bus-width = <8>;
+ non-removable;
+ status = "okay";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Catalin Marinas,
linux-kernel, Jagan Teki, linux-amarula, linux-arm-kernel,
NXP Linux Team
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini
from Engicam.
General features:
- NXP i.MX8M Mini
- Up to 2GB LDDR4
- 8/16GB eMMC
- Gigabit Ethernet
- USB 2.0 Host/OTG
- PCIe Gen2 interface
- I2S
- MIPI DSI to LVDS
- rest of i.MX8M Mini features
i.Core MX8M Mini needs to mount on top of Engicam baseboards
for creating complete platform solutions.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
- add cpu nodes
- add fec1 node
- fixed pmic tree comments
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
.../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
1 file changed, 232 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
new file mode 100644
index 000000000000..e67865fd102a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
@@ -0,0 +1,232 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutons(India)
+ */
+
+/ {
+ compatible = "engicam,icore-mx8mm", "fsl,imx8mm";
+};
+
+&A53_0 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_1 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_2 {
+ cpu-supply = <®_buck4>;
+};
+
+&A53_3 {
+ cpu-supply = <®_buck4>;
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-handle = <ðphy>;
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy: ethernet-phy@3 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <3>;
+ reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ };
+ };
+};
+
+&i2c1 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+
+ pmic@8 {
+ compatible = "nxp,pf8121a";
+ reg = <0x08>;
+
+ regulators {
+ reg_ldo1: ldo1 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo2: ldo2 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo3: ldo3 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_ldo4: ldo4 {
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck1: buck1 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck2: buck2 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck3: buck3 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck4: buck4 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck5: buck5 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck6: buck6 {
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_buck7: buck7 {
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_vsnvs: vsnvs {
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
+};
+
+&iomuxc {
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
+ MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3
+ MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f
+ MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f
+ MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f
+ MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f
+ MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
+ MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
+ MX8MM_IOMUXC_NAND_DATA01_GPIO3_IO7 0x19
+ >;
+ };
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_usdhc3: usdhc3grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d0
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d0
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d0
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d0
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x190
+ >;
+ };
+
+ pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d4
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d4
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d4
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d4
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x194
+ >;
+ };
+
+ pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196
+ MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6
+ MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6
+ MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6
+ MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6
+ MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6
+ MX8MM_IOMUXC_NAND_RE_B_USDHC3_DATA4 0x1d6
+ MX8MM_IOMUXC_NAND_CE2_B_USDHC3_DATA5 0x1d6
+ MX8MM_IOMUXC_NAND_CE3_B_USDHC3_DATA6 0x1d6
+ MX8MM_IOMUXC_NAND_CLE_USDHC3_DATA7 0x1d6
+ MX8MM_IOMUXC_NAND_CE1_B_USDHC3_STROBE 0x196
+ >;
+ };
+};
+
+/* eMMC */
+&usdhc3 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc3>;
+ pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+ bus-width = <8>;
+ non-removable;
+ status = "okay";
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon,
Matteo Lisi
Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier
board.
Genaral features:
- Ethernet 10/100
- Wifi/BT
- USB Type A/OTG
- Audio Out
- CAN
- LVDS panel connector
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
i.Core MX8M Mini needs to mount on top of this Carrier board for
creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- enabled fec1 node
- updated commit message
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
- add i2c nodes
- fixed v1 comments
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++++++++++++++
.../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 ++
.../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++
4 files changed, 111 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 6f0777ee6cd6..8d49a2c74604 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
new file mode 100644
index 000000000000..f7870efd9dab
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
@@ -0,0 +1,82 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+&fec1 {
+ status = "okay";
+};
+
+&i2c2 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+};
+
+&i2c4 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ status = "okay";
+};
+
+&iomuxc {
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C4_SCL_I2C4_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C4_SDA_I2C4_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
+ MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
+ >;
+ };
+
+ pinctrl_usdhc1_gpio: usdhc1gpiogrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x41
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190
+ MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0
+ MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0
+ MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0
+ MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0
+ MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0
+ >;
+ };
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ status = "okay";
+};
+
+/* SD */
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
+ cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+ max-frequency = <50000000>;
+ bus-width = <4>;
+ no-1-8-v;
+ pm-ignore-notify;
+ keep-power-in-suspend;
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
new file mode 100644
index 000000000000..294df07289a2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+#include "imx8mm-engicam-common.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
new file mode 100644
index 000000000000..8eb01b1f882a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+/dts-v1/;
+#include "imx8mm.dtsi"
+#include "imx8mm-engicam-ctouch2.dtsi"
+#include "imx8mm-icore-mx8mm.dtsi"
+
+/ {
+ model = "Engicam i.Core MX8M Mini C.TOUCH 2.0";
+ compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
+ "fsl,imx8mm";
+
+ chosen {
+ stdout-path = &uart2;
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Catalin Marinas,
linux-kernel, Jagan Teki, linux-amarula, linux-arm-kernel,
NXP Linux Team
Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier
board.
Genaral features:
- Ethernet 10/100
- Wifi/BT
- USB Type A/OTG
- Audio Out
- CAN
- LVDS panel connector
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
i.Core MX8M Mini needs to mount on top of this Carrier board for
creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- enabled fec1 node
- updated commit message
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
- add i2c nodes
- fixed v1 comments
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++++++++++++++
.../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 ++
.../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++
4 files changed, 111 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 6f0777ee6cd6..8d49a2c74604 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
new file mode 100644
index 000000000000..f7870efd9dab
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
@@ -0,0 +1,82 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+&fec1 {
+ status = "okay";
+};
+
+&i2c2 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+};
+
+&i2c4 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ status = "okay";
+};
+
+&iomuxc {
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C4_SCL_I2C4_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C4_SDA_I2C4_SDA 0x400001c3
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
+ MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
+ >;
+ };
+
+ pinctrl_usdhc1_gpio: usdhc1gpiogrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x41
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190
+ MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0
+ MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0
+ MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0
+ MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0
+ MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0
+ >;
+ };
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ status = "okay";
+};
+
+/* SD */
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
+ cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+ max-frequency = <50000000>;
+ bus-width = <4>;
+ no-1-8-v;
+ pm-ignore-notify;
+ keep-power-in-suspend;
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
new file mode 100644
index 000000000000..294df07289a2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+#include "imx8mm-engicam-common.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
new file mode 100644
index 000000000000..8eb01b1f882a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+/dts-v1/;
+#include "imx8mm.dtsi"
+#include "imx8mm-engicam-ctouch2.dtsi"
+#include "imx8mm-icore-mx8mm.dtsi"
+
+/ {
+ model = "Engicam i.Core MX8M Mini C.TOUCH 2.0";
+ compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
+ "fsl,imx8mm";
+
+ chosen {
+ stdout-path = &uart2;
+ };
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 5/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation
Board from Engicam.
i.Core MX8M Mini needs to mount on top of this Evaluation board for
creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
Add bindings for it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index e653e0a43016..8c8f7728788d 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -669,6 +669,7 @@ properties:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
- engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
- engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
+ - engicam,icore-mx8mm-edimm2.2 # i.MX8MM Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
- kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 5/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Catalin Marinas, linux-kernel,
Jagan Teki, linux-amarula, linux-arm-kernel, NXP Linux Team
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation
Board from Engicam.
i.Core MX8M Mini needs to mount on top of this Evaluation board for
creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
Add bindings for it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index e653e0a43016..8c8f7728788d 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -669,6 +669,7 @@ properties:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
- engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
- engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
+ - engicam,icore-mx8mm-edimm2.2 # i.MX8MM Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
- kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 11:31 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, linux-kernel, linux-arm-kernel, NXP Linux Team,
linux-amarula, Jagan Teki, Catalin Marinas, Will Deacon,
Matteo Lisi
Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
Evaluation Board.
Genaral features:
- LCD 7" C.Touch
- microSD slot
- Ethernet 1Gb
- Wifi/BT
- 2x LVDS Full HD interfaces
- 3x USB 2.0
- 1x USB 3.0
- HDMI Out
- Mini PCIe
- MIPI CSI
- 2x CAN
- Audio Out
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
i.Core MX8M Mini needs to mount on top of this Evaluation board for
creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
Mainline Linux supported.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
.../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 8d49a2c74604..43783076f856 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
new file mode 100644
index 000000000000..294df07289a2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+#include "imx8mm-engicam-common.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
new file mode 100644
index 000000000000..672aee1800c4
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+/dts-v1/;
+#include "imx8mm.dtsi"
+#include "imx8mm-engicam-edimm2.2.dtsi"
+#include "imx8mm-icore-mx8mm.dtsi"
+
+/ {
+ model = "Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit";
+ compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm",
+ "fsl,imx8mm";
+
+ chosen {
+ stdout-path = &uart2;
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-21 11:31 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 11:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Catalin Marinas,
linux-kernel, Jagan Teki, linux-amarula, linux-arm-kernel,
NXP Linux Team
Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
Evaluation Board.
Genaral features:
- LCD 7" C.Touch
- microSD slot
- Ethernet 1Gb
- Wifi/BT
- 2x LVDS Full HD interfaces
- 3x USB 2.0
- 1x USB 3.0
- HDMI Out
- Mini PCIe
- MIPI CSI
- 2x CAN
- Audio Out
i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
i.Core MX8M Mini needs to mount on top of this Evaluation board for
creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
Mainline Linux supported.
Add support for it.
Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- updated commit message
- dropped engicam from filename since it aligned with imx6 engicam
dts files naming conventions.
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
.../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 8d49a2c74604..43783076f856 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
new file mode 100644
index 000000000000..294df07289a2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2020 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+#include "imx8mm-engicam-common.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
new file mode 100644
index 000000000000..672aee1800c4
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutions(India)
+ */
+
+/dts-v1/;
+#include "imx8mm.dtsi"
+#include "imx8mm-engicam-edimm2.2.dtsi"
+#include "imx8mm-icore-mx8mm.dtsi"
+
+/ {
+ model = "Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit";
+ compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm",
+ "fsl,imx8mm";
+
+ chosen {
+ stdout-path = &uart2;
+ };
+};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* Re: [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 13:42 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:42 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 05:01:46PM +0530, Jagan Teki wrote:
> Enable PF8X00 regulator driver by default as it used in
> some of i.MX8MM hardware platforms.
>
> Engicam i.Core MX8M Mini SoM is using the PF8121A family PMIC.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
>
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00
@ 2020-12-21 13:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:42 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 05:01:46PM +0530, Jagan Teki wrote:
> Enable PF8X00 regulator driver by default as it used in
> some of i.MX8MM hardware platforms.
>
> Engicam i.Core MX8M Mini SoM is using the PF8121A family PMIC.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
>
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 13:46 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:46 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> C.TOUCH 2.0 is a general purpose carrier board with capacitive
> touch interface support.
>
> i.Core MX8M Mini needs to mount on top of this Carrier board for
> creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
>
> Add bindings for it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
>
> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 67980dcef66d..e653e0a43016 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -667,6 +667,8 @@ properties:
> items:
> - enum:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
Please test your DTS against new schema with dtbs_check. This won't
match.
Submitting bindings and DTS which fail on day 0 is the same as sending
code which does not compile.
Best regards,
Krzysztof
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> - kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 13:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:46 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> C.TOUCH 2.0 is a general purpose carrier board with capacitive
> touch interface support.
>
> i.Core MX8M Mini needs to mount on top of this Carrier board for
> creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
>
> Add bindings for it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
>
> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 67980dcef66d..e653e0a43016 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -667,6 +667,8 @@ properties:
> items:
> - enum:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
Please test your DTS against new schema with dtbs_check. This won't
match.
Submitting bindings and DTS which fail on day 0 is the same as sending
code which does not compile.
Best regards,
Krzysztof
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> - kontron,imx8mm-n801x-som # i.MX8MM Kontron SL (N801X) SOM
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 13:52 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:52 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Mon, Dec 21, 2020 at 05:01:48PM +0530, Jagan Teki wrote:
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini
> from Engicam.
>
> General features:
> - NXP i.MX8M Mini
> - Up to 2GB LDDR4
> - 8/16GB eMMC
> - Gigabit Ethernet
> - USB 2.0 Host/OTG
> - PCIe Gen2 interface
> - I2S
> - MIPI DSI to LVDS
> - rest of i.MX8M Mini features
>
> i.Core MX8M Mini needs to mount on top of Engicam baseboards
> for creating complete platform solutions.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
> - add cpu nodes
> - add fec1 node
> - fixed pmic tree comments
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
Thanks for the changes.
>
> .../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
> 1 file changed, 232 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
> new file mode 100644
> index 000000000000..e67865fd102a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2018 NXP
> + * Copyright (c) 2019 Engicam srl
> + * Copyright (c) 2020 Amarula Solutons(India)
> + */
> +
> +/ {
> + compatible = "engicam,icore-mx8mm", "fsl,imx8mm";
> +};
> +
> +&A53_0 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_1 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_2 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_3 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&fec1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_fec1>;
> + phy-mode = "rgmii-id";
> + phy-handle = <ðphy>;
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy@3 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <3>;
> + reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + };
> + };
> +};
> +
> +&i2c1 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + status = "okay";
> +
> + pmic@8 {
> + compatible = "nxp,pf8121a";
> + reg = <0x08>;
> +
> + regulators {
> + reg_ldo1: ldo1 {
> + regulator-max-microvolt = <5000000>;
> + regulator-min-microvolt = <1500000>;
I mentioned previously min/max hoping it will be obvious (as most or
even all of DTS follow this convention... although not example in your
regulator) but let be more specific: first min, then max. Don't reverse
the logic. See also example in the regulator.yaml.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM
@ 2020-12-21 13:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 13:52 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 05:01:48PM +0530, Jagan Teki wrote:
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini
> from Engicam.
>
> General features:
> - NXP i.MX8M Mini
> - Up to 2GB LDDR4
> - 8/16GB eMMC
> - Gigabit Ethernet
> - USB 2.0 Host/OTG
> - PCIe Gen2 interface
> - I2S
> - MIPI DSI to LVDS
> - rest of i.MX8M Mini features
>
> i.Core MX8M Mini needs to mount on top of Engicam baseboards
> for creating complete platform solutions.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
> - add cpu nodes
> - add fec1 node
> - fixed pmic tree comments
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
Thanks for the changes.
>
> .../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++
> 1 file changed, 232 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
> new file mode 100644
> index 000000000000..e67865fd102a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi
> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2018 NXP
> + * Copyright (c) 2019 Engicam srl
> + * Copyright (c) 2020 Amarula Solutons(India)
> + */
> +
> +/ {
> + compatible = "engicam,icore-mx8mm", "fsl,imx8mm";
> +};
> +
> +&A53_0 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_1 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_2 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&A53_3 {
> + cpu-supply = <®_buck4>;
> +};
> +
> +&fec1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_fec1>;
> + phy-mode = "rgmii-id";
> + phy-handle = <ðphy>;
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy@3 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <3>;
> + reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + };
> + };
> +};
> +
> +&i2c1 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + status = "okay";
> +
> + pmic@8 {
> + compatible = "nxp,pf8121a";
> + reg = <0x08>;
> +
> + regulators {
> + reg_ldo1: ldo1 {
> + regulator-max-microvolt = <5000000>;
> + regulator-min-microvolt = <1500000>;
I mentioned previously min/max hoping it will be obvious (as most or
even all of DTS follow this convention... although not example in your
regulator) but let be more specific: first min, then max. Don't reverse
the logic. See also example in the regulator.yaml.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 13:46 ` Krzysztof Kozlowski
@ 2020-12-21 13:59 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 13:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> >
> > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > touch interface support.
> >
> > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> >
> > Add bindings for it.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - updated commit message
> >
> > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 67980dcef66d..e653e0a43016 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -667,6 +667,8 @@ properties:
> > items:
> > - enum:
> > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
>
> Please test your DTS against new schema with dtbs_check. This won't
> match.
Sorry, not sure I understand clearly here.
This the dts file ie used matched compatible.
compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
"fsl,imx8mm";
I did build the dtbs_check without showing any issues like,
$ make ARCH=arm64 dtbs_check
...
From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
..
Can you let me know what I missed here?
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 13:59 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 13:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> >
> > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > touch interface support.
> >
> > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> >
> > Add bindings for it.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - updated commit message
> >
> > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 67980dcef66d..e653e0a43016 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -667,6 +667,8 @@ properties:
> > items:
> > - enum:
> > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
>
> Please test your DTS against new schema with dtbs_check. This won't
> match.
Sorry, not sure I understand clearly here.
This the dts file ie used matched compatible.
compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
"fsl,imx8mm";
I did build the dtbs_check without showing any issues like,
$ make ARCH=arm64 dtbs_check
...
From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
..
Can you let me know what I missed here?
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 14:01 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:01 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Mon, Dec 21, 2020 at 05:01:49PM +0530, Jagan Teki wrote:
> Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier
> board.
>
> Genaral features:
> - Ethernet 10/100
> - Wifi/BT
> - USB Type A/OTG
> - Audio Out
> - CAN
> - LVDS panel connector
>
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> i.Core MX8M Mini needs to mount on top of this Carrier board for
> creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - enabled fec1 node
> - updated commit message
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
> - add i2c nodes
> - fixed v1 comments
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++++++++++++++
> .../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 ++
> .../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++
> 4 files changed, 111 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 6f0777ee6cd6..8d49a2c74604 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> new file mode 100644
> index 000000000000..f7870efd9dab
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> @@ -0,0 +1,82 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +&fec1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +};
> +
> +&i2c4 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c4>;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
> + >;
> + };
> +
> + pinctrl_i2c4: i2c4grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C4_SCL_I2C4_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C4_SDA_I2C4_SDA 0x400001c3
> + >;
> + };
> +
> + pinctrl_uart2: uart2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
> + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
> + >;
> + };
> +
> + pinctrl_usdhc1_gpio: usdhc1gpiogrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x41
> + >;
> + };
> +
> + pinctrl_usdhc1: usdhc1grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190
> + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0
> + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0
> + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0
> + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0
> + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0
> + >;
> + };
> +};
> +
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart2>;
> + status = "okay";
> +};
> +
> +/* SD */
> +&usdhc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> + cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> + max-frequency = <50000000>;
> + bus-width = <4>;
> + no-1-8-v;
> + pm-ignore-notify;
> + keep-power-in-suspend;
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> new file mode 100644
> index 000000000000..294df07289a2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "imx8mm-engicam-common.dtsi"
The same as before - a DTSI file to include a DTSI. Remove it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 14:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:01 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 05:01:49PM +0530, Jagan Teki wrote:
> Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier
> board.
>
> Genaral features:
> - Ethernet 10/100
> - Wifi/BT
> - USB Type A/OTG
> - Audio Out
> - CAN
> - LVDS panel connector
>
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> i.Core MX8M Mini needs to mount on top of this Carrier board for
> creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - enabled fec1 node
> - updated commit message
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
> - add i2c nodes
> - fixed v1 comments
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../dts/freescale/imx8mm-engicam-common.dtsi | 82 +++++++++++++++++++
> .../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 7 ++
> .../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++
> 4 files changed, 111 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 6f0777ee6cd6..8d49a2c74604 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> new file mode 100644
> index 000000000000..f7870efd9dab
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi
> @@ -0,0 +1,82 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +&fec1 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +};
> +
> +&i2c4 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c4>;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x400001c3
> + >;
> + };
> +
> + pinctrl_i2c4: i2c4grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C4_SCL_I2C4_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C4_SDA_I2C4_SDA 0x400001c3
> + >;
> + };
> +
> + pinctrl_uart2: uart2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
> + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140
> + >;
> + };
> +
> + pinctrl_usdhc1_gpio: usdhc1gpiogrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x41
> + >;
> + };
> +
> + pinctrl_usdhc1: usdhc1grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190
> + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0
> + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0
> + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0
> + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0
> + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0
> + >;
> + };
> +};
> +
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart2>;
> + status = "okay";
> +};
> +
> +/* SD */
> +&usdhc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> + cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> + max-frequency = <50000000>;
> + bus-width = <4>;
> + no-1-8-v;
> + pm-ignore-notify;
> + keep-power-in-suspend;
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> new file mode 100644
> index 000000000000..294df07289a2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "imx8mm-engicam-common.dtsi"
The same as before - a DTSI file to include a DTSI. Remove it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 13:59 ` Jagan Teki
@ 2020-12-21 14:05 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:05 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > >
> > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > touch interface support.
> > >
> > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > >
> > > Add bindings for it.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - updated commit message
> > >
> > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 67980dcef66d..e653e0a43016 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -667,6 +667,8 @@ properties:
> > > items:
> > > - enum:
> > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> >
> > Please test your DTS against new schema with dtbs_check. This won't
> > match.
>
> Sorry, not sure I understand clearly here.
>
> This the dts file ie used matched compatible.
> compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> "fsl,imx8mm";
>
> I did build the dtbs_check without showing any issues like,
>
> $ make ARCH=arm64 dtbs_check
> ...
>
> From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> ..
>
> Can you let me know what I missed here?
You pasted here output of validating with property-units.yaml (or
something else), not the schema which you changed. If you want to limit
the tests, use DT_SCHEMA_FILES.
I mentioned about exactly the same problem in yout previous v1
at patch #5. No changes here stil.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 14:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:05 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > >
> > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > touch interface support.
> > >
> > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > >
> > > Add bindings for it.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - updated commit message
> > >
> > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 67980dcef66d..e653e0a43016 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -667,6 +667,8 @@ properties:
> > > items:
> > > - enum:
> > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> >
> > Please test your DTS against new schema with dtbs_check. This won't
> > match.
>
> Sorry, not sure I understand clearly here.
>
> This the dts file ie used matched compatible.
> compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> "fsl,imx8mm";
>
> I did build the dtbs_check without showing any issues like,
>
> $ make ARCH=arm64 dtbs_check
> ...
>
> From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> ..
>
> Can you let me know what I missed here?
You pasted here output of validating with property-units.yaml (or
something else), not the schema which you changed. If you want to limit
the tests, use DT_SCHEMA_FILES.
I mentioned about exactly the same problem in yout previous v1
at patch #5. No changes here stil.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 11:31 ` Jagan Teki
@ 2020-12-21 14:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:06 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> Evaluation Board.
>
> Genaral features:
> - LCD 7" C.Touch
> - microSD slot
> - Ethernet 1Gb
> - Wifi/BT
> - 2x LVDS Full HD interfaces
> - 3x USB 2.0
> - 1x USB 3.0
> - HDMI Out
> - Mini PCIe
> - MIPI CSI
> - 2x CAN
> - Audio Out
>
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> i.Core MX8M Mini needs to mount on top of this Evaluation board for
> creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
>
> PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> Mainline Linux supported.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> 3 files changed, 29 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 8d49a2c74604..43783076f856 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> new file mode 100644
> index 000000000000..294df07289a2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "imx8mm-engicam-common.dtsi"
It seems you ignored my comments from previous email. That's not how we
go with the process.
Don't create confusing or overcomplicated hierarchy of includes. Don't
create files which do nothing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-21 14:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:06 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> Evaluation Board.
>
> Genaral features:
> - LCD 7" C.Touch
> - microSD slot
> - Ethernet 1Gb
> - Wifi/BT
> - 2x LVDS Full HD interfaces
> - 3x USB 2.0
> - 1x USB 3.0
> - HDMI Out
> - Mini PCIe
> - MIPI CSI
> - 2x CAN
> - Audio Out
>
> i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
>
> i.Core MX8M Mini needs to mount on top of this Evaluation board for
> creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
>
> PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> Mainline Linux supported.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - updated commit message
> - dropped engicam from filename since it aligned with imx6 engicam
> dts files naming conventions.
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> 3 files changed, 29 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 8d49a2c74604..43783076f856 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> new file mode 100644
> index 000000000000..294df07289a2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "imx8mm-engicam-common.dtsi"
It seems you ignored my comments from previous email. That's not how we
go with the process.
Don't create confusing or overcomplicated hierarchy of includes. Don't
create files which do nothing.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 14:05 ` Krzysztof Kozlowski
@ 2020-12-21 14:39 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 14:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > >
> > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > touch interface support.
> > > >
> > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > >
> > > > Add bindings for it.
> > > >
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > > Changes for v2:
> > > > - updated commit message
> > > >
> > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > index 67980dcef66d..e653e0a43016 100644
> > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > @@ -667,6 +667,8 @@ properties:
> > > > items:
> > > > - enum:
> > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > >
> > > Please test your DTS against new schema with dtbs_check. This won't
> > > match.
> >
> > Sorry, not sure I understand clearly here.
> >
> > This the dts file ie used matched compatible.
> > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > "fsl,imx8mm";
> >
> > I did build the dtbs_check without showing any issues like,
> >
> > $ make ARCH=arm64 dtbs_check
> > ...
> >
> > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > ..
> >
> > Can you let me know what I missed here?
>
> You pasted here output of validating with property-units.yaml (or
> something else), not the schema which you changed. If you want to limit
> the tests, use DT_SCHEMA_FILES.
>
> I mentioned about exactly the same problem in yout previous v1
> at patch #5. No changes here stil.
Yes, I usually did that check before posting. Please check the build
log below and fsl.yaml binding is fine to build.
# make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTCC scripts/dtc/yamltree.o
HOSTLD scripts/dtc/dtc
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/media/coda.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
'additionalProperties' is a required property
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
/w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/media/coda.yaml
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
#
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 14:39 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 14:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > >
> > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > touch interface support.
> > > >
> > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > >
> > > > Add bindings for it.
> > > >
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > > Changes for v2:
> > > > - updated commit message
> > > >
> > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > index 67980dcef66d..e653e0a43016 100644
> > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > @@ -667,6 +667,8 @@ properties:
> > > > items:
> > > > - enum:
> > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > >
> > > Please test your DTS against new schema with dtbs_check. This won't
> > > match.
> >
> > Sorry, not sure I understand clearly here.
> >
> > This the dts file ie used matched compatible.
> > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > "fsl,imx8mm";
> >
> > I did build the dtbs_check without showing any issues like,
> >
> > $ make ARCH=arm64 dtbs_check
> > ...
> >
> > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > ..
> >
> > Can you let me know what I missed here?
>
> You pasted here output of validating with property-units.yaml (or
> something else), not the schema which you changed. If you want to limit
> the tests, use DT_SCHEMA_FILES.
>
> I mentioned about exactly the same problem in yout previous v1
> at patch #5. No changes here stil.
Yes, I usually did that check before posting. Please check the build
log below and fsl.yaml binding is fine to build.
# make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTCC scripts/dtc/yamltree.o
HOSTLD scripts/dtc/dtc
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/media/coda.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
'additionalProperties' is a required property
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
/w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/media/coda.yaml
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
#
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 14:39 ` Jagan Teki
@ 2020-12-21 14:42 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:42 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > >
> > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > touch interface support.
> > > > >
> > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > >
> > > > > Add bindings for it.
> > > > >
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > > Changes for v2:
> > > > > - updated commit message
> > > > >
> > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > @@ -667,6 +667,8 @@ properties:
> > > > > items:
> > > > > - enum:
> > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > >
> > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > match.
> > >
> > > Sorry, not sure I understand clearly here.
> > >
> > > This the dts file ie used matched compatible.
> > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > "fsl,imx8mm";
> > >
> > > I did build the dtbs_check without showing any issues like,
> > >
> > > $ make ARCH=arm64 dtbs_check
> > > ...
> > >
> > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > ..
> > >
> > > Can you let me know what I missed here?
> >
> > You pasted here output of validating with property-units.yaml (or
> > something else), not the schema which you changed. If you want to limit
> > the tests, use DT_SCHEMA_FILES.
> >
> > I mentioned about exactly the same problem in yout previous v1
> > at patch #5. No changes here stil.
>
> Yes, I usually did that check before posting. Please check the build
> log below and fsl.yaml binding is fine to build.
>
> # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
1. Wrong path to schema file,
2. Bindings pass, they are not a problem. You were running dtbs_check,
right?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 14:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 14:42 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > >
> > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > touch interface support.
> > > > >
> > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > >
> > > > > Add bindings for it.
> > > > >
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > > Changes for v2:
> > > > > - updated commit message
> > > > >
> > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > @@ -667,6 +667,8 @@ properties:
> > > > > items:
> > > > > - enum:
> > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > >
> > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > match.
> > >
> > > Sorry, not sure I understand clearly here.
> > >
> > > This the dts file ie used matched compatible.
> > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > "fsl,imx8mm";
> > >
> > > I did build the dtbs_check without showing any issues like,
> > >
> > > $ make ARCH=arm64 dtbs_check
> > > ...
> > >
> > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > ..
> > >
> > > Can you let me know what I missed here?
> >
> > You pasted here output of validating with property-units.yaml (or
> > something else), not the schema which you changed. If you want to limit
> > the tests, use DT_SCHEMA_FILES.
> >
> > I mentioned about exactly the same problem in yout previous v1
> > at patch #5. No changes here stil.
>
> Yes, I usually did that check before posting. Please check the build
> log below and fsl.yaml binding is fine to build.
>
> # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
1. Wrong path to schema file,
2. Bindings pass, they are not a problem. You were running dtbs_check,
right?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 14:42 ` Krzysztof Kozlowski
@ 2020-12-21 14:47 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 14:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > >
> > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > touch interface support.
> > > > > >
> > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > >
> > > > > > Add bindings for it.
> > > > > >
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > Changes for v2:
> > > > > > - updated commit message
> > > > > >
> > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > 1 file changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > items:
> > > > > > - enum:
> > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > >
> > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > match.
> > > >
> > > > Sorry, not sure I understand clearly here.
> > > >
> > > > This the dts file ie used matched compatible.
> > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > "fsl,imx8mm";
> > > >
> > > > I did build the dtbs_check without showing any issues like,
> > > >
> > > > $ make ARCH=arm64 dtbs_check
> > > > ...
> > > >
> > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > ..
> > > >
> > > > Can you let me know what I missed here?
> > >
> > > You pasted here output of validating with property-units.yaml (or
> > > something else), not the schema which you changed. If you want to limit
> > > the tests, use DT_SCHEMA_FILES.
> > >
> > > I mentioned about exactly the same problem in yout previous v1
> > > at patch #5. No changes here stil.
> >
> > Yes, I usually did that check before posting. Please check the build
> > log below and fsl.yaml binding is fine to build.
> >
> > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
>
> 1. Wrong path to schema file,
> 2. Bindings pass, they are not a problem. You were running dtbs_check,
> right?
But kbuild is building the fsl.yaml I did verify with by adding some
wrong character in the file, it is showing build issues.
Please check the clean log.
# make mrproper
CLEAN Documentation/devicetree/bindings
CLEAN scripts/basic
CLEAN scripts/dtc
# make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTCC scripts/dtc/yamltree.o
HOSTLD scripts/dtc/dtc
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/media/coda.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
'additionalProperties' is a required property
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
/w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/media/coda.yaml
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-21 14:47 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 14:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > >
> > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > touch interface support.
> > > > > >
> > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > >
> > > > > > Add bindings for it.
> > > > > >
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > Changes for v2:
> > > > > > - updated commit message
> > > > > >
> > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > 1 file changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > items:
> > > > > > - enum:
> > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > >
> > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > match.
> > > >
> > > > Sorry, not sure I understand clearly here.
> > > >
> > > > This the dts file ie used matched compatible.
> > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > "fsl,imx8mm";
> > > >
> > > > I did build the dtbs_check without showing any issues like,
> > > >
> > > > $ make ARCH=arm64 dtbs_check
> > > > ...
> > > >
> > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > ..
> > > >
> > > > Can you let me know what I missed here?
> > >
> > > You pasted here output of validating with property-units.yaml (or
> > > something else), not the schema which you changed. If you want to limit
> > > the tests, use DT_SCHEMA_FILES.
> > >
> > > I mentioned about exactly the same problem in yout previous v1
> > > at patch #5. No changes here stil.
> >
> > Yes, I usually did that check before posting. Please check the build
> > log below and fsl.yaml binding is fine to build.
> >
> > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
>
> 1. Wrong path to schema file,
> 2. Bindings pass, they are not a problem. You were running dtbs_check,
> right?
But kbuild is building the fsl.yaml I did verify with by adding some
wrong character in the file, it is showing build issues.
Please check the clean log.
# make mrproper
CLEAN Documentation/devicetree/bindings
CLEAN scripts/basic
CLEAN scripts/dtc
# make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTCC scripts/dtc/yamltree.o
HOSTLD scripts/dtc/dtc
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/media/coda.yaml:
'additionalProperties' is a required property
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
'additionalProperties' is a required property
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
/w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
/w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
/w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/media/coda.yaml
/w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 14:06 ` Krzysztof Kozlowski
@ 2020-12-21 19:33 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 19:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > Evaluation Board.
> >
> > Genaral features:
> > - LCD 7" C.Touch
> > - microSD slot
> > - Ethernet 1Gb
> > - Wifi/BT
> > - 2x LVDS Full HD interfaces
> > - 3x USB 2.0
> > - 1x USB 3.0
> > - HDMI Out
> > - Mini PCIe
> > - MIPI CSI
> > - 2x CAN
> > - Audio Out
> >
> > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> >
> > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> >
> > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > Mainline Linux supported.
> >
> > Add support for it.
> >
> > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - updated commit message
> > - dropped engicam from filename since it aligned with imx6 engicam
> > dts files naming conventions.
> >
> > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > 3 files changed, 29 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 8d49a2c74604..43783076f856 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > new file mode 100644
> > index 000000000000..294df07289a2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > @@ -0,0 +1,7 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2020 Engicam srl
> > + * Copyright (c) 2020 Amarula Solutions(India)
> > + */
> > +
> > +#include "imx8mm-engicam-common.dtsi"
>
> It seems you ignored my comments from previous email. That's not how we
> go with the process.
>
> Don't create confusing or overcomplicated hierarchy of includes. Don't
> create files which do nothing.
Idea is to move common nodes in separate dtsi instead of adding
redundant nodes into respective areas. let me know if it still
confusing.
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-21 19:33 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-21 19:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > Evaluation Board.
> >
> > Genaral features:
> > - LCD 7" C.Touch
> > - microSD slot
> > - Ethernet 1Gb
> > - Wifi/BT
> > - 2x LVDS Full HD interfaces
> > - 3x USB 2.0
> > - 1x USB 3.0
> > - HDMI Out
> > - Mini PCIe
> > - MIPI CSI
> > - 2x CAN
> > - Audio Out
> >
> > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> >
> > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> >
> > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > Mainline Linux supported.
> >
> > Add support for it.
> >
> > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - updated commit message
> > - dropped engicam from filename since it aligned with imx6 engicam
> > dts files naming conventions.
> >
> > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > 3 files changed, 29 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 8d49a2c74604..43783076f856 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > new file mode 100644
> > index 000000000000..294df07289a2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > @@ -0,0 +1,7 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2020 Engicam srl
> > + * Copyright (c) 2020 Amarula Solutions(India)
> > + */
> > +
> > +#include "imx8mm-engicam-common.dtsi"
>
> It seems you ignored my comments from previous email. That's not how we
> go with the process.
>
> Don't create confusing or overcomplicated hierarchy of includes. Don't
> create files which do nothing.
Idea is to move common nodes in separate dtsi instead of adding
redundant nodes into respective areas. let me know if it still
confusing.
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 19:33 ` Jagan Teki
@ 2020-12-21 21:06 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 21:06 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > Evaluation Board.
> > >
> > > Genaral features:
> > > - LCD 7" C.Touch
> > > - microSD slot
> > > - Ethernet 1Gb
> > > - Wifi/BT
> > > - 2x LVDS Full HD interfaces
> > > - 3x USB 2.0
> > > - 1x USB 3.0
> > > - HDMI Out
> > > - Mini PCIe
> > > - MIPI CSI
> > > - 2x CAN
> > > - Audio Out
> > >
> > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > >
> > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > >
> > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > Mainline Linux supported.
> > >
> > > Add support for it.
> > >
> > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - updated commit message
> > > - dropped engicam from filename since it aligned with imx6 engicam
> > > dts files naming conventions.
> > >
> > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > 3 files changed, 29 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > index 8d49a2c74604..43783076f856 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > new file mode 100644
> > > index 000000000000..294df07289a2
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > @@ -0,0 +1,7 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (c) 2020 Engicam srl
> > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > + */
> > > +
> > > +#include "imx8mm-engicam-common.dtsi"
> >
> > It seems you ignored my comments from previous email. That's not how we
> > go with the process.
> >
> > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > create files which do nothing.
>
> Idea is to move common nodes in separate dtsi instead of adding
> redundant nodes into respective areas. let me know if it still
> confusing.
A file which *only* includes another file does not fulfill this idea of
moving common nodes to a separate DTSI file. Or if I still miss
something, please point me, what common nodes are stored in
imx8mm-engicam-edimm2.2.dtsi?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-21 21:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-21 21:06 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > Evaluation Board.
> > >
> > > Genaral features:
> > > - LCD 7" C.Touch
> > > - microSD slot
> > > - Ethernet 1Gb
> > > - Wifi/BT
> > > - 2x LVDS Full HD interfaces
> > > - 3x USB 2.0
> > > - 1x USB 3.0
> > > - HDMI Out
> > > - Mini PCIe
> > > - MIPI CSI
> > > - 2x CAN
> > > - Audio Out
> > >
> > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > >
> > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > >
> > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > Mainline Linux supported.
> > >
> > > Add support for it.
> > >
> > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - updated commit message
> > > - dropped engicam from filename since it aligned with imx6 engicam
> > > dts files naming conventions.
> > >
> > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > 3 files changed, 29 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > index 8d49a2c74604..43783076f856 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > new file mode 100644
> > > index 000000000000..294df07289a2
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > @@ -0,0 +1,7 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (c) 2020 Engicam srl
> > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > + */
> > > +
> > > +#include "imx8mm-engicam-common.dtsi"
> >
> > It seems you ignored my comments from previous email. That's not how we
> > go with the process.
> >
> > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > create files which do nothing.
>
> Idea is to move common nodes in separate dtsi instead of adding
> redundant nodes into respective areas. let me know if it still
> confusing.
A file which *only* includes another file does not fulfill this idea of
moving common nodes to a separate DTSI file. Or if I still miss
something, please point me, what common nodes are stored in
imx8mm-engicam-edimm2.2.dtsi?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-21 21:06 ` Krzysztof Kozlowski
@ 2020-12-22 8:50 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 8:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > Evaluation Board.
> > > >
> > > > Genaral features:
> > > > - LCD 7" C.Touch
> > > > - microSD slot
> > > > - Ethernet 1Gb
> > > > - Wifi/BT
> > > > - 2x LVDS Full HD interfaces
> > > > - 3x USB 2.0
> > > > - 1x USB 3.0
> > > > - HDMI Out
> > > > - Mini PCIe
> > > > - MIPI CSI
> > > > - 2x CAN
> > > > - Audio Out
> > > >
> > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > >
> > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > >
> > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > Mainline Linux supported.
> > > >
> > > > Add support for it.
> > > >
> > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > > Changes for v2:
> > > > - updated commit message
> > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > dts files naming conventions.
> > > >
> > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > 3 files changed, 29 insertions(+)
> > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > index 8d49a2c74604..43783076f856 100644
> > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > new file mode 100644
> > > > index 000000000000..294df07289a2
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > @@ -0,0 +1,7 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright (c) 2020 Engicam srl
> > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > + */
> > > > +
> > > > +#include "imx8mm-engicam-common.dtsi"
> > >
> > > It seems you ignored my comments from previous email. That's not how we
> > > go with the process.
> > >
> > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > create files which do nothing.
> >
> > Idea is to move common nodes in separate dtsi instead of adding
> > redundant nodes into respective areas. let me know if it still
> > confusing.
>
> A file which *only* includes another file does not fulfill this idea of
> moving common nodes to a separate DTSI file. Or if I still miss
> something, please point me, what common nodes are stored in
> imx8mm-engicam-edimm2.2.dtsi?
imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
Yes, imx8mm-engicam-edimm2.2.dtsi is empty now but nodes like PCIe,
CSI, DSI will support once the respective drivers are part of Mainline
but those are not supported in C.TOUCH2 carrier board dtsi. There are
some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
WiFi/BT so those will be part of the respective carrier dtsi.
Hope this would clear.
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-22 8:50 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 8:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > Evaluation Board.
> > > >
> > > > Genaral features:
> > > > - LCD 7" C.Touch
> > > > - microSD slot
> > > > - Ethernet 1Gb
> > > > - Wifi/BT
> > > > - 2x LVDS Full HD interfaces
> > > > - 3x USB 2.0
> > > > - 1x USB 3.0
> > > > - HDMI Out
> > > > - Mini PCIe
> > > > - MIPI CSI
> > > > - 2x CAN
> > > > - Audio Out
> > > >
> > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > >
> > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > >
> > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > Mainline Linux supported.
> > > >
> > > > Add support for it.
> > > >
> > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > > Changes for v2:
> > > > - updated commit message
> > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > dts files naming conventions.
> > > >
> > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > 3 files changed, 29 insertions(+)
> > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > index 8d49a2c74604..43783076f856 100644
> > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > new file mode 100644
> > > > index 000000000000..294df07289a2
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > @@ -0,0 +1,7 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright (c) 2020 Engicam srl
> > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > + */
> > > > +
> > > > +#include "imx8mm-engicam-common.dtsi"
> > >
> > > It seems you ignored my comments from previous email. That's not how we
> > > go with the process.
> > >
> > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > create files which do nothing.
> >
> > Idea is to move common nodes in separate dtsi instead of adding
> > redundant nodes into respective areas. let me know if it still
> > confusing.
>
> A file which *only* includes another file does not fulfill this idea of
> moving common nodes to a separate DTSI file. Or if I still miss
> something, please point me, what common nodes are stored in
> imx8mm-engicam-edimm2.2.dtsi?
imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
Yes, imx8mm-engicam-edimm2.2.dtsi is empty now but nodes like PCIe,
CSI, DSI will support once the respective drivers are part of Mainline
but those are not supported in C.TOUCH2 carrier board dtsi. There are
some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
WiFi/BT so those will be part of the respective carrier dtsi.
Hope this would clear.
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-22 8:50 ` Jagan Teki
@ 2020-12-22 8:53 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 8:53 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote:
> On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > > Evaluation Board.
> > > > >
> > > > > Genaral features:
> > > > > - LCD 7" C.Touch
> > > > > - microSD slot
> > > > > - Ethernet 1Gb
> > > > > - Wifi/BT
> > > > > - 2x LVDS Full HD interfaces
> > > > > - 3x USB 2.0
> > > > > - 1x USB 3.0
> > > > > - HDMI Out
> > > > > - Mini PCIe
> > > > > - MIPI CSI
> > > > > - 2x CAN
> > > > > - Audio Out
> > > > >
> > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > >
> > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > > >
> > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > > Mainline Linux supported.
> > > > >
> > > > > Add support for it.
> > > > >
> > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > > Changes for v2:
> > > > > - updated commit message
> > > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > > dts files naming conventions.
> > > > >
> > > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > > 3 files changed, 29 insertions(+)
> > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > > index 8d49a2c74604..43783076f856 100644
> > > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > new file mode 100644
> > > > > index 000000000000..294df07289a2
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > @@ -0,0 +1,7 @@
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > +/*
> > > > > + * Copyright (c) 2020 Engicam srl
> > > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > > + */
> > > > > +
> > > > > +#include "imx8mm-engicam-common.dtsi"
> > > >
> > > > It seems you ignored my comments from previous email. That's not how we
> > > > go with the process.
> > > >
> > > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > > create files which do nothing.
> > >
> > > Idea is to move common nodes in separate dtsi instead of adding
> > > redundant nodes into respective areas. let me know if it still
> > > confusing.
> >
> > A file which *only* includes another file does not fulfill this idea of
> > moving common nodes to a separate DTSI file. Or if I still miss
> > something, please point me, what common nodes are stored in
> > imx8mm-engicam-edimm2.2.dtsi?
>
> imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
> imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
> imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
>
> Yes, imx8mm-engicam-edimm2.2.dtsi is empty now
Then that's the answer. We do not create empty files.
> but nodes like PCIe,
> CSI, DSI will support once the respective drivers are part of Mainline
> but those are not supported in C.TOUCH2 carrier board dtsi. There are
> some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
> WiFi/BT so those will be part of the respective carrier dtsi.
It's the same clear as before. Don't create empty files. Once you decide
to bring new features, you create a new file.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-22 8:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 8:53 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote:
> On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > > Evaluation Board.
> > > > >
> > > > > Genaral features:
> > > > > - LCD 7" C.Touch
> > > > > - microSD slot
> > > > > - Ethernet 1Gb
> > > > > - Wifi/BT
> > > > > - 2x LVDS Full HD interfaces
> > > > > - 3x USB 2.0
> > > > > - 1x USB 3.0
> > > > > - HDMI Out
> > > > > - Mini PCIe
> > > > > - MIPI CSI
> > > > > - 2x CAN
> > > > > - Audio Out
> > > > >
> > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > >
> > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > > >
> > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > > Mainline Linux supported.
> > > > >
> > > > > Add support for it.
> > > > >
> > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > > Changes for v2:
> > > > > - updated commit message
> > > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > > dts files naming conventions.
> > > > >
> > > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > > 3 files changed, 29 insertions(+)
> > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > > index 8d49a2c74604..43783076f856 100644
> > > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > new file mode 100644
> > > > > index 000000000000..294df07289a2
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > @@ -0,0 +1,7 @@
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > +/*
> > > > > + * Copyright (c) 2020 Engicam srl
> > > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > > + */
> > > > > +
> > > > > +#include "imx8mm-engicam-common.dtsi"
> > > >
> > > > It seems you ignored my comments from previous email. That's not how we
> > > > go with the process.
> > > >
> > > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > > create files which do nothing.
> > >
> > > Idea is to move common nodes in separate dtsi instead of adding
> > > redundant nodes into respective areas. let me know if it still
> > > confusing.
> >
> > A file which *only* includes another file does not fulfill this idea of
> > moving common nodes to a separate DTSI file. Or if I still miss
> > something, please point me, what common nodes are stored in
> > imx8mm-engicam-edimm2.2.dtsi?
>
> imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
> imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
> imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
>
> Yes, imx8mm-engicam-edimm2.2.dtsi is empty now
Then that's the answer. We do not create empty files.
> but nodes like PCIe,
> CSI, DSI will support once the respective drivers are part of Mainline
> but those are not supported in C.TOUCH2 carrier board dtsi. There are
> some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
> WiFi/BT so those will be part of the respective carrier dtsi.
It's the same clear as before. Don't create empty files. Once you decide
to bring new features, you create a new file.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
2020-12-22 8:53 ` Krzysztof Kozlowski
@ 2020-12-22 9:05 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 9:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon, Matteo Lisi
On Tue, Dec 22, 2020 at 2:23 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote:
> > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > > > Evaluation Board.
> > > > > >
> > > > > > Genaral features:
> > > > > > - LCD 7" C.Touch
> > > > > > - microSD slot
> > > > > > - Ethernet 1Gb
> > > > > > - Wifi/BT
> > > > > > - 2x LVDS Full HD interfaces
> > > > > > - 3x USB 2.0
> > > > > > - 1x USB 3.0
> > > > > > - HDMI Out
> > > > > > - Mini PCIe
> > > > > > - MIPI CSI
> > > > > > - 2x CAN
> > > > > > - Audio Out
> > > > > >
> > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > >
> > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > > > >
> > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > > > Mainline Linux supported.
> > > > > >
> > > > > > Add support for it.
> > > > > >
> > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > Changes for v2:
> > > > > > - updated commit message
> > > > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > > > dts files naming conventions.
> > > > > >
> > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > > > 3 files changed, 29 insertions(+)
> > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > > > index 8d49a2c74604..43783076f856 100644
> > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > new file mode 100644
> > > > > > index 000000000000..294df07289a2
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > @@ -0,0 +1,7 @@
> > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > > +/*
> > > > > > + * Copyright (c) 2020 Engicam srl
> > > > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > > > + */
> > > > > > +
> > > > > > +#include "imx8mm-engicam-common.dtsi"
> > > > >
> > > > > It seems you ignored my comments from previous email. That's not how we
> > > > > go with the process.
> > > > >
> > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > > > create files which do nothing.
> > > >
> > > > Idea is to move common nodes in separate dtsi instead of adding
> > > > redundant nodes into respective areas. let me know if it still
> > > > confusing.
> > >
> > > A file which *only* includes another file does not fulfill this idea of
> > > moving common nodes to a separate DTSI file. Or if I still miss
> > > something, please point me, what common nodes are stored in
> > > imx8mm-engicam-edimm2.2.dtsi?
> >
> > imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
> > imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
> > imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
> >
> > Yes, imx8mm-engicam-edimm2.2.dtsi is empty now
>
> Then that's the answer. We do not create empty files.
>
> > but nodes like PCIe,
> > CSI, DSI will support once the respective drivers are part of Mainline
> > but those are not supported in C.TOUCH2 carrier board dtsi. There are
> > some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
> > WiFi/BT so those will be part of the respective carrier dtsi.
>
> It's the same clear as before. Don't create empty files. Once you decide
> to bring new features, you create a new file.
Okay, then will add w/o common file in next version.
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
@ 2020-12-22 9:05 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 9:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Matteo Lisi, Will Deacon, Shawn Guo, linux-kernel,
Li Yang, Rob Herring, NXP Linux Team, Catalin Marinas,
Fabio Estevam, linux-amarula, linux-arm-kernel
On Tue, Dec 22, 2020 at 2:23 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote:
> > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote:
> > > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> > > > > > Evaluation Board.
> > > > > >
> > > > > > Genaral features:
> > > > > > - LCD 7" C.Touch
> > > > > > - microSD slot
> > > > > > - Ethernet 1Gb
> > > > > > - Wifi/BT
> > > > > > - 2x LVDS Full HD interfaces
> > > > > > - 3x USB 2.0
> > > > > > - 1x USB 3.0
> > > > > > - HDMI Out
> > > > > > - Mini PCIe
> > > > > > - MIPI CSI
> > > > > > - 2x CAN
> > > > > > - Audio Out
> > > > > >
> > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > >
> > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for
> > > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
> > > > > >
> > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once
> > > > > > Mainline Linux supported.
> > > > > >
> > > > > > Add support for it.
> > > > > >
> > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > Changes for v2:
> > > > > > - updated commit message
> > > > > > - dropped engicam from filename since it aligned with imx6 engicam
> > > > > > dts files naming conventions.
> > > > > >
> > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++
> > > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> > > > > > 3 files changed, 29 insertions(+)
> > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > > > > index 8d49a2c74604..43783076f856 100644
> > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > new file mode 100644
> > > > > > index 000000000000..294df07289a2
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi
> > > > > > @@ -0,0 +1,7 @@
> > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > > +/*
> > > > > > + * Copyright (c) 2020 Engicam srl
> > > > > > + * Copyright (c) 2020 Amarula Solutions(India)
> > > > > > + */
> > > > > > +
> > > > > > +#include "imx8mm-engicam-common.dtsi"
> > > > >
> > > > > It seems you ignored my comments from previous email. That's not how we
> > > > > go with the process.
> > > > >
> > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't
> > > > > create files which do nothing.
> > > >
> > > > Idea is to move common nodes in separate dtsi instead of adding
> > > > redundant nodes into respective areas. let me know if it still
> > > > confusing.
> > >
> > > A file which *only* includes another file does not fulfill this idea of
> > > moving common nodes to a separate DTSI file. Or if I still miss
> > > something, please point me, what common nodes are stored in
> > > imx8mm-engicam-edimm2.2.dtsi?
> >
> > imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier
> > imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier
> > imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards.
> >
> > Yes, imx8mm-engicam-edimm2.2.dtsi is empty now
>
> Then that's the answer. We do not create empty files.
>
> > but nodes like PCIe,
> > CSI, DSI will support once the respective drivers are part of Mainline
> > but those are not supported in C.TOUCH2 carrier board dtsi. There are
> > some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on
> > WiFi/BT so those will be part of the respective carrier dtsi.
>
> It's the same clear as before. Don't create empty files. Once you decide
> to bring new features, you create a new file.
Okay, then will add w/o common file in next version.
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-21 14:47 ` Jagan Teki
@ 2020-12-22 18:28 ` Jagan Teki
-1 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > >
> > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > touch interface support.
> > > > > > >
> > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > >
> > > > > > > Add bindings for it.
> > > > > > >
> > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > ---
> > > > > > > Changes for v2:
> > > > > > > - updated commit message
> > > > > > >
> > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > 1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > items:
> > > > > > > - enum:
> > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > >
> > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > match.
> > > > >
> > > > > Sorry, not sure I understand clearly here.
> > > > >
> > > > > This the dts file ie used matched compatible.
> > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > "fsl,imx8mm";
> > > > >
> > > > > I did build the dtbs_check without showing any issues like,
> > > > >
> > > > > $ make ARCH=arm64 dtbs_check
> > > > > ...
> > > > >
> > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > ..
> > > > >
> > > > > Can you let me know what I missed here?
> > > >
> > > > You pasted here output of validating with property-units.yaml (or
> > > > something else), not the schema which you changed. If you want to limit
> > > > the tests, use DT_SCHEMA_FILES.
> > > >
> > > > I mentioned about exactly the same problem in yout previous v1
> > > > at patch #5. No changes here stil.
> > >
> > > Yes, I usually did that check before posting. Please check the build
> > > log below and fsl.yaml binding is fine to build.
> > >
> > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> >
> > 1. Wrong path to schema file,
> > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > right?
>
> But kbuild is building the fsl.yaml I did verify with by adding some
> wrong character in the file, it is showing build issues.
>
> Please check the clean log.
>
> # make mrproper
> CLEAN Documentation/devicetree/bindings
> CLEAN scripts/basic
> CLEAN scripts/dtc
> # make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/dtc/dtc.o
> HOSTCC scripts/dtc/flattree.o
> HOSTCC scripts/dtc/fstree.o
> HOSTCC scripts/dtc/data.o
> HOSTCC scripts/dtc/livetree.o
> HOSTCC scripts/dtc/treesource.o
> HOSTCC scripts/dtc/srcpos.o
> HOSTCC scripts/dtc/checks.o
> HOSTCC scripts/dtc/util.o
> LEX scripts/dtc/dtc-lexer.lex.c
> YACC scripts/dtc/dtc-parser.tab.[ch]
> HOSTCC scripts/dtc/dtc-lexer.lex.o
> HOSTCC scripts/dtc/dtc-parser.tab.o
> HOSTCC scripts/dtc/yamltree.o
> HOSTLD scripts/dtc/dtc
> CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> 'additionalProperties' is a required property
> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/coda.yaml
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
Any further comments? I'm planning to send v3.
Jagan.
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-22 18:28 ` Jagan Teki
0 siblings, 0 replies; 50+ messages in thread
From: Jagan Teki @ 2020-12-22 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > >
> > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > touch interface support.
> > > > > > >
> > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > >
> > > > > > > Add bindings for it.
> > > > > > >
> > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > ---
> > > > > > > Changes for v2:
> > > > > > > - updated commit message
> > > > > > >
> > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > 1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > items:
> > > > > > > - enum:
> > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > >
> > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > match.
> > > > >
> > > > > Sorry, not sure I understand clearly here.
> > > > >
> > > > > This the dts file ie used matched compatible.
> > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > "fsl,imx8mm";
> > > > >
> > > > > I did build the dtbs_check without showing any issues like,
> > > > >
> > > > > $ make ARCH=arm64 dtbs_check
> > > > > ...
> > > > >
> > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > ..
> > > > >
> > > > > Can you let me know what I missed here?
> > > >
> > > > You pasted here output of validating with property-units.yaml (or
> > > > something else), not the schema which you changed. If you want to limit
> > > > the tests, use DT_SCHEMA_FILES.
> > > >
> > > > I mentioned about exactly the same problem in yout previous v1
> > > > at patch #5. No changes here stil.
> > >
> > > Yes, I usually did that check before posting. Please check the build
> > > log below and fsl.yaml binding is fine to build.
> > >
> > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> >
> > 1. Wrong path to schema file,
> > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > right?
>
> But kbuild is building the fsl.yaml I did verify with by adding some
> wrong character in the file, it is showing build issues.
>
> Please check the clean log.
>
> # make mrproper
> CLEAN Documentation/devicetree/bindings
> CLEAN scripts/basic
> CLEAN scripts/dtc
> # make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/dtc/dtc.o
> HOSTCC scripts/dtc/flattree.o
> HOSTCC scripts/dtc/fstree.o
> HOSTCC scripts/dtc/data.o
> HOSTCC scripts/dtc/livetree.o
> HOSTCC scripts/dtc/treesource.o
> HOSTCC scripts/dtc/srcpos.o
> HOSTCC scripts/dtc/checks.o
> HOSTCC scripts/dtc/util.o
> LEX scripts/dtc/dtc-lexer.lex.c
> YACC scripts/dtc/dtc-parser.tab.[ch]
> HOSTCC scripts/dtc/dtc-lexer.lex.o
> HOSTCC scripts/dtc/dtc-parser.tab.o
> HOSTCC scripts/dtc/yamltree.o
> HOSTLD scripts/dtc/dtc
> CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> 'additionalProperties' is a required property
> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/coda.yaml
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
Any further comments? I'm planning to send v3.
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-22 18:28 ` Jagan Teki
@ 2020-12-22 20:25 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 20:25 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Tue, 22 Dec 2020 at 19:28, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > > >
> > > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > > >
> > > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > > touch interface support.
> > > > > > > >
> > > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > > >
> > > > > > > > Add bindings for it.
> > > > > > > >
> > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > > ---
> > > > > > > > Changes for v2:
> > > > > > > > - updated commit message
> > > > > > > >
> > > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > >
> > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > > items:
> > > > > > > > - enum:
> > > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > > >
> > > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > > match.
> > > > > >
> > > > > > Sorry, not sure I understand clearly here.
> > > > > >
> > > > > > This the dts file ie used matched compatible.
> > > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > > "fsl,imx8mm";
> > > > > >
> > > > > > I did build the dtbs_check without showing any issues like,
> > > > > >
> > > > > > $ make ARCH=arm64 dtbs_check
> > > > > > ...
> > > > > >
> > > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > ..
> > > > > >
> > > > > > Can you let me know what I missed here?
> > > > >
> > > > > You pasted here output of validating with property-units.yaml (or
> > > > > something else), not the schema which you changed. If you want to limit
> > > > > the tests, use DT_SCHEMA_FILES.
> > > > >
> > > > > I mentioned about exactly the same problem in yout previous v1
> > > > > at patch #5. No changes here stil.
> > > >
> > > > Yes, I usually did that check before posting. Please check the build
> > > > log below and fsl.yaml binding is fine to build.
> > > >
> > > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> > >
> > > 1. Wrong path to schema file,
> > > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > > right?
> >
> > But kbuild is building the fsl.yaml I did verify with by adding some
> > wrong character in the file, it is showing build issues.
> >
> > Please check the clean log.
> >
> > # make mrproper
> > CLEAN Documentation/devicetree/bindings
> > CLEAN scripts/basic
> > CLEAN scripts/dtc
> > # make dt_binding_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> > HOSTCC scripts/basic/fixdep
> > HOSTCC scripts/dtc/dtc.o
> > HOSTCC scripts/dtc/flattree.o
> > HOSTCC scripts/dtc/fstree.o
> > HOSTCC scripts/dtc/data.o
> > HOSTCC scripts/dtc/livetree.o
> > HOSTCC scripts/dtc/treesource.o
> > HOSTCC scripts/dtc/srcpos.o
> > HOSTCC scripts/dtc/checks.o
> > HOSTCC scripts/dtc/util.o
> > LEX scripts/dtc/dtc-lexer.lex.c
> > YACC scripts/dtc/dtc-parser.tab.[ch]
> > HOSTCC scripts/dtc/dtc-lexer.lex.o
> > HOSTCC scripts/dtc/dtc-parser.tab.o
> > HOSTCC scripts/dtc/yamltree.o
> > HOSTLD scripts/dtc/dtc
> > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > 'additionalProperties' is a required property
> > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> > /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> > error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/media/coda.yaml
> > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> > DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> > DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
>
> Any further comments? I'm planning to send v3.
What comments do you need? Your schema and DTS are wrong. If you run
dtbs_check, which I mentioned in the first email, you would see the
result. Instead you pasted unrelevant check of other bindings and
later pasted dt_binding_check. It does not make sense, so I clarified:
> 2. Bindings pass, they are not a problem. You were running dtbs_check, right?
And you pasted dt_binding_check, so it kind of closes the discussion.
I don't know what to add more.
I reported this problem already in v1, so please don't send the same
wrong code for the third time.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-22 20:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 20:25 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Tue, 22 Dec 2020 at 19:28, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > >
> > > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > > >
> > > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > > >
> > > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > > touch interface support.
> > > > > > > >
> > > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > > >
> > > > > > > > Add bindings for it.
> > > > > > > >
> > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > > ---
> > > > > > > > Changes for v2:
> > > > > > > > - updated commit message
> > > > > > > >
> > > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > >
> > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > > items:
> > > > > > > > - enum:
> > > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > > >
> > > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > > match.
> > > > > >
> > > > > > Sorry, not sure I understand clearly here.
> > > > > >
> > > > > > This the dts file ie used matched compatible.
> > > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > > "fsl,imx8mm";
> > > > > >
> > > > > > I did build the dtbs_check without showing any issues like,
> > > > > >
> > > > > > $ make ARCH=arm64 dtbs_check
> > > > > > ...
> > > > > >
> > > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > ..
> > > > > >
> > > > > > Can you let me know what I missed here?
> > > > >
> > > > > You pasted here output of validating with property-units.yaml (or
> > > > > something else), not the schema which you changed. If you want to limit
> > > > > the tests, use DT_SCHEMA_FILES.
> > > > >
> > > > > I mentioned about exactly the same problem in yout previous v1
> > > > > at patch #5. No changes here stil.
> > > >
> > > > Yes, I usually did that check before posting. Please check the build
> > > > log below and fsl.yaml binding is fine to build.
> > > >
> > > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> > >
> > > 1. Wrong path to schema file,
> > > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > > right?
> >
> > But kbuild is building the fsl.yaml I did verify with by adding some
> > wrong character in the file, it is showing build issues.
> >
> > Please check the clean log.
> >
> > # make mrproper
> > CLEAN Documentation/devicetree/bindings
> > CLEAN scripts/basic
> > CLEAN scripts/dtc
> > # make dt_binding_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> > HOSTCC scripts/basic/fixdep
> > HOSTCC scripts/dtc/dtc.o
> > HOSTCC scripts/dtc/flattree.o
> > HOSTCC scripts/dtc/fstree.o
> > HOSTCC scripts/dtc/data.o
> > HOSTCC scripts/dtc/livetree.o
> > HOSTCC scripts/dtc/treesource.o
> > HOSTCC scripts/dtc/srcpos.o
> > HOSTCC scripts/dtc/checks.o
> > HOSTCC scripts/dtc/util.o
> > LEX scripts/dtc/dtc-lexer.lex.c
> > YACC scripts/dtc/dtc-parser.tab.[ch]
> > HOSTCC scripts/dtc/dtc-lexer.lex.o
> > HOSTCC scripts/dtc/dtc-parser.tab.o
> > HOSTCC scripts/dtc/yamltree.o
> > HOSTLD scripts/dtc/dtc
> > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> > 'additionalProperties' is a required property
> > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > 'additionalProperties' is a required property
> > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> > /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> > error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/media/coda.yaml
> > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > ignoring, error in schema:
> > warning: no schema found in file:
> > ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> > DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> > DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
>
> Any further comments? I'm planning to send v3.
What comments do you need? Your schema and DTS are wrong. If you run
dtbs_check, which I mentioned in the first email, you would see the
result. Instead you pasted unrelevant check of other bindings and
later pasted dt_binding_check. It does not make sense, so I clarified:
> 2. Bindings pass, they are not a problem. You were running dtbs_check, right?
And you pasted dt_binding_check, so it kind of closes the discussion.
I don't know what to add more.
I reported this problem already in v1, so please don't send the same
wrong code for the third time.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
2020-12-22 20:25 ` Krzysztof Kozlowski
@ 2020-12-22 20:32 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 20:32 UTC (permalink / raw)
To: Jagan Teki
Cc: Rob Herring, Shawn Guo, Li Yang, Fabio Estevam, devicetree,
linux-kernel, linux-arm-kernel, NXP Linux Team, linux-amarula,
Catalin Marinas, Will Deacon
On Tue, Dec 22, 2020 at 09:25:40PM +0100, Krzysztof Kozlowski wrote:
> On Tue, 22 Dec 2020 at 19:28, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > > > >
> > > > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > > > >
> > > > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > > > touch interface support.
> > > > > > > > >
> > > > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > > > >
> > > > > > > > > Add bindings for it.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > > > ---
> > > > > > > > > Changes for v2:
> > > > > > > > > - updated commit message
> > > > > > > > >
> > > > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > > > items:
> > > > > > > > > - enum:
> > > > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > > > >
> > > > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > > > match.
> > > > > > >
> > > > > > > Sorry, not sure I understand clearly here.
> > > > > > >
> > > > > > > This the dts file ie used matched compatible.
> > > > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > > > "fsl,imx8mm";
> > > > > > >
> > > > > > > I did build the dtbs_check without showing any issues like,
> > > > > > >
> > > > > > > $ make ARCH=arm64 dtbs_check
> > > > > > > ...
> > > > > > >
> > > > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > > ..
> > > > > > >
> > > > > > > Can you let me know what I missed here?
> > > > > >
> > > > > > You pasted here output of validating with property-units.yaml (or
> > > > > > something else), not the schema which you changed. If you want to limit
> > > > > > the tests, use DT_SCHEMA_FILES.
> > > > > >
> > > > > > I mentioned about exactly the same problem in yout previous v1
> > > > > > at patch #5. No changes here stil.
> > > > >
> > > > > Yes, I usually did that check before posting. Please check the build
> > > > > log below and fsl.yaml binding is fine to build.
> > > > >
> > > > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> > > >
> > > > 1. Wrong path to schema file,
> > > > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > > > right?
> > >
> > > But kbuild is building the fsl.yaml I did verify with by adding some
> > > wrong character in the file, it is showing build issues.
> > >
> > > Please check the clean log.
> > >
> > > # make mrproper
> > > CLEAN Documentation/devicetree/bindings
> > > CLEAN scripts/basic
> > > CLEAN scripts/dtc
> > > # make dt_binding_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> > > HOSTCC scripts/basic/fixdep
> > > HOSTCC scripts/dtc/dtc.o
> > > HOSTCC scripts/dtc/flattree.o
> > > HOSTCC scripts/dtc/fstree.o
> > > HOSTCC scripts/dtc/data.o
> > > HOSTCC scripts/dtc/livetree.o
> > > HOSTCC scripts/dtc/treesource.o
> > > HOSTCC scripts/dtc/srcpos.o
> > > HOSTCC scripts/dtc/checks.o
> > > HOSTCC scripts/dtc/util.o
> > > LEX scripts/dtc/dtc-lexer.lex.c
> > > YACC scripts/dtc/dtc-parser.tab.[ch]
> > > HOSTCC scripts/dtc/dtc-lexer.lex.o
> > > HOSTCC scripts/dtc/dtc-parser.tab.o
> > > HOSTCC scripts/dtc/yamltree.o
> > > HOSTLD scripts/dtc/dtc
> > > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> > > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > > 'additionalProperties' is a required property
> > > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> > > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> > > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> > > /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> > > error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/media/coda.yaml
> > > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> > > DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> > > DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> >
> > Any further comments? I'm planning to send v3.
>
> What comments do you need? Your schema and DTS are wrong. If you run
> dtbs_check, which I mentioned in the first email, you would see the
> result. Instead you pasted unrelevant check of other bindings and
> later pasted dt_binding_check. It does not make sense, so I clarified:
> > 2. Bindings pass, they are not a problem. You were running dtbs_check, right?
>
> And you pasted dt_binding_check, so it kind of closes the discussion.
> I don't know what to add more.
> I reported this problem already in v1, so please don't send the same
> wrong code for the third time.
Let's make it obvious:
$ make -j4 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
make[1]: Entering directory '/home/dev/linux/linux/out'
UPD include/config/kernel.release
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml
CHECK arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml
/home/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['engicam,icore-mx8mm-ctouch2', 'engicam,icore-mx8mm', 'fsl,imx8mm'] is too long
Additional items are not allowed ('fsl,imx8mm' was unexpected)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
@ 2020-12-22 20:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 50+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-22 20:32 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, Will Deacon, Shawn Guo, linux-kernel, Li Yang,
Rob Herring, NXP Linux Team, Catalin Marinas, Fabio Estevam,
linux-amarula, linux-arm-kernel
On Tue, Dec 22, 2020 at 09:25:40PM +0100, Krzysztof Kozlowski wrote:
> On Tue, 22 Dec 2020 at 19:28, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > > > >
> > > > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > > > >
> > > > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > > > touch interface support.
> > > > > > > > >
> > > > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > > > >
> > > > > > > > > Add bindings for it.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > > > ---
> > > > > > > > > Changes for v2:
> > > > > > > > > - updated commit message
> > > > > > > > >
> > > > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > > > items:
> > > > > > > > > - enum:
> > > > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > > > >
> > > > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > > > match.
> > > > > > >
> > > > > > > Sorry, not sure I understand clearly here.
> > > > > > >
> > > > > > > This the dts file ie used matched compatible.
> > > > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > > > "fsl,imx8mm";
> > > > > > >
> > > > > > > I did build the dtbs_check without showing any issues like,
> > > > > > >
> > > > > > > $ make ARCH=arm64 dtbs_check
> > > > > > > ...
> > > > > > >
> > > > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > > > ..
> > > > > > >
> > > > > > > Can you let me know what I missed here?
> > > > > >
> > > > > > You pasted here output of validating with property-units.yaml (or
> > > > > > something else), not the schema which you changed. If you want to limit
> > > > > > the tests, use DT_SCHEMA_FILES.
> > > > > >
> > > > > > I mentioned about exactly the same problem in yout previous v1
> > > > > > at patch #5. No changes here stil.
> > > > >
> > > > > Yes, I usually did that check before posting. Please check the build
> > > > > log below and fsl.yaml binding is fine to build.
> > > > >
> > > > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> > > >
> > > > 1. Wrong path to schema file,
> > > > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > > > right?
> > >
> > > But kbuild is building the fsl.yaml I did verify with by adding some
> > > wrong character in the file, it is showing build issues.
> > >
> > > Please check the clean log.
> > >
> > > # make mrproper
> > > CLEAN Documentation/devicetree/bindings
> > > CLEAN scripts/basic
> > > CLEAN scripts/dtc
> > > # make dt_binding_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> > > HOSTCC scripts/basic/fixdep
> > > HOSTCC scripts/dtc/dtc.o
> > > HOSTCC scripts/dtc/flattree.o
> > > HOSTCC scripts/dtc/fstree.o
> > > HOSTCC scripts/dtc/data.o
> > > HOSTCC scripts/dtc/livetree.o
> > > HOSTCC scripts/dtc/treesource.o
> > > HOSTCC scripts/dtc/srcpos.o
> > > HOSTCC scripts/dtc/checks.o
> > > HOSTCC scripts/dtc/util.o
> > > LEX scripts/dtc/dtc-lexer.lex.c
> > > YACC scripts/dtc/dtc-parser.tab.[ch]
> > > HOSTCC scripts/dtc/dtc-lexer.lex.o
> > > HOSTCC scripts/dtc/dtc-parser.tab.o
> > > HOSTCC scripts/dtc/yamltree.o
> > > HOSTLD scripts/dtc/dtc
> > > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> > > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> > > 'additionalProperties' is a required property
> > > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > > 'additionalProperties' is a required property
> > > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> > > /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> > > /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> > > /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> > > error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/media/coda.yaml
> > > /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> > > ignoring, error in schema:
> > > warning: no schema found in file:
> > > ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> > > DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> > > DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> >
> > Any further comments? I'm planning to send v3.
>
> What comments do you need? Your schema and DTS are wrong. If you run
> dtbs_check, which I mentioned in the first email, you would see the
> result. Instead you pasted unrelevant check of other bindings and
> later pasted dt_binding_check. It does not make sense, so I clarified:
> > 2. Bindings pass, they are not a problem. You were running dtbs_check, right?
>
> And you pasted dt_binding_check, so it kind of closes the discussion.
> I don't know what to add more.
> I reported this problem already in v1, so please don't send the same
> wrong code for the third time.
Let's make it obvious:
$ make -j4 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
make[1]: Entering directory '/home/dev/linux/linux/out'
UPD include/config/kernel.release
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml
CHECK arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml
/home/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['engicam,icore-mx8mm-ctouch2', 'engicam,icore-mx8mm', 'fsl,imx8mm'] is too long
Additional items are not allowed ('fsl,imx8mm' was unexpected)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
end of thread, other threads:[~2020-12-22 20:33 UTC | newest]
Thread overview: 50+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 11:31 [PATCH v2 0/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 11:31 ` [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00 Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 13:42 ` Krzysztof Kozlowski
2020-12-21 13:42 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 13:46 ` Krzysztof Kozlowski
2020-12-21 13:46 ` Krzysztof Kozlowski
2020-12-21 13:59 ` Jagan Teki
2020-12-21 13:59 ` Jagan Teki
2020-12-21 14:05 ` Krzysztof Kozlowski
2020-12-21 14:05 ` Krzysztof Kozlowski
2020-12-21 14:39 ` Jagan Teki
2020-12-21 14:39 ` Jagan Teki
2020-12-21 14:42 ` Krzysztof Kozlowski
2020-12-21 14:42 ` Krzysztof Kozlowski
2020-12-21 14:47 ` Jagan Teki
2020-12-21 14:47 ` Jagan Teki
2020-12-22 18:28 ` Jagan Teki
2020-12-22 18:28 ` Jagan Teki
2020-12-22 20:25 ` Krzysztof Kozlowski
2020-12-22 20:25 ` Krzysztof Kozlowski
2020-12-22 20:32 ` Krzysztof Kozlowski
2020-12-22 20:32 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 13:52 ` Krzysztof Kozlowski
2020-12-21 13:52 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 14:01 ` Krzysztof Kozlowski
2020-12-21 14:01 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 5/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 11:31 ` [PATCH v2 6/6] arm64: dts: imx8mm: " Jagan Teki
2020-12-21 11:31 ` Jagan Teki
2020-12-21 14:06 ` Krzysztof Kozlowski
2020-12-21 14:06 ` Krzysztof Kozlowski
2020-12-21 19:33 ` Jagan Teki
2020-12-21 19:33 ` Jagan Teki
2020-12-21 21:06 ` Krzysztof Kozlowski
2020-12-21 21:06 ` Krzysztof Kozlowski
2020-12-22 8:50 ` Jagan Teki
2020-12-22 8:50 ` Jagan Teki
2020-12-22 8:53 ` Krzysztof Kozlowski
2020-12-22 8:53 ` Krzysztof Kozlowski
2020-12-22 9:05 ` Jagan Teki
2020-12-22 9:05 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.