From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B18AC4332B for ; Mon, 21 Dec 2020 13:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D6A022BE8 for ; Mon, 21 Dec 2020 13:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbgLUNxS (ORCPT ); Mon, 21 Dec 2020 08:53:18 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:53226 "EHLO mail-wm1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbgLUNxR (ORCPT ); Mon, 21 Dec 2020 08:53:17 -0500 Received: by mail-wm1-f52.google.com with SMTP id a6so9942353wmc.2; Mon, 21 Dec 2020 05:53:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZGMHpoCRLlbOSEzZjyZVGgOPbJYrjNNdJ+KlSJquj+Q=; b=fVBFKEvAy4x+iU+af9o/SiLvpi02hIkA6puaSWPR6BF8qFUD116hMHZOgy7brmZ75N LiHbBqvs5iSsGXnr85Gp3eK7WzAWR0OaoVaPeWoG6v5TM9ISYl7+y1bnIc4u8iSNtXqR +0aq+V+NUbwfOd7rvCGecnt18iJKF1jKYT4T4I60VdnzEGql9gFvbUVN4EheRNApjBK9 MfMAj1pDV739BCvLvdXytvA5exxRfjm7cun2x4HHS47vRUqi0TLN+xPbpjlRJy8jzZFh rrltBJZt4Xk/4r+EzeyTsZEMYgD6/ebUsHFYt2vGfP9crMQcIwf6U+r7dRVlfiAVdujP MeSg== X-Gm-Message-State: AOAM5311iD1ptsvDvUJzC0hjumeWShKP2FVzopZwpU5Tx8w3Hn+SyXqs rl3FoRv/CBwI0vo/z4cKN/o= X-Google-Smtp-Source: ABdhPJyn9o9z9crVuHtjXoAdSRRjx8DzRlfUgq/b6lvll+qePrGU8R5O4xYbBX9OMsmd2QtgJ8jqcQ== X-Received: by 2002:a1c:7d94:: with SMTP id y142mr16765008wmc.105.1608558754985; Mon, 21 Dec 2020 05:52:34 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id z3sm27811592wrn.59.2020.12.21.05.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 05:52:33 -0800 (PST) Date: Mon, 21 Dec 2020 14:52:32 +0100 From: Krzysztof Kozlowski To: Jagan Teki Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula@amarulasolutions.com, Catalin Marinas , Will Deacon , Matteo Lisi Subject: Re: [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM Message-ID: <20201221135232.GC31176@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-4-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201221113151.94515-4-jagan@amarulasolutions.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2020 at 05:01:48PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini > from Engicam. > > General features: > - NXP i.MX8M Mini > - Up to 2GB LDDR4 > - 8/16GB eMMC > - Gigabit Ethernet > - USB 2.0 Host/OTG > - PCIe Gen2 interface > - I2S > - MIPI DSI to LVDS > - rest of i.MX8M Mini features > > i.Core MX8M Mini needs to mount on top of Engicam baseboards > for creating complete platform solutions. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > Changes for v2: > - updated commit message > - add cpu nodes > - add fec1 node > - fixed pmic tree comments > - dropped engicam from filename since it aligned with imx6 engicam > dts files naming conventions. Thanks for the changes. > > .../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++ > 1 file changed, 232 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > new file mode 100644 > index 000000000000..e67865fd102a > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > @@ -0,0 +1,232 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2018 NXP > + * Copyright (c) 2019 Engicam srl > + * Copyright (c) 2020 Amarula Solutons(India) > + */ > + > +/ { > + compatible = "engicam,icore-mx8mm", "fsl,imx8mm"; > +}; > + > +&A53_0 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_1 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_2 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_3 { > + cpu-supply = <®_buck4>; > +}; > + > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec1>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy>; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy: ethernet-phy@3 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <3>; > + reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic@8 { > + compatible = "nxp,pf8121a"; > + reg = <0x08>; > + > + regulators { > + reg_ldo1: ldo1 { > + regulator-max-microvolt = <5000000>; > + regulator-min-microvolt = <1500000>; I mentioned previously min/max hoping it will be obvious (as most or even all of DTS follow this convention... although not example in your regulator) but let be more specific: first min, then max. Don't reverse the logic. See also example in the regulator.yaml. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99914C433E0 for ; Mon, 21 Dec 2020 13:54:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D8AB2250E for ; Mon, 21 Dec 2020 13:54:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D8AB2250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d/6jHOnlFE3Oriz5OcC2GevGnITQDabD9AwEsJpw2No=; b=V88NUiSZNUMwE2mIFPg7+s33Q zL3lil5QmB5RZMK+balDWUvJM/494ymSPAym15QU8QgSY1w7Qbh41jezr5Lm/iWiUlb2iyJbiPzjH Hcu2D0JUUHpI/LHVaHFSyA4dPO8FRGh6QKZlTp6X6nNdt7jdjvBwDWgS1f7Wm0e9bsLXQag0DQFEY mns4ZSuIitym6azZlGNCK87S+rECsbhL+aVRm+jXH2MRigFztI+33Peen8wlzQAxJCRw5mJdnz3bW 2/WskSNeUOi2sStagGoBwMpk3AIL6UZyQm3RnFtuNjrva2RA2wMvF11dOuJy/zbX2ILpfB+4Hocqv GUxvVXk0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krLc9-0000Ud-SK; Mon, 21 Dec 2020 13:52:42 +0000 Received: from mail-wm1-f53.google.com ([209.85.128.53]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krLc4-0000Tb-Gg for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 13:52:39 +0000 Received: by mail-wm1-f53.google.com with SMTP id c133so9951234wme.4 for ; Mon, 21 Dec 2020 05:52:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZGMHpoCRLlbOSEzZjyZVGgOPbJYrjNNdJ+KlSJquj+Q=; b=d2QE5MSL58phYXgNcR0cE13hcf4MmQtZIxP2YhUT0HT/Efh4R5nOlW1NnBV3eeLEr4 aZdQ/F9hpq7T5yDbeX5D8AxF4mVtmAF8Ie2FD4TZskU5B9iWEY4KsbikekiLWojbc7O0 G4CpMXz+g4gARzeLgmrxCaxGMG6rr3MC7qqHKmsgVu45jiCMcYfAF3JuMAdyuISUK1YV +X0sFmSSIbO9UWOUsOxveZAWo3HXbif/Vqcx8cdJE9z+IcYq8HC6QQA0zbWyT95t5I5u Ul06Cq1IF5KVwFeMwO7fmSEp5k99sWKeFQWUSpt928m4PuXpFe8zBwxw/VLZDSnXKsfk 74og== X-Gm-Message-State: AOAM531KCoPqHpbiFiTlx+VHAb6ZdMgTjpLDr1hgTFecKidv2VhyFgAW Ua2sog6e5HX5ZlzBItafxu0= X-Google-Smtp-Source: ABdhPJyn9o9z9crVuHtjXoAdSRRjx8DzRlfUgq/b6lvll+qePrGU8R5O4xYbBX9OMsmd2QtgJ8jqcQ== X-Received: by 2002:a1c:7d94:: with SMTP id y142mr16765008wmc.105.1608558754985; Mon, 21 Dec 2020 05:52:34 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id z3sm27811592wrn.59.2020.12.21.05.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 05:52:33 -0800 (PST) Date: Mon, 21 Dec 2020 14:52:32 +0100 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM Message-ID: <20201221135232.GC31176@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-4-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201221113151.94515-4-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_085236_594445_DCB34059 X-CRM114-Status: GOOD ( 22.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 21, 2020 at 05:01:48PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini > from Engicam. > > General features: > - NXP i.MX8M Mini > - Up to 2GB LDDR4 > - 8/16GB eMMC > - Gigabit Ethernet > - USB 2.0 Host/OTG > - PCIe Gen2 interface > - I2S > - MIPI DSI to LVDS > - rest of i.MX8M Mini features > > i.Core MX8M Mini needs to mount on top of Engicam baseboards > for creating complete platform solutions. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > Changes for v2: > - updated commit message > - add cpu nodes > - add fec1 node > - fixed pmic tree comments > - dropped engicam from filename since it aligned with imx6 engicam > dts files naming conventions. Thanks for the changes. > > .../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++++++++++++++++++ > 1 file changed, 232 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > new file mode 100644 > index 000000000000..e67865fd102a > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi > @@ -0,0 +1,232 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2018 NXP > + * Copyright (c) 2019 Engicam srl > + * Copyright (c) 2020 Amarula Solutons(India) > + */ > + > +/ { > + compatible = "engicam,icore-mx8mm", "fsl,imx8mm"; > +}; > + > +&A53_0 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_1 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_2 { > + cpu-supply = <®_buck4>; > +}; > + > +&A53_3 { > + cpu-supply = <®_buck4>; > +}; > + > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec1>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy>; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy: ethernet-phy@3 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <3>; > + reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic@8 { > + compatible = "nxp,pf8121a"; > + reg = <0x08>; > + > + regulators { > + reg_ldo1: ldo1 { > + regulator-max-microvolt = <5000000>; > + regulator-min-microvolt = <1500000>; I mentioned previously min/max hoping it will be obvious (as most or even all of DTS follow this convention... although not example in your regulator) but let be more specific: first min, then max. Don't reverse the logic. See also example in the regulator.yaml. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel