From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3764C433E0 for ; Mon, 21 Dec 2020 21:07:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E129212CC for ; Mon, 21 Dec 2020 21:07:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbgLUVGr (ORCPT ); Mon, 21 Dec 2020 16:06:47 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:55862 "EHLO mail-wm1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgLUVGq (ORCPT ); Mon, 21 Dec 2020 16:06:46 -0500 Received: by mail-wm1-f54.google.com with SMTP id x22so191446wmc.5; Mon, 21 Dec 2020 13:06:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V2+oO6hKZD9nwHnMJXdudXSQ6XwAnQ27uNwEQEnrKo8=; b=ciK6FTfheTfNFmvO8aMaJ8maMvZMWxXKSseg1N9hnNILkgyluLjIpETn/843WCvHAu NpvaLavbde558bhNBGZnG/xD8MYsET9oFvy9848WtMzAXk34QGkTLmgILnJTBwqWGJj2 ba2aARa5E52z1vfcMQq/hXJBWrQKk3/zIjX+s09tuHyK7rYpd6Zrb7Fb8GLTKPIi/Wml mMajeW83VDC2mpqf2D/8eur1LqgK/N0+iNaPwxfbFMoUfzOZFeQu4Y53CitnRHXYNiVH DiMUumICzcKufLDj1vXJXHjKX1g6RZ0G7rXYNwmpQJjXoIxoy3LihgyWVIHBROuNihQ+ Pvyw== X-Gm-Message-State: AOAM533jJGUSLxj1hLGyVs8OLctWN0YiZDI+GMNJIBMjTnpdjMWgNlqw 3YzM+BB5CSrCogCh+ZY2csg= X-Google-Smtp-Source: ABdhPJy3uowExhemmsV1T64W1OyijKCRcNtUXm4LuQcRrLxDiGV4DwV7NLPcYBE5sRaJl3EvaxUXpQ== X-Received: by 2002:a1c:c204:: with SMTP id s4mr18116946wmf.73.1608584764047; Mon, 21 Dec 2020 13:06:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r7sm20000885wmh.2.2020.12.21.13.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 13:06:03 -0800 (PST) Date: Mon, 21 Dec 2020 22:06:01 +0100 From: Krzysztof Kozlowski To: Jagan Teki Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Message-ID: <20201221210601.GB2504@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > Evaluation Board. > > > > > > Genaral features: > > > - LCD 7" C.Touch > > > - microSD slot > > > - Ethernet 1Gb > > > - Wifi/BT > > > - 2x LVDS Full HD interfaces > > > - 3x USB 2.0 > > > - 1x USB 3.0 > > > - HDMI Out > > > - Mini PCIe > > > - MIPI CSI > > > - 2x CAN > > > - Audio Out > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > Mainline Linux supported. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v2: > > > - updated commit message > > > - dropped engicam from filename since it aligned with imx6 engicam > > > dts files naming conventions. > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > 3 files changed, 29 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 8d49a2c74604..43783076f856 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > new file mode 100644 > > > index 000000000000..294df07289a2 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > @@ -0,0 +1,7 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2020 Engicam srl > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > + */ > > > + > > > +#include "imx8mm-engicam-common.dtsi" > > > > It seems you ignored my comments from previous email. That's not how we > > go with the process. > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > create files which do nothing. > > Idea is to move common nodes in separate dtsi instead of adding > redundant nodes into respective areas. let me know if it still > confusing. A file which *only* includes another file does not fulfill this idea of moving common nodes to a separate DTSI file. Or if I still miss something, please point me, what common nodes are stored in imx8mm-engicam-edimm2.2.dtsi? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F91EC433DB for ; Mon, 21 Dec 2020 21:07:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CFAB212CC for ; Mon, 21 Dec 2020 21:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CFAB212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0dtJ9q+Z61TBbpAi/KYaxB1xDo5tf/Y39kSd+RziTbw=; b=Sn+CoJ6nuKdrifY2dnS8YEvBj VyV/ItdXwWgujzNvjj/dGoHKobikh+7x9+iMC4cRYR9pUz9Jro29Vf+wqrPfuMa+3xZBH8zROznrO 5qMLZv1pgvI3VAX6yBABzTHAp5lwUltIAVly+lEsvB0trvIfjKopJS+37oxJFkVQHUMH9hIhXYwsX Wo0Vw4jpQ13Y/z81j8AnNWF9OUAGU1jztjEV/qDfl4TBpL3+Z2+HNEzN9Xu1T47d5IpZnyq8olOWg M025d2g+2F4RIh2HIB3K100HasOEKVrtqJ7WybrTHG/pB4Yovf0YBA9z67UgyMAxyvI38ecuVcFOI PqXQDNLmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krSNc-0001sb-Qo; Mon, 21 Dec 2020 21:06:08 +0000 Received: from mail-wm1-f48.google.com ([209.85.128.48]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krSNa-0001ra-A1 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 21:06:07 +0000 Received: by mail-wm1-f48.google.com with SMTP id 190so210519wmz.0 for ; Mon, 21 Dec 2020 13:06:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V2+oO6hKZD9nwHnMJXdudXSQ6XwAnQ27uNwEQEnrKo8=; b=LJYPI0M8GnEV/wFN3rTjmGUS0qK8zRtQxfv+JYvWsnqjnuB7n7HzaUjSVbMaOytfSn GOUFAGxIAzVmncdsMANtBl9nAATxFeb3ZkaOTwMG7Jba4c5dHxHvhhHfXVn+iJY3eVNZ DfvbF/B5il3qLUdpozljlCjMpJGl9DENMQcLzwa9NURu4loSPeK9elyREksUgsKDt9cc c9y7pNAeJqwpO3OiOp8W/RBjwGUMrQtSCDFZ4+Cyvn4Jj95obyKnA45/RORXZVjFEhFZ gXgcNLPg2FTCyTPNoAPKkst+NVEKRzS1AUmLIb5VVWPzMkgFQVY3ellCsf19hB+ygxRv Yesg== X-Gm-Message-State: AOAM5308qoRWQpT4Pdy7JJfRPQcdtvn/3k99vJJwZi76DHL+1PmqS86m guiI3yY5qTJsVkYl2DGm6U4= X-Google-Smtp-Source: ABdhPJy3uowExhemmsV1T64W1OyijKCRcNtUXm4LuQcRrLxDiGV4DwV7NLPcYBE5sRaJl3EvaxUXpQ== X-Received: by 2002:a1c:c204:: with SMTP id s4mr18116946wmf.73.1608584764047; Mon, 21 Dec 2020 13:06:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r7sm20000885wmh.2.2020.12.21.13.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 13:06:03 -0800 (PST) Date: Mon, 21 Dec 2020 22:06:01 +0100 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Message-ID: <20201221210601.GB2504@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_160606_387326_A7304D4B X-CRM114-Status: GOOD ( 27.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > Evaluation Board. > > > > > > Genaral features: > > > - LCD 7" C.Touch > > > - microSD slot > > > - Ethernet 1Gb > > > - Wifi/BT > > > - 2x LVDS Full HD interfaces > > > - 3x USB 2.0 > > > - 1x USB 3.0 > > > - HDMI Out > > > - Mini PCIe > > > - MIPI CSI > > > - 2x CAN > > > - Audio Out > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > Mainline Linux supported. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v2: > > > - updated commit message > > > - dropped engicam from filename since it aligned with imx6 engicam > > > dts files naming conventions. > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > 3 files changed, 29 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 8d49a2c74604..43783076f856 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > new file mode 100644 > > > index 000000000000..294df07289a2 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > @@ -0,0 +1,7 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2020 Engicam srl > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > + */ > > > + > > > +#include "imx8mm-engicam-common.dtsi" > > > > It seems you ignored my comments from previous email. That's not how we > > go with the process. > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > create files which do nothing. > > Idea is to move common nodes in separate dtsi instead of adding > redundant nodes into respective areas. let me know if it still > confusing. A file which *only* includes another file does not fulfill this idea of moving common nodes to a separate DTSI file. Or if I still miss something, please point me, what common nodes are stored in imx8mm-engicam-edimm2.2.dtsi? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel