All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Rob Herring <robh@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	kieran.bingham+renesas@ideasonboard.com,
	laurent.pinchart+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hyun Kwon <hyunk@xilinx.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	sergei.shtylyov@gmail.com
Subject: Re: [PATCH v6 2/5] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt'
Date: Tue, 22 Dec 2020 09:53:44 +0100	[thread overview]
Message-ID: <20201222085344.gb7nqhbenn65yaux@uno.localdomain> (raw)
In-Reply-To: <20201221185827.GA359098@robh.at.kernel.org>

Hi Rob, Laurent,

On Mon, Dec 21, 2020 at 11:58:27AM -0700, Rob Herring wrote:
> On Wed, Dec 16, 2020 at 07:17:05PM +0200, Laurent Pinchart wrote:
> > > > @@ -221,6 +241,7 @@ required:
> > > >    - ports
> > > >    - i2c-mux
> > > >    - gpio-controller
> > > > +  - maxim,reverse-channel-microvolt
> >
> > One comment though: You specify a default value above, which isn't very
> > useful when the property is required. Should we either drop the default
> > value, or make the property optional ?
>
> And generally added properties can't be required unless for some reason
> DT's without the property are broken.

My thinking was to make it required for new DTS and specify a default
for the old ones that do not have the property. I'll drop required and
keep the default value in next version.

Thanks
  j

>
> With required dropped,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> Rob

  reply	other threads:[~2020-12-22  8:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 17:09 [PATCH v6 0/5] media: i2c: Add RDACM21 camera module Jacopo Mondi
2020-12-15 17:09 ` [PATCH v6 1/5] media: i2c: Add driver for " Jacopo Mondi
2020-12-16 17:00   ` Laurent Pinchart
2020-12-15 17:09 ` [PATCH v6 2/5] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt' Jacopo Mondi
2020-12-16 17:05   ` Laurent Pinchart
2020-12-16 17:17     ` Laurent Pinchart
2020-12-21 18:58       ` Rob Herring
2020-12-22  8:53         ` Jacopo Mondi [this message]
2020-12-15 17:09 ` [PATCH v6 3/5] media: i2c: max9286: Break-out reverse channel setup Jacopo Mondi
2020-12-16 17:06   ` Laurent Pinchart
2020-12-15 17:09 ` [PATCH v6 4/5] media: i2c: max9286: Make channel amplitude programmable Jacopo Mondi
2020-12-16 17:14   ` Laurent Pinchart
2020-12-16 17:14     ` Laurent Pinchart
2020-12-15 17:09 ` [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude Jacopo Mondi
2020-12-16 17:22   ` Laurent Pinchart
2021-01-11 10:43     ` Jacopo Mondi
2021-01-11 10:58       ` Laurent Pinchart
2021-01-11 11:20         ` Jacopo Mondi
2021-01-12  5:03           ` Laurent Pinchart
2021-01-12  9:08             ` Jacopo Mondi
2021-01-12  9:10               ` Geert Uytterhoeven
2021-01-12 10:00                 ` Jacopo Mondi
2021-01-14  5:53               ` Laurent Pinchart
2021-01-14  8:09                 ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201222085344.gb7nqhbenn65yaux@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=hyunk@xilinx.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=robh@kernel.org \
    --cc=sergei.shtylyov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.