From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47616C4332D for ; Tue, 22 Dec 2020 09:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B27B2310D for ; Tue, 22 Dec 2020 09:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726313AbgLVJOw (ORCPT ); Tue, 22 Dec 2020 04:14:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbgLVJOv (ORCPT ); Tue, 22 Dec 2020 04:14:51 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3D3C0613D3 for ; Tue, 22 Dec 2020 01:14:11 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id h186so8130288pfe.0 for ; Tue, 22 Dec 2020 01:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=MH/242BQ7qGA/c7ZKFlxo9k35H+BRyW2M9A5zqCbM7dzzv0lHpYdUkBpCj7oEZp13m Ffv/YsG7ikpYjSZ/eEGKTEqY8LO+IwgxlNhlguzw31ez4ZqJJXcjZLoVnBXGWPC6ErWp C4MMWo1PjKz1dR7jRL3QB8SQVMUTHXfciaZm6EDwN6BotFowAPQcOqN9+kpF0OvIKtTd 1qrZG5oeRJU/1gmMrD39Gfgd5fELI6zV4kIgaf3rqokdN4f26P7QJMe8AgrauAKTYpgV F65EaKqCccbzS16iksFwGpcNQ/HNxaTyiClovDAv6TCiG96SWFf14Mxu2pqAyQ6WpN2l eGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=cNelTg3iHiEKbwHyaOgMZfS3+70anmlr6YJ96zNCNbmZLZ4iYj0eAymOn9o0/7I6pG Vq52LNiuFD97yUjfoCu25mCrpvhGVzufCFs+mbqgB9FOlju956eWe672jwAuDk+3DKS4 fCycYtRUQi4J5sEf6RSRQ6YgI2PvBj8SZ2USfLIMCvkQ6h1AykkY7R7d4/YXIgjyw0IB 4XpZwG5TEM8rJRyFvq7nL/phPjrVp6oXsymn71xQVcr56kRmGrZvdOstWf+XivMQ8dKO MOhwkuP4ZtzH4kzRKnJoBbAPje0ujak5mZJ9D8ApvPvGm3fSivM0cXn0pPTSs0H1a9pQ oI/A== X-Gm-Message-State: AOAM533axtWAzFf+AkXWT8sof5Pulxg+o2eof8Y5YiKLxrqKMFMBnKuY VZRJoBwiCRCMSW/tDcifhbpbJw== X-Google-Smtp-Source: ABdhPJxR442Its0VhdjNxmES11BozYg6f4jsASsSW6TfWxeI3592psXLb9CuQTRVoVKmE/eJsKTU5A== X-Received: by 2002:a05:6a00:230d:b029:18b:9cb:dead with SMTP id h13-20020a056a00230db029018b09cbdeadmr18667524pfh.24.1608628450994; Tue, 22 Dec 2020 01:14:10 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t5sm18222978pjr.22.2020.12.22.01.14.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 01:14:10 -0800 (PST) Date: Tue, 22 Dec 2020 14:44:08 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 44/48] ARM: tegra: Add OPP tables and power domains to Tegra30 device-tree Message-ID: <20201222091408.vvputqs27olywdxq@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-45-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217180638.22748-45-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 17-12-20, 21:06, Dmitry Osipenko wrote: > diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > index cbe84d25e726..983db1a06682 100644 > --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > +++ b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > @@ -1,6 +1,56 @@ > // SPDX-License-Identifier: GPL-2.0 > > / { > + core_opp_table: core-power-domain-opp-table { > + compatible = "operating-points-v2"; > + opp-shared; > + > + core_opp_950: opp@950000 { > + opp-microvolt = <950000 950000 1350000>; > + opp-level = <950000>; Perhaps you don't need to exactly copy the voltage value into the level field. The level field can just be kept to 0, 1,2, 3, etc.. > + }; > + > + core_opp_1000: opp@1000000 { > + opp-microvolt = <1000000 1000000 1350000>; > + opp-level = <1000000>; > + }; > + > + core_opp_1050: opp@1050000 { > + opp-microvolt = <1050000 1050000 1350000>; > + opp-level = <1050000>; > + }; > + > + core_opp_1100: opp@1100000 { > + opp-microvolt = <1100000 1100000 1350000>; > + opp-level = <1100000>; > + }; > + > + core_opp_1150: opp@1150000 { > + opp-microvolt = <1150000 1150000 1350000>; > + opp-level = <1150000>; > + }; > + > + core_opp_1200: opp@1200000 { > + opp-microvolt = <1200000 1200000 1350000>; > + opp-level = <1200000>; > + }; > + > + core_opp_1250: opp@1250000 { > + opp-microvolt = <1250000 1250000 1350000>; > + opp-level = <1250000>; > + }; > + > + core_opp_1300: opp@1300000 { > + opp-microvolt = <1300000 1300000 1350000>; > + opp-level = <1300000>; > + }; > + > + core_opp_1350: opp@1350000 { > + opp-microvolt = <1350000 1350000 1350000>; > + opp-level = <1350000>; > + }; > + }; -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67819C433E0 for ; Tue, 22 Dec 2020 09:14:20 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 102D322AAE for ; Tue, 22 Dec 2020 09:14:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 102D322AAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9587A2729B; Tue, 22 Dec 2020 09:14:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L6CNGsxGMvKW; Tue, 22 Dec 2020 09:14:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 9FECE23492; Tue, 22 Dec 2020 09:14:15 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 402A91BF27C for ; Tue, 22 Dec 2020 09:14:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3BF82869D4 for ; Tue, 22 Dec 2020 09:14:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4pyZDYSqa9b for ; Tue, 22 Dec 2020 09:14:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by whitealder.osuosl.org (Postfix) with ESMTPS id 5C39F8687A for ; Tue, 22 Dec 2020 09:14:11 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id t22so8124025pfl.3 for ; Tue, 22 Dec 2020 01:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=MH/242BQ7qGA/c7ZKFlxo9k35H+BRyW2M9A5zqCbM7dzzv0lHpYdUkBpCj7oEZp13m Ffv/YsG7ikpYjSZ/eEGKTEqY8LO+IwgxlNhlguzw31ez4ZqJJXcjZLoVnBXGWPC6ErWp C4MMWo1PjKz1dR7jRL3QB8SQVMUTHXfciaZm6EDwN6BotFowAPQcOqN9+kpF0OvIKtTd 1qrZG5oeRJU/1gmMrD39Gfgd5fELI6zV4kIgaf3rqokdN4f26P7QJMe8AgrauAKTYpgV F65EaKqCccbzS16iksFwGpcNQ/HNxaTyiClovDAv6TCiG96SWFf14Mxu2pqAyQ6WpN2l eGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=hG4KjspgzPhMK6gIurXNM7Zb6WOjhYf8TisEiDozZ8LIlF9eC4NnVgcypEUOU6iXbs a0kTLeHQU3DjV2eveJYqqtlOMGBzgzlAjpe2jN7Nc4aBLxj8J7/WCWYY6/f/S5LQ4L2L nCr+qHwmFBLFZ2O6cnEugqLTTlNCOf1Uw5ER0FBDN6DrF5bALkNa4Q954Vub4HCP65JI NINSfbIvMbVCEe3Ajsp6bV1wpSkbBhO7/Qb0cGVf+ApFpwe6cfWomM4pAecdQhOEr/91 6XgR//kJ9ZSN1VAvUfTJLMYjVU3389ijOYg7/bglYe68pDCAcLRjtDLuWdFJiHw/wJTS 09GQ== X-Gm-Message-State: AOAM53294cy4zQEUxe49MOO14etwLbS9OnlpTUmjrx83JgwrCcKnIdz6 0NJrhKAWByNaSVW+RsohhlDVsA== X-Google-Smtp-Source: ABdhPJxR442Its0VhdjNxmES11BozYg6f4jsASsSW6TfWxeI3592psXLb9CuQTRVoVKmE/eJsKTU5A== X-Received: by 2002:a05:6a00:230d:b029:18b:9cb:dead with SMTP id h13-20020a056a00230db029018b09cbdeadmr18667524pfh.24.1608628450994; Tue, 22 Dec 2020 01:14:10 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t5sm18222978pjr.22.2020.12.22.01.14.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 01:14:10 -0800 (PST) Date: Tue, 22 Dec 2020 14:44:08 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 44/48] ARM: tegra: Add OPP tables and power domains to Tegra30 device-tree Message-ID: <20201222091408.vvputqs27olywdxq@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-45-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201217180638.22748-45-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 17-12-20, 21:06, Dmitry Osipenko wrote: > diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > index cbe84d25e726..983db1a06682 100644 > --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > +++ b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > @@ -1,6 +1,56 @@ > // SPDX-License-Identifier: GPL-2.0 > > / { > + core_opp_table: core-power-domain-opp-table { > + compatible = "operating-points-v2"; > + opp-shared; > + > + core_opp_950: opp@950000 { > + opp-microvolt = <950000 950000 1350000>; > + opp-level = <950000>; Perhaps you don't need to exactly copy the voltage value into the level field. The level field can just be kept to 0, 1,2, 3, etc.. > + }; > + > + core_opp_1000: opp@1000000 { > + opp-microvolt = <1000000 1000000 1350000>; > + opp-level = <1000000>; > + }; > + > + core_opp_1050: opp@1050000 { > + opp-microvolt = <1050000 1050000 1350000>; > + opp-level = <1050000>; > + }; > + > + core_opp_1100: opp@1100000 { > + opp-microvolt = <1100000 1100000 1350000>; > + opp-level = <1100000>; > + }; > + > + core_opp_1150: opp@1150000 { > + opp-microvolt = <1150000 1150000 1350000>; > + opp-level = <1150000>; > + }; > + > + core_opp_1200: opp@1200000 { > + opp-microvolt = <1200000 1200000 1350000>; > + opp-level = <1200000>; > + }; > + > + core_opp_1250: opp@1250000 { > + opp-microvolt = <1250000 1250000 1350000>; > + opp-level = <1250000>; > + }; > + > + core_opp_1300: opp@1300000 { > + opp-microvolt = <1300000 1300000 1350000>; > + opp-level = <1300000>; > + }; > + > + core_opp_1350: opp@1350000 { > + opp-microvolt = <1350000 1350000 1350000>; > + opp-level = <1350000>; > + }; > + }; -- viresh _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE261C433DB for ; Wed, 23 Dec 2020 10:51:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64BA8207F7 for ; Wed, 23 Dec 2020 10:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64BA8207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFEF76E8E1; Wed, 23 Dec 2020 10:51:32 +0000 (UTC) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60C1E6E1BE for ; Tue, 22 Dec 2020 09:14:11 +0000 (UTC) Received: by mail-pg1-x52e.google.com with SMTP id i7so7994342pgc.8 for ; Tue, 22 Dec 2020 01:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=MH/242BQ7qGA/c7ZKFlxo9k35H+BRyW2M9A5zqCbM7dzzv0lHpYdUkBpCj7oEZp13m Ffv/YsG7ikpYjSZ/eEGKTEqY8LO+IwgxlNhlguzw31ez4ZqJJXcjZLoVnBXGWPC6ErWp C4MMWo1PjKz1dR7jRL3QB8SQVMUTHXfciaZm6EDwN6BotFowAPQcOqN9+kpF0OvIKtTd 1qrZG5oeRJU/1gmMrD39Gfgd5fELI6zV4kIgaf3rqokdN4f26P7QJMe8AgrauAKTYpgV F65EaKqCccbzS16iksFwGpcNQ/HNxaTyiClovDAv6TCiG96SWFf14Mxu2pqAyQ6WpN2l eGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MVpnGnCFYtu4ycJzZf+LSk9hEI84NI49MudCxGCR+HM=; b=OoH+Jwn1auOvmXpOlhXoXCIcZQ6CRLz/654irKNXs80oYwlVP2zWFp0lHwKxxHZa0T j7mLaTIoH8K0nOwwVcEHeE6wE32fd5dvez0epzVpOV5Qi6HiiO29tHt1WOZs6tzDWy8/ VRYLMLGZ/QRoa2/uKq2uo+lgeSE1OrlpuDjYq0Za1wx0JYIqOqWZnbJh5vm2HcAoDmiZ u3mE6Sud1zdoMiBjm/b4gwkB3bv8UgX/JCeSaURtuGhOC19MYSEF9aJpo+HrCHdk/m16 Qx9KxDOYVhXz5taZTDfbmL4QAL3gmSEHi5sBANWnPmTk7Y38+nSEUlhQZJSmvmzLo/E/ H9Vg== X-Gm-Message-State: AOAM531/JjhbOJ7tigGIlvYAgAQKzt1oqE/PLBC9r6srspwDUQHjn7Iv +Blka363vLRfdxoNu/c/f7nldg== X-Google-Smtp-Source: ABdhPJxR442Its0VhdjNxmES11BozYg6f4jsASsSW6TfWxeI3592psXLb9CuQTRVoVKmE/eJsKTU5A== X-Received: by 2002:a05:6a00:230d:b029:18b:9cb:dead with SMTP id h13-20020a056a00230db029018b09cbdeadmr18667524pfh.24.1608628450994; Tue, 22 Dec 2020 01:14:10 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t5sm18222978pjr.22.2020.12.22.01.14.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 01:14:10 -0800 (PST) Date: Tue, 22 Dec 2020 14:44:08 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 44/48] ARM: tegra: Add OPP tables and power domains to Tegra30 device-tree Message-ID: <20201222091408.vvputqs27olywdxq@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-45-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201217180638.22748-45-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Wed, 23 Dec 2020 10:51:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 17-12-20, 21:06, Dmitry Osipenko wrote: > diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > index cbe84d25e726..983db1a06682 100644 > --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > +++ b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > @@ -1,6 +1,56 @@ > // SPDX-License-Identifier: GPL-2.0 > > / { > + core_opp_table: core-power-domain-opp-table { > + compatible = "operating-points-v2"; > + opp-shared; > + > + core_opp_950: opp@950000 { > + opp-microvolt = <950000 950000 1350000>; > + opp-level = <950000>; Perhaps you don't need to exactly copy the voltage value into the level field. The level field can just be kept to 0, 1,2, 3, etc.. > + }; > + > + core_opp_1000: opp@1000000 { > + opp-microvolt = <1000000 1000000 1350000>; > + opp-level = <1000000>; > + }; > + > + core_opp_1050: opp@1050000 { > + opp-microvolt = <1050000 1050000 1350000>; > + opp-level = <1050000>; > + }; > + > + core_opp_1100: opp@1100000 { > + opp-microvolt = <1100000 1100000 1350000>; > + opp-level = <1100000>; > + }; > + > + core_opp_1150: opp@1150000 { > + opp-microvolt = <1150000 1150000 1350000>; > + opp-level = <1150000>; > + }; > + > + core_opp_1200: opp@1200000 { > + opp-microvolt = <1200000 1200000 1350000>; > + opp-level = <1200000>; > + }; > + > + core_opp_1250: opp@1250000 { > + opp-microvolt = <1250000 1250000 1350000>; > + opp-level = <1250000>; > + }; > + > + core_opp_1300: opp@1300000 { > + opp-microvolt = <1300000 1300000 1350000>; > + opp-level = <1300000>; > + }; > + > + core_opp_1350: opp@1350000 { > + opp-microvolt = <1350000 1350000 1350000>; > + opp-level = <1350000>; > + }; > + }; -- viresh _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel