All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: "Pasi Kärkkäinen" <pasik@iki.fi>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: Default to HW mSBC on capable controllers ?
Date: Tue, 22 Dec 2020 12:49:40 +0100	[thread overview]
Message-ID: <20201222114940.egjhi3jangsqvpnb@pali> (raw)
In-Reply-To: <20201222114024.GG20371@reaktio.net>

On Tuesday 22 December 2020 13:40:24 Pasi Kärkkäinen wrote:
> Hello Pali,
> 
> On Mon, Dec 21, 2020 at 10:07:07PM +0100, Pali Rohár wrote:
> > 
> > > Any idea if one could patch the kernel to default to HW mSBC and user apps like bluealsa/pulseaudio would just use it automatically?
> > 
> > For usage mSBC hw encoder you need to use Enhanced Setup Synchronous
> > Connection HCI command for establishing SCO connection.
> > 
> > For using HW encoder you need to stop feeding socket with mSBC encoded
> > data and instead put into this socket RAW pcm samples. Also you need
> > somehow inform kernel about this change.
> > 
> > For both things I designed new setsockopt() API which I described in:
> > https://lore.kernel.org/linux-bluetooth/20200419234937.4zozkqgpt557m3o6@pali/
> >
> 
> In that thread Luiz asked for changes to the patch, eg. kernel module option is needed which allows enabling new/experimental features, and your changes should be enabled only when experimental option is given while loading the module.
> 
> See here:
> https://lore.kernel.org/linux-bluetooth/CABBYNZJTBM87Yr+rqUm6MwwSR60YNe+UFr0HHj5T2DkY7LqJqA@mail.gmail.com/
> 
> Could you please add that kernel module option, and re-send the patch ? 

I have not implemented it. I just proposed API between userspace and
kernel. But I have not implemented this API yet.

  reply	other threads:[~2020-12-22 11:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 13:32 Default to HW mSBC on capable controllers ? Joakim Tjernlund
2020-12-18 19:43 ` Luiz Augusto von Dentz
2020-12-20 17:09   ` Joakim Tjernlund
2020-12-21 21:14   ` Pali Rohár
2020-12-22  1:54     ` Luiz Augusto von Dentz
2020-12-22  9:21       ` Pali Rohár
2020-12-22  9:36         ` Jamie Mccrae
2020-12-22  9:48           ` Pali Rohár
2020-12-22 10:05         ` Marcel Holtmann
2020-12-22 10:19           ` Pali Rohár
2020-12-22 11:04             ` Marcel Holtmann
2020-12-22 11:46               ` Pali Rohár
2020-12-22 12:20                 ` Marcel Holtmann
2020-12-22 13:17                   ` Pali Rohár
2020-12-22 21:11                     ` Marcel Holtmann
2020-12-22 21:13                       ` Pali Rohár
2020-12-31 10:09                         ` Pasi Kärkkäinen
2021-01-13 14:46       ` Pali Rohár
2020-12-21 21:07 ` Pali Rohár
2020-12-22 11:40   ` Pasi Kärkkäinen
2020-12-22 11:49     ` Pali Rohár [this message]
2020-12-22 13:20       ` Pali Rohár
2020-12-23 15:41   ` Joakim Tjernlund
2020-12-23 15:56     ` Pali Rohár
2020-12-23 21:58       ` Luiz Augusto von Dentz
2020-12-28 12:42         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201222114940.egjhi3jangsqvpnb@pali \
    --to=pali@kernel.org \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=pasik@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.