From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD7CC43381 for ; Tue, 22 Dec 2020 15:09:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB5B9230FC for ; Tue, 22 Dec 2020 15:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728088AbgLVPJa (ORCPT ); Tue, 22 Dec 2020 10:09:30 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37082 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726920AbgLVPJ3 (ORCPT ); Tue, 22 Dec 2020 10:09:29 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1krjHC-00DOur-V5; Tue, 22 Dec 2020 16:08:38 +0100 Date: Tue, 22 Dec 2020 16:08:38 +0100 From: Andrew Lunn To: Bjarni Jonasson Cc: Steen Hegelund , "David S. Miller" , Jakub Kicinski , Russell King , Lars Povlsen , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Nicolas Ferre , Mark Einon , Masahiro Yamada , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v2 4/8] net: sparx5: add port module support Message-ID: <20201222150838.GN3107610@lunn.ch> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-5-steen.hegelund@microchip.com> <20201220233543.GB3107610@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > +static int sparx5_port_verify_speed(struct sparx5 *sparx5, > > > + struct sparx5_port *port, > > > + struct sparx5_port_config *conf) > > > +{ > > > + case PHY_INTERFACE_MODE_SGMII: > > > + if (conf->speed != SPEED_1000 && > > > + conf->speed != SPEED_100 && > > > + conf->speed != SPEED_10 && > > > + conf->speed != SPEED_2500) > > > + return sparx5_port_error(port, conf, > > > SPX5_PERR_SPEED); > > > > Is it really SGMII over clocked at 2500? Or 2500BaseX? > > Yes the SGMII mode in the serdes driver is overclocked. > Nothing in the switch driver needs changing when changing between > speeds 1G/2G5. So it continues to use the SGMII inband signalling? There is a lot of confusion in this area, but SGMII inband signalling overclocked does not make much sense. So it is more likely to be using 2500BaseX. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000CFC433DB for ; Tue, 22 Dec 2020 15:10:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD39222583 for ; Tue, 22 Dec 2020 15:10:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD39222583 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZH/+zgiAk4ixBmq1mTwAY9EeYsIexIltfEd/soc6274=; b=tg4f7P2+ado/RvijcYUBadbJD 0/LeGFSujLs5fzHFGpdzRlEFmi23c01K+T9YwbQm5Ngo7x4hTrDfTyHC5eX8o1it+yFTLWbxzD53K F36Qzp21Kw13pe1yZzomG6DXecL976omikqAQJTqKNHbCaU4VhNNTxSpm6EM/Fwm67hEUmsq+lOUI BvGLqUpsJ2no4TiaGDhgLazmPAPdZeGMWsIigcaL1jr6yliPrhkrF4C7XH3seCsjrtMJuX26JKVAU GL55P026hCKW07iIkyzgh6f3iNyGRQIJRkJsBRqkpIa0pPPtM7v3rvXUH1Q6eOHUx/HHN1U8lGsae zXshs2FRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krjHS-0002qI-H3; Tue, 22 Dec 2020 15:08:54 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krjHN-0002pP-AM for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 15:08:50 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1krjHC-00DOur-V5; Tue, 22 Dec 2020 16:08:38 +0100 Date: Tue, 22 Dec 2020 16:08:38 +0100 From: Andrew Lunn To: Bjarni Jonasson Subject: Re: [RFC PATCH v2 4/8] net: sparx5: add port module support Message-ID: <20201222150838.GN3107610@lunn.ch> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-5-steen.hegelund@microchip.com> <20201220233543.GB3107610@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_100849_417711_62A54636 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Arnd Bergmann , Madalin Bucur , netdev@vger.kernel.org, Steen Hegelund , Russell King , Microchip Linux Driver Support , linux-arm-kernel@lists.infradead.org, Mark Einon , Jakub Kicinski , Masahiro Yamada , "David S. Miller" , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > +static int sparx5_port_verify_speed(struct sparx5 *sparx5, > > > + struct sparx5_port *port, > > > + struct sparx5_port_config *conf) > > > +{ > > > + case PHY_INTERFACE_MODE_SGMII: > > > + if (conf->speed != SPEED_1000 && > > > + conf->speed != SPEED_100 && > > > + conf->speed != SPEED_10 && > > > + conf->speed != SPEED_2500) > > > + return sparx5_port_error(port, conf, > > > SPX5_PERR_SPEED); > > > > Is it really SGMII over clocked at 2500? Or 2500BaseX? > > Yes the SGMII mode in the serdes driver is overclocked. > Nothing in the switch driver needs changing when changing between > speeds 1G/2G5. So it continues to use the SGMII inband signalling? There is a lot of confusion in this area, but SGMII inband signalling overclocked does not make much sense. So it is more likely to be using 2500BaseX. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel