From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9518C43381 for ; Wed, 23 Dec 2020 04:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7ABE020E65 for ; Wed, 23 Dec 2020 04:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbgLWEf4 (ORCPT ); Tue, 22 Dec 2020 23:35:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbgLWEfz (ORCPT ); Tue, 22 Dec 2020 23:35:55 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EA62C061257 for ; Tue, 22 Dec 2020 20:34:50 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id 15so9808646pgx.7 for ; Tue, 22 Dec 2020 20:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=OFVqi0FZly+cr6h2L4MgV3W+0bqGCFrv37DumbpBBHHWKR10mlk8j96RhehvYC0ZKZ A7gveeGO4wUPNnptPGhKrlG+oY9ETV8EggwWNNJcSxmSKnIhp4D6iv6jEddwltALPRsH XoYuBifhBdhegWVRfh980lFbJW3ZCSqNzWxi8omP37WhPmGjiRZ+cWui/1OKijohx3Ni VZ3o0KDN4OIc1fPJ6UYDAexLzU558i9zpREZpptiCrCuZwWp74C+otCB7ziEAp6JpBCe /0WINPCLg0o7wHc+WB03uTQnpOkKqeEM2Jo/o42Mju6zYgkhMy6UlsZnrI4SeRLP+Rxr M+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=EotiapozAYLzJBUdL3DMFzWpjtvkKEvVFtsKL0eDBDysbLWH3DMqI9t/qD4tWkArEQ pur2w6AFq8L5Gtcov/9UMAq7fqwDh+mna4iI0Wq/onoGHL2koQLomq907X/iAHd5MwdT vKXVikAFO36DjXvxtO+7uj43lrHw8D0jXrvwEDfJPkiPwOYqVUP9/e/OlJqoli79Dl/K MlHwQFHgXOBS85OUEWuJNZW9o+m73HiZk5X4g20z48mhu/MPMg8t0SuXcUCTOhhNKqbL t8aFpsxm8ohJYjpje5cPR6736ESWrdjoNWg+rkFftbDcAy4qx4zQ2DGzPF8gZFY0eXxg hR+g== X-Gm-Message-State: AOAM530ict4k07uMdgceB+/IUr5L9k+Io58VbyHihjD6bwJj69HeI8ch n/3Pgw36q1AnU5Qvz8G6sPDHKg== X-Google-Smtp-Source: ABdhPJy/6iEXMfinC0IgZ7fpt7I2g+zIxTjZQnxLRTk8cjqPdAagKq6g9nUKUea3gO9B/DZE0Q9zrw== X-Received: by 2002:a63:6305:: with SMTP id x5mr22354072pgb.216.1608698089700; Tue, 22 Dec 2020 20:34:49 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id p16sm21154516pju.47.2020.12.22.20.34.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 20:34:48 -0800 (PST) Date: Wed, 23 Dec 2020 10:04:43 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201223043443.rklw5er6hck3gl4y@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 22-12-20, 22:19, Dmitry Osipenko wrote: > 22.12.2020 12:12, Viresh Kumar пишет: > > On 17-12-20, 21:06, Dmitry Osipenko wrote: > >> Fix adding OPP entries in a wrong (opposite) order if OPP rate is > >> unavailable. The OPP comparison is erroneously skipped if OPP rate is > >> missing, thus OPPs are left unsorted. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/opp/core.c | 23 ++++++++++++----------- > >> drivers/opp/opp.h | 2 +- > >> 2 files changed, 13 insertions(+), 12 deletions(-) > >> > >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c > >> index 34f7e530d941..5c7f130a8de2 100644 > >> --- a/drivers/opp/core.c > >> +++ b/drivers/opp/core.c > >> @@ -1531,9 +1531,10 @@ static bool _opp_supported_by_regulators(struct dev_pm_opp *opp, > >> return true; > >> } > >> > >> -int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2) > >> +int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2, > >> + bool rate_not_available) > >> { > >> - if (opp1->rate != opp2->rate) > >> + if (!rate_not_available && opp1->rate != opp2->rate) > > > > rate will be 0 for both the OPPs here if rate_not_available is true and so this > > change shouldn't be required. > > The rate_not_available is negated in the condition. This change is > required because both rates are 0 and then we should proceed to the > levels comparison. Won't that happen without this patch ? > I guess it's not clear by looking at this patch, please see a full > version of the function: > > int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2, > bool rate_not_available) > { > if (!rate_not_available && opp1->rate != opp2->rate) > return opp1->rate < opp2->rate ? -1 : 1; > if (opp1->bandwidth && opp2->bandwidth && > opp1->bandwidth[0].peak != opp2->bandwidth[0].peak) > return opp1->bandwidth[0].peak < opp2->bandwidth[0].peak ? -1 : 1; > if (opp1->level != opp2->level) > return opp1->level < opp2->level ? -1 : 1; > return 0; > } > > Perhaps we could check whether opp1->rate=0, like it's done for the > opp1->bandwidth. I'll consider this variant for v3, thanks. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AC9C433DB for ; Wed, 23 Dec 2020 04:34:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32FC52151B for ; Wed, 23 Dec 2020 04:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32FC52151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BE22A87241; Wed, 23 Dec 2020 04:34:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0-CyFNaT8bQ; Wed, 23 Dec 2020 04:34:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id F1B1787244; Wed, 23 Dec 2020 04:34:51 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D24681BF349 for ; Wed, 23 Dec 2020 04:34:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C759185C9D for ; Wed, 23 Dec 2020 04:34:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KUi50NlE-S4a for ; Wed, 23 Dec 2020 04:34:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1CFAE85C95 for ; Wed, 23 Dec 2020 04:34:50 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id n7so9823145pgg.2 for ; Tue, 22 Dec 2020 20:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=OFVqi0FZly+cr6h2L4MgV3W+0bqGCFrv37DumbpBBHHWKR10mlk8j96RhehvYC0ZKZ A7gveeGO4wUPNnptPGhKrlG+oY9ETV8EggwWNNJcSxmSKnIhp4D6iv6jEddwltALPRsH XoYuBifhBdhegWVRfh980lFbJW3ZCSqNzWxi8omP37WhPmGjiRZ+cWui/1OKijohx3Ni VZ3o0KDN4OIc1fPJ6UYDAexLzU558i9zpREZpptiCrCuZwWp74C+otCB7ziEAp6JpBCe /0WINPCLg0o7wHc+WB03uTQnpOkKqeEM2Jo/o42Mju6zYgkhMy6UlsZnrI4SeRLP+Rxr M+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=Pw9WLDMHUv2kD5OAy7aLOgFLn7xCTK7Dy+D6qdkjeqYPbxNx5+uIQzM0hWTmnt09FG HiS/g3Dr0tl5chl4vVrpytAy5EsZ71MXr592DyzHBlhaJPeyAXNvP9rfi1Ln28teYeZ2 SGFTpN/lPtDxyVvNsbTaa7v+1K7yUnnDac5psZ6PTM/y27XFjS8LWLWdqcIiq4NCFGnf v0Js/vHt1e9fHBveArNPZe6/laFdCVnAqSwAIa2l7ec5Z1PTzrcgbKe0jaLm3X1FX/Pt RZba9K7cyxm8qXneOxfKnMtodPfMGAREDy7P5xos1bF1xye1NWosUncPfRv3fIZJmoW+ r4sg== X-Gm-Message-State: AOAM530c14HXSuBMR9BMq6aWzwDu2zOdnuOCRxLVDVZfuX0Yoo0v/jsC X1P2VqyVks4l1b1gEgcbXfhx7w== X-Google-Smtp-Source: ABdhPJy/6iEXMfinC0IgZ7fpt7I2g+zIxTjZQnxLRTk8cjqPdAagKq6g9nUKUea3gO9B/DZE0Q9zrw== X-Received: by 2002:a63:6305:: with SMTP id x5mr22354072pgb.216.1608698089700; Tue, 22 Dec 2020 20:34:49 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id p16sm21154516pju.47.2020.12.22.20.34.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 20:34:48 -0800 (PST) Date: Wed, 23 Dec 2020 10:04:43 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201223043443.rklw5er6hck3gl4y@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMjItMTItMjAsIDIyOjE5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjIuMTIuMjAyMCAx MjoxMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBPbiAxNy0xMi0yMCwgMjE6MDYsIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiBGaXggYWRkaW5nIE9QUCBlbnRyaWVzIGluIGEgd3Jv bmcgKG9wcG9zaXRlKSBvcmRlciBpZiBPUFAgcmF0ZSBpcwo+ID4+IHVuYXZhaWxhYmxlLiBUaGUg T1BQIGNvbXBhcmlzb24gaXMgZXJyb25lb3VzbHkgc2tpcHBlZCBpZiBPUFAgcmF0ZSBpcwo+ID4+ IG1pc3NpbmcsIHRodXMgT1BQcyBhcmUgbGVmdCB1bnNvcnRlZC4KPiA+Pgo+ID4+IFNpZ25lZC1v ZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+PiAtLS0KPiA+PiAg ZHJpdmVycy9vcHAvY29yZS5jIHwgMjMgKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+PiAgZHJp dmVycy9vcHAvb3BwLmggIHwgIDIgKy0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29w cC9jb3JlLmMgYi9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiBpbmRleCAzNGY3ZTUzMGQ5NDEuLjVj N2YxMzBhOGRlMiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiArKysg Yi9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiBAQCAtMTUzMSw5ICsxNTMxLDEwIEBAIHN0YXRpYyBi b29sIF9vcHBfc3VwcG9ydGVkX2J5X3JlZ3VsYXRvcnMoc3RydWN0IGRldl9wbV9vcHAgKm9wcCwK PiA+PiAgCXJldHVybiB0cnVlOwo+ID4+ICB9Cj4gPj4gIAo+ID4+IC1pbnQgX29wcF9jb21wYXJl X2tleShzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMSwgc3RydWN0IGRldl9wbV9vcHAgKm9wcDIpCj4g Pj4gK2ludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAxLCBzdHJ1Y3Qg ZGV2X3BtX29wcCAqb3BwMiwKPiA+PiArCQkgICAgIGJvb2wgcmF0ZV9ub3RfYXZhaWxhYmxlKQo+ ID4+ICB7Cj4gPj4gLQlpZiAob3BwMS0+cmF0ZSAhPSBvcHAyLT5yYXRlKQo+ID4+ICsJaWYgKCFy YXRlX25vdF9hdmFpbGFibGUgJiYgb3BwMS0+cmF0ZSAhPSBvcHAyLT5yYXRlKQo+ID4gCj4gPiBy YXRlIHdpbGwgYmUgMCBmb3IgYm90aCB0aGUgT1BQcyBoZXJlIGlmIHJhdGVfbm90X2F2YWlsYWJs ZSBpcyB0cnVlIGFuZCBzbyB0aGlzCj4gPiBjaGFuZ2Ugc2hvdWxkbid0IGJlIHJlcXVpcmVkLgo+ IAo+IFRoZSByYXRlX25vdF9hdmFpbGFibGUgaXMgbmVnYXRlZCBpbiB0aGUgY29uZGl0aW9uLiBU aGlzIGNoYW5nZSBpcwo+IHJlcXVpcmVkIGJlY2F1c2UgYm90aCByYXRlcyBhcmUgMCBhbmQgdGhl biB3ZSBzaG91bGQgcHJvY2VlZCB0byB0aGUKPiBsZXZlbHMgY29tcGFyaXNvbi4KCldvbid0IHRo YXQgaGFwcGVuIHdpdGhvdXQgdGhpcyBwYXRjaCA/Cgo+IEkgZ3Vlc3MgaXQncyBub3QgY2xlYXIg YnkgbG9va2luZyBhdCB0aGlzIHBhdGNoLCBwbGVhc2Ugc2VlIGEgZnVsbAo+IHZlcnNpb24gb2Yg dGhlIGZ1bmN0aW9uOgo+IAo+IGludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3Bw ICpvcHAxLCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMiwKPiAgICAgICAgICBib29sIHJhdGVfbm90 X2F2YWlsYWJsZSkKPiB7Cj4gICBpZiAoIXJhdGVfbm90X2F2YWlsYWJsZSAmJiBvcHAxLT5yYXRl ICE9IG9wcDItPnJhdGUpCj4gICAgIHJldHVybiBvcHAxLT5yYXRlIDwgb3BwMi0+cmF0ZSA/IC0x IDogMTsKPiAgIGlmIChvcHAxLT5iYW5kd2lkdGggJiYgb3BwMi0+YmFuZHdpZHRoICYmCj4gICAg ICAgb3BwMS0+YmFuZHdpZHRoWzBdLnBlYWsgIT0gb3BwMi0+YmFuZHdpZHRoWzBdLnBlYWspCj4g ICAgIHJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5w ZWFrID8gLTEgOiAxOwo+ICAgaWYgKG9wcDEtPmxldmVsICE9IG9wcDItPmxldmVsKQo+ICAgICBy ZXR1cm4gb3BwMS0+bGV2ZWwgPCBvcHAyLT5sZXZlbCA/IC0xIDogMTsKPiAgIHJldHVybiAwOwo+ IH0KPiAKPiBQZXJoYXBzIHdlIGNvdWxkIGNoZWNrIHdoZXRoZXIgb3BwMS0+cmF0ZT0wLCBsaWtl IGl0J3MgZG9uZSBmb3IgdGhlCj4gb3BwMS0+YmFuZHdpZHRoLiBJJ2xsIGNvbnNpZGVyIHRoaXMg dmFyaWFudCBmb3IgdjMsIHRoYW5rcy4KCi0tIAp2aXJlc2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4 ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1290C433E6 for ; Wed, 23 Dec 2020 10:52:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A53A6207F7 for ; Wed, 23 Dec 2020 10:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A53A6207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B442C6E8DD; Wed, 23 Dec 2020 10:52:02 +0000 (UTC) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2106C89BFF for ; Wed, 23 Dec 2020 04:34:50 +0000 (UTC) Received: by mail-pg1-x533.google.com with SMTP id n25so4306178pgb.0 for ; Tue, 22 Dec 2020 20:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=OFVqi0FZly+cr6h2L4MgV3W+0bqGCFrv37DumbpBBHHWKR10mlk8j96RhehvYC0ZKZ A7gveeGO4wUPNnptPGhKrlG+oY9ETV8EggwWNNJcSxmSKnIhp4D6iv6jEddwltALPRsH XoYuBifhBdhegWVRfh980lFbJW3ZCSqNzWxi8omP37WhPmGjiRZ+cWui/1OKijohx3Ni VZ3o0KDN4OIc1fPJ6UYDAexLzU558i9zpREZpptiCrCuZwWp74C+otCB7ziEAp6JpBCe /0WINPCLg0o7wHc+WB03uTQnpOkKqeEM2Jo/o42Mju6zYgkhMy6UlsZnrI4SeRLP+Rxr M+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=n/wQ/8FF3ZQQmDW8wRJInIGGffY6h+3NeQmSLgJVsG0=; b=mjRyCmKaTFq/GNjzJ9DNODGNYbxBsHANsOML3QNaNNvTFA0H6dBXuOS4fWqeYYf3Tp z9JtNoJv/VdcDNO76JSLfc8UN/EhrN7xRkItNOK4NUu0lA0D2vEe8bcTTBRv2XR4GIaG Dp5i0O600KQnSmM9FsMROFm8Hq+yVAVBayjY9T+SB9xdPnRkPz4IIA+VvvM7yB/NGO2l 6U8vADWIvzqH+jNhLHtmoSNxUqHI+2tyXwggzHmMI4Et/1EVPsgVq3ZKwzi2COZZhxvM l2mNEh4brGpdc8qdY01EP/TKvJ/o/Q+hjRlcHQcD/QqwCRhIw0DuxbG45whEKcMpiZWf di+w== X-Gm-Message-State: AOAM531TmG4lTAELhrboMJalMfL/RnXnRy16egUJCMpx1gVQewxoE17u oSLCJxkcQNNb6mFMk40ViaQ+Ig== X-Google-Smtp-Source: ABdhPJy/6iEXMfinC0IgZ7fpt7I2g+zIxTjZQnxLRTk8cjqPdAagKq6g9nUKUea3gO9B/DZE0Q9zrw== X-Received: by 2002:a63:6305:: with SMTP id x5mr22354072pgb.216.1608698089700; Tue, 22 Dec 2020 20:34:49 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id p16sm21154516pju.47.2020.12.22.20.34.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 20:34:48 -0800 (PST) Date: Wed, 23 Dec 2020 10:04:43 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201223043443.rklw5er6hck3gl4y@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Wed, 23 Dec 2020 10:51:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjItMTItMjAsIDIyOjE5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjIuMTIuMjAyMCAx MjoxMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBPbiAxNy0xMi0yMCwgMjE6MDYsIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiBGaXggYWRkaW5nIE9QUCBlbnRyaWVzIGluIGEgd3Jv bmcgKG9wcG9zaXRlKSBvcmRlciBpZiBPUFAgcmF0ZSBpcwo+ID4+IHVuYXZhaWxhYmxlLiBUaGUg T1BQIGNvbXBhcmlzb24gaXMgZXJyb25lb3VzbHkgc2tpcHBlZCBpZiBPUFAgcmF0ZSBpcwo+ID4+ IG1pc3NpbmcsIHRodXMgT1BQcyBhcmUgbGVmdCB1bnNvcnRlZC4KPiA+Pgo+ID4+IFNpZ25lZC1v ZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+PiAtLS0KPiA+PiAg ZHJpdmVycy9vcHAvY29yZS5jIHwgMjMgKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+PiAgZHJp dmVycy9vcHAvb3BwLmggIHwgIDIgKy0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29w cC9jb3JlLmMgYi9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiBpbmRleCAzNGY3ZTUzMGQ5NDEuLjVj N2YxMzBhOGRlMiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiArKysg Yi9kcml2ZXJzL29wcC9jb3JlLmMKPiA+PiBAQCAtMTUzMSw5ICsxNTMxLDEwIEBAIHN0YXRpYyBi b29sIF9vcHBfc3VwcG9ydGVkX2J5X3JlZ3VsYXRvcnMoc3RydWN0IGRldl9wbV9vcHAgKm9wcCwK PiA+PiAgCXJldHVybiB0cnVlOwo+ID4+ICB9Cj4gPj4gIAo+ID4+IC1pbnQgX29wcF9jb21wYXJl X2tleShzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMSwgc3RydWN0IGRldl9wbV9vcHAgKm9wcDIpCj4g Pj4gK2ludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAxLCBzdHJ1Y3Qg ZGV2X3BtX29wcCAqb3BwMiwKPiA+PiArCQkgICAgIGJvb2wgcmF0ZV9ub3RfYXZhaWxhYmxlKQo+ ID4+ICB7Cj4gPj4gLQlpZiAob3BwMS0+cmF0ZSAhPSBvcHAyLT5yYXRlKQo+ID4+ICsJaWYgKCFy YXRlX25vdF9hdmFpbGFibGUgJiYgb3BwMS0+cmF0ZSAhPSBvcHAyLT5yYXRlKQo+ID4gCj4gPiBy YXRlIHdpbGwgYmUgMCBmb3IgYm90aCB0aGUgT1BQcyBoZXJlIGlmIHJhdGVfbm90X2F2YWlsYWJs ZSBpcyB0cnVlIGFuZCBzbyB0aGlzCj4gPiBjaGFuZ2Ugc2hvdWxkbid0IGJlIHJlcXVpcmVkLgo+ IAo+IFRoZSByYXRlX25vdF9hdmFpbGFibGUgaXMgbmVnYXRlZCBpbiB0aGUgY29uZGl0aW9uLiBU aGlzIGNoYW5nZSBpcwo+IHJlcXVpcmVkIGJlY2F1c2UgYm90aCByYXRlcyBhcmUgMCBhbmQgdGhl biB3ZSBzaG91bGQgcHJvY2VlZCB0byB0aGUKPiBsZXZlbHMgY29tcGFyaXNvbi4KCldvbid0IHRo YXQgaGFwcGVuIHdpdGhvdXQgdGhpcyBwYXRjaCA/Cgo+IEkgZ3Vlc3MgaXQncyBub3QgY2xlYXIg YnkgbG9va2luZyBhdCB0aGlzIHBhdGNoLCBwbGVhc2Ugc2VlIGEgZnVsbAo+IHZlcnNpb24gb2Yg dGhlIGZ1bmN0aW9uOgo+IAo+IGludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3Bw ICpvcHAxLCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMiwKPiAgICAgICAgICBib29sIHJhdGVfbm90 X2F2YWlsYWJsZSkKPiB7Cj4gICBpZiAoIXJhdGVfbm90X2F2YWlsYWJsZSAmJiBvcHAxLT5yYXRl ICE9IG9wcDItPnJhdGUpCj4gICAgIHJldHVybiBvcHAxLT5yYXRlIDwgb3BwMi0+cmF0ZSA/IC0x IDogMTsKPiAgIGlmIChvcHAxLT5iYW5kd2lkdGggJiYgb3BwMi0+YmFuZHdpZHRoICYmCj4gICAg ICAgb3BwMS0+YmFuZHdpZHRoWzBdLnBlYWsgIT0gb3BwMi0+YmFuZHdpZHRoWzBdLnBlYWspCj4g ICAgIHJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5w ZWFrID8gLTEgOiAxOwo+ICAgaWYgKG9wcDEtPmxldmVsICE9IG9wcDItPmxldmVsKQo+ICAgICBy ZXR1cm4gb3BwMS0+bGV2ZWwgPCBvcHAyLT5sZXZlbCA/IC0xIDogMTsKPiAgIHJldHVybiAwOwo+ IH0KPiAKPiBQZXJoYXBzIHdlIGNvdWxkIGNoZWNrIHdoZXRoZXIgb3BwMS0+cmF0ZT0wLCBsaWtl IGl0J3MgZG9uZSBmb3IgdGhlCj4gb3BwMS0+YmFuZHdpZHRoLiBJJ2xsIGNvbnNpZGVyIHRoaXMg dmFyaWFudCBmb3IgdjMsIHRoYW5rcy4KCi0tIAp2aXJlc2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==