From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B585C433E9 for ; Wed, 23 Dec 2020 05:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E492022571 for ; Wed, 23 Dec 2020 05:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727042AbgLWF6A (ORCPT ); Wed, 23 Dec 2020 00:58:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbgLWF57 (ORCPT ); Wed, 23 Dec 2020 00:57:59 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5795FC061794 for ; Tue, 22 Dec 2020 21:57:19 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id be12so8599044plb.4 for ; Tue, 22 Dec 2020 21:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=W5YJc6EiiWk23cUCGsgoEZThjaHKBFlEG4O2cgRcXu+x5+1ODHw6d3bAyttpAh4Npy yhDhQA4+L+oz4wy8QflysfNhX4OfzqA0qNs/SHpKza5WXKgrPbKjAZqXsxt3M6+5uj5+ VPzhmEJIKzlbozEEPWm1XL8KIXiyyOKO2HmVu9XxWuzA1/dlfxbwhMlk6o4r2lNa/tYB koUJs3PACOOeP10gRbtLplfNUPU/AAwjZHrgwyo0byxhHtSGWR9eYNFuLyVygLLz+QCX 6yGQiSn1spMfKd1SRklgKWo8kYn0YWbHteDUGgx/252nlqC2vuCSM8Grhs1IDDtLRYP5 ah0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=pC2BMzuomvNTgCdmAllmjZ9Nt0EWdRy2qefj/39x0kD0hciqn+LN77jiLJnOcRUEGC dffLDROf1MMo6VylwvdFJSfOKEC9osEdVcjbTiI5yKb19KiQk8TaW+TGPrTS5H2BGa2T yanjEMJiYqUxDzVMPyPv6HfxK4yEBQRRGcvuZ3NdnqERmCLnUppLZc4B8NPiusWcmeKi G/yS/omEoCpV9BEYlG/DZNVC9ex4rjy+GzxRln+5BBQX/shV8AiEo1ObyEo5mWlhObq4 i1Rb+wgr/HCbL4CE9/DTmpYRgvqxfxuZSZZao130Sdc2oKwIYSIk9z1+Tji2JZiuIE9N nk/g== X-Gm-Message-State: AOAM5322PYMKRg9QWLutpgs11KfZwwbVq56YK1oMWkXDBbfkpg2PwcqL 0zcsGd5ENKgfoXbgB3VHcyVn1w== X-Google-Smtp-Source: ABdhPJwsLgoGssujAxswnWOsu8NXhLnCPjFpMxnGOCgLNcgnd+pdiKB2jV1BoCNGdPUko3cGZpeLtQ== X-Received: by 2002:a17:90a:cb84:: with SMTP id a4mr25789987pju.50.1608703038680; Tue, 22 Dec 2020 21:57:18 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id w7sm22839140pgr.48.2020.12.22.21.57.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 21:57:17 -0800 (PST) Date: Wed, 23 Dec 2020 11:27:15 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver Message-ID: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 22-12-20, 22:39, Dmitry Osipenko wrote: > 22.12.2020 22:21, Dmitry Osipenko пишет: > >>> + if (IS_ERR(opp)) { > >>> + dev_err(&genpd->dev, "failed to find OPP for level %u: %pe\n", > >>> + level, opp); > >>> + return PTR_ERR(opp); > >>> + } > >>> + > >>> + err = dev_pm_opp_set_voltage(&genpd->dev, opp); > >> IIUC, you implemented this callback because you want to use the voltage triplet > >> present in the OPP table ? > >> > >> And so you are setting the regulator ("power") later in this patch ? > > yes > > > >> I am not in favor of implementing this routine, as it just adds a wrapper above > >> the regulator API. What you should be doing rather is get the regulator by > >> yourself here (instead of depending on the OPP core). And then you can do > >> dev_pm_opp_get_voltage() here and set the voltage yourself. You may want to > >> implement a version supporting triplet here though for the same. > >> > >> And you won't require the sync version of the API as well then. > >> > > That's what I initially did for this driver. I don't mind to revert back > > to the initial variant in v3, it appeared to me that it will be nicer > > and cleaner to have OPP API managing everything here. > > I forgot one important detail (why the initial variant wasn't good).. > OPP entries that have unsupportable voltages should be filtered out and > OPP core performs the filtering only if regulator is assigned to the OPP > table. > > If regulator is assigned to the OPP table, then we need to use OPP API > for driving the regulator, hence that's why I added > dev_pm_opp_sync_regulators() and dev_pm_opp_set_voltage(). > > Perhaps it should be possible to add dev_pm_opp_get_regulator() that What's wrong with getting the regulator in the driver as well ? Apart from the OPP core ? > will return the OPP table regulator in order to allow driver to use the > regulator directly. But I'm not sure whether this is a much better > option than the opp_sync_regulators() and opp_set_voltage() APIs. set_voltage() is still fine as there is some data that the OPP core has, but sync_regulator() has nothing to do with OPP core. And this may lead to more wrapper helpers in the OPP core, which I am afraid of. And so even if it is not the best, I would like the OPP core to provide the data and not get into this. Ofcourse there is an exception to this, opp_set_rate. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8587C433E0 for ; Wed, 23 Dec 2020 05:57:24 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80CAF22512 for ; Wed, 23 Dec 2020 05:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80CAF22512 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1A3DC1FCB5; Wed, 23 Dec 2020 05:57:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uRgw85qXSwrE; Wed, 23 Dec 2020 05:57:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 1018A20012; Wed, 23 Dec 2020 05:57:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BAF531BF41B for ; Wed, 23 Dec 2020 05:57:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A5F8B20012 for ; Wed, 23 Dec 2020 05:57:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WhgsK7mHnboj for ; Wed, 23 Dec 2020 05:57:19 +0000 (UTC) X-Greylist: delayed 01:35:13 by SQLgrey-1.7.6 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by silver.osuosl.org (Postfix) with ESMTPS id 3558F1FCB5 for ; Wed, 23 Dec 2020 05:57:19 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id hk16so2606226pjb.4 for ; Tue, 22 Dec 2020 21:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=W5YJc6EiiWk23cUCGsgoEZThjaHKBFlEG4O2cgRcXu+x5+1ODHw6d3bAyttpAh4Npy yhDhQA4+L+oz4wy8QflysfNhX4OfzqA0qNs/SHpKza5WXKgrPbKjAZqXsxt3M6+5uj5+ VPzhmEJIKzlbozEEPWm1XL8KIXiyyOKO2HmVu9XxWuzA1/dlfxbwhMlk6o4r2lNa/tYB koUJs3PACOOeP10gRbtLplfNUPU/AAwjZHrgwyo0byxhHtSGWR9eYNFuLyVygLLz+QCX 6yGQiSn1spMfKd1SRklgKWo8kYn0YWbHteDUGgx/252nlqC2vuCSM8Grhs1IDDtLRYP5 ah0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=mYjyJNAY05Y5gieAtgNcsg4ZCpGHceJhUSgFQn9V0FbjgAsCSB+YwDrrUfq255lov9 pXrCMGPpJKcrsjvoi+lNNxpPhac2ofM6/CGoS8hm+F3eXUro9C1JoK/XMzo5XBtWvEoU 2jNtn88YGCIGBFDIj7/BGh5cfcEBkAsZNby9lAAzGiEkF/lH9FXeznlp7pOlYWyDyfYl tMwNo14iUwWZjg2F3f+PlRaeySjNOSu8hk3Xk1PbyliGN7hf/gyXce+vOPDFmLz4yvhB orG8fxgtfjT8s8Zrwwe7yYd69SYAXEJNV+4H+wX8c3wM/2AX9fAIvK28acemqPk7RU8E LisA== X-Gm-Message-State: AOAM530q+PgPafqn38/vnSPEr9h1kO6l0UmtixPTvMzYGSCpyBp0Eevo h1Hhlzw9DWzXsKp8yoaZdz8ozA== X-Google-Smtp-Source: ABdhPJwsLgoGssujAxswnWOsu8NXhLnCPjFpMxnGOCgLNcgnd+pdiKB2jV1BoCNGdPUko3cGZpeLtQ== X-Received: by 2002:a17:90a:cb84:: with SMTP id a4mr25789987pju.50.1608703038680; Tue, 22 Dec 2020 21:57:18 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id w7sm22839140pgr.48.2020.12.22.21.57.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 21:57:17 -0800 (PST) Date: Wed, 23 Dec 2020 11:27:15 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver Message-ID: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMjItMTItMjAsIDIyOjM5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjIuMTIuMjAyMCAy MjoyMSwgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gPj4+ICsJaWYgKElTX0VSUihvcHAp KSB7Cj4gPj4+ICsJCWRldl9lcnIoJmdlbnBkLT5kZXYsICJmYWlsZWQgdG8gZmluZCBPUFAgZm9y IGxldmVsICV1OiAlcGVcbiIsCj4gPj4+ICsJCQlsZXZlbCwgb3BwKTsKPiA+Pj4gKwkJcmV0dXJu IFBUUl9FUlIob3BwKTsKPiA+Pj4gKwl9Cj4gPj4+ICsKPiA+Pj4gKwllcnIgPSBkZXZfcG1fb3Bw X3NldF92b2x0YWdlKCZnZW5wZC0+ZGV2LCBvcHApOwo+ID4+IElJVUMsIHlvdSBpbXBsZW1lbnRl ZCB0aGlzIGNhbGxiYWNrIGJlY2F1c2UgeW91IHdhbnQgdG8gdXNlIHRoZSB2b2x0YWdlIHRyaXBs ZXQKPiA+PiBwcmVzZW50IGluIHRoZSBPUFAgdGFibGUgPwo+ID4+Cj4gPj4gQW5kIHNvIHlvdSBh cmUgc2V0dGluZyB0aGUgcmVndWxhdG9yICgicG93ZXIiKSBsYXRlciBpbiB0aGlzIHBhdGNoID8K PiA+IHllcwo+ID4gCj4gPj4gSSBhbSBub3QgaW4gZmF2b3Igb2YgaW1wbGVtZW50aW5nIHRoaXMg cm91dGluZSwgYXMgaXQganVzdCBhZGRzIGEgd3JhcHBlciBhYm92ZQo+ID4+IHRoZSByZWd1bGF0 b3IgQVBJLiBXaGF0IHlvdSBzaG91bGQgYmUgZG9pbmcgcmF0aGVyIGlzIGdldCB0aGUgcmVndWxh dG9yIGJ5Cj4gPj4geW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9Q UCBjb3JlKS4gQW5kIHRoZW4geW91IGNhbiBkbwo+ID4+IGRldl9wbV9vcHBfZ2V0X3ZvbHRhZ2Uo KSBoZXJlIGFuZCBzZXQgdGhlIHZvbHRhZ2UgeW91cnNlbGYuIFlvdSBtYXkgd2FudCB0bwo+ID4+ IGltcGxlbWVudCBhIHZlcnNpb24gc3VwcG9ydGluZyB0cmlwbGV0IGhlcmUgdGhvdWdoIGZvciB0 aGUgc2FtZS4KPiA+Pgo+ID4+IEFuZCB5b3Ugd29uJ3QgcmVxdWlyZSB0aGUgc3luYyB2ZXJzaW9u IG9mIHRoZSBBUEkgYXMgd2VsbCB0aGVuLgo+ID4+Cj4gPiBUaGF0J3Mgd2hhdCBJIGluaXRpYWxs eSBkaWQgZm9yIHRoaXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPiA+IHRv IHRoZSBpbml0aWFsIHZhcmlhbnQgaW4gdjMsIGl0IGFwcGVhcmVkIHRvIG1lIHRoYXQgaXQgd2ls bCBiZSBuaWNlcgo+ID4gYW5kIGNsZWFuZXIgdG8gaGF2ZSBPUFAgQVBJIG1hbmFnaW5nIGV2ZXJ5 dGhpbmcgaGVyZS4KPiAKPiBJIGZvcmdvdCBvbmUgaW1wb3J0YW50IGRldGFpbCAod2h5IHRoZSBp bml0aWFsIHZhcmlhbnQgd2Fzbid0IGdvb2QpLi4KPiBPUFAgZW50cmllcyB0aGF0IGhhdmUgdW5z dXBwb3J0YWJsZSB2b2x0YWdlcyBzaG91bGQgYmUgZmlsdGVyZWQgb3V0IGFuZAo+IE9QUCBjb3Jl IHBlcmZvcm1zIHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMgYXNzaWduZWQgdG8g dGhlIE9QUAo+IHRhYmxlLgo+IAo+IElmIHJlZ3VsYXRvciBpcyBhc3NpZ25lZCB0byB0aGUgT1BQ IHRhYmxlLCB0aGVuIHdlIG5lZWQgdG8gdXNlIE9QUCBBUEkKPiBmb3IgZHJpdmluZyB0aGUgcmVn dWxhdG9yLCBoZW5jZSB0aGF0J3Mgd2h5IEkgYWRkZWQKPiBkZXZfcG1fb3BwX3N5bmNfcmVndWxh dG9ycygpIGFuZCBkZXZfcG1fb3BwX3NldF92b2x0YWdlKCkuCj4gCj4gUGVyaGFwcyBpdCBzaG91 bGQgYmUgcG9zc2libGUgdG8gYWRkIGRldl9wbV9vcHBfZ2V0X3JlZ3VsYXRvcigpIHRoYXQKCldo YXQncyB3cm9uZyB3aXRoIGdldHRpbmcgdGhlIHJlZ3VsYXRvciBpbiB0aGUgZHJpdmVyIGFzIHdl bGwgPyBBcGFydCBmcm9tIHRoZQpPUFAgY29yZSA/Cgo+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFi bGUgcmVndWxhdG9yIGluIG9yZGVyIHRvIGFsbG93IGRyaXZlciB0byB1c2UgdGhlCj4gcmVndWxh dG9yIGRpcmVjdGx5LiBCdXQgSSdtIG5vdCBzdXJlIHdoZXRoZXIgdGhpcyBpcyBhIG11Y2ggYmV0 dGVyCj4gb3B0aW9uIHRoYW4gdGhlIG9wcF9zeW5jX3JlZ3VsYXRvcnMoKSBhbmQgb3BwX3NldF92 b2x0YWdlKCkgQVBJcy4KCnNldF92b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBz b21lIGRhdGEgdGhhdCB0aGUgT1BQIGNvcmUgaGFzLCBidXQKc3luY19yZWd1bGF0b3IoKSBoYXMg bm90aGluZyB0byBkbyB3aXRoIE9QUCBjb3JlLgoKQW5kIHRoaXMgbWF5IGxlYWQgdG8gbW9yZSB3 cmFwcGVyIGhlbHBlcnMgaW4gdGhlIE9QUCBjb3JlLCB3aGljaCBJIGFtIGFmcmFpZCBvZi4KQW5k IHNvIGV2ZW4gaWYgaXQgaXMgbm90IHRoZSBiZXN0LCBJIHdvdWxkIGxpa2UgdGhlIE9QUCBjb3Jl IHRvIHByb3ZpZGUgdGhlIGRhdGEKYW5kIG5vdCBnZXQgaW50byB0aGlzLiBPZmNvdXJzZSB0aGVy ZSBpcyBhbiBleGNlcHRpb24gdG8gdGhpcywgb3BwX3NldF9yYXRlLgoKLS0gCnZpcmVzaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5n IGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4 ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72155C433E6 for ; Wed, 23 Dec 2020 10:52:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C55C207F7 for ; Wed, 23 Dec 2020 10:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C55C207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86BC06E8FB; Wed, 23 Dec 2020 10:51:35 +0000 (UTC) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19E376E8C6 for ; Wed, 23 Dec 2020 05:57:19 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id b5so2609938pjk.2 for ; Tue, 22 Dec 2020 21:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=W5YJc6EiiWk23cUCGsgoEZThjaHKBFlEG4O2cgRcXu+x5+1ODHw6d3bAyttpAh4Npy yhDhQA4+L+oz4wy8QflysfNhX4OfzqA0qNs/SHpKza5WXKgrPbKjAZqXsxt3M6+5uj5+ VPzhmEJIKzlbozEEPWm1XL8KIXiyyOKO2HmVu9XxWuzA1/dlfxbwhMlk6o4r2lNa/tYB koUJs3PACOOeP10gRbtLplfNUPU/AAwjZHrgwyo0byxhHtSGWR9eYNFuLyVygLLz+QCX 6yGQiSn1spMfKd1SRklgKWo8kYn0YWbHteDUGgx/252nlqC2vuCSM8Grhs1IDDtLRYP5 ah0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lJW5Pmu0e9Bh/oQqoiiF+Gb9g3MgQRYVOM3hqkPUzNs=; b=jy9Gg1Pgv0wlC0p7Y81M13a64tjgTDfFmKMEpviv197I1yVYb1Z0bmiD1Lzg3/ZQsH /yAKNkAPqhCgzW7eYbhiJc1lHxLh5SD4Qx/c5i9+EPq7rIu3D5rk92lmGzCUUEoMWAqi 5dm77UHxG5Pt5mS3SJ9EC7sm1lDcqi8NJsSwKy8omOpokxt+udRjm7x978ejCA83FzRw iU6tt/91kxG1FH/lQv+4rH6jCnx6OTeaRf1dUx3cGjGHXoc7eZ0wKEPiwwFlAzIs13zH WDrJfrnoxkbUiLFHjcUo6IzMYI1zii3ZT+pim2GGVKJtsz8Qku34HFJGv9iXvYELf/AS 6DCA== X-Gm-Message-State: AOAM533T+OLvoUGkyjjDC6UbTjOmhORIK2SXK8berFOf9XC2EW8h3LdI 40bpzYvXmOVeXC+637Gi2s5McWiGwBYbzA== X-Google-Smtp-Source: ABdhPJwsLgoGssujAxswnWOsu8NXhLnCPjFpMxnGOCgLNcgnd+pdiKB2jV1BoCNGdPUko3cGZpeLtQ== X-Received: by 2002:a17:90a:cb84:: with SMTP id a4mr25789987pju.50.1608703038680; Tue, 22 Dec 2020 21:57:18 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id w7sm22839140pgr.48.2020.12.22.21.57.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 21:57:17 -0800 (PST) Date: Wed, 23 Dec 2020 11:27:15 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver Message-ID: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Wed, 23 Dec 2020 10:51:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjItMTItMjAsIDIyOjM5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjIuMTIuMjAyMCAy MjoyMSwgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4gPj4+ICsJaWYgKElTX0VSUihvcHAp KSB7Cj4gPj4+ICsJCWRldl9lcnIoJmdlbnBkLT5kZXYsICJmYWlsZWQgdG8gZmluZCBPUFAgZm9y IGxldmVsICV1OiAlcGVcbiIsCj4gPj4+ICsJCQlsZXZlbCwgb3BwKTsKPiA+Pj4gKwkJcmV0dXJu IFBUUl9FUlIob3BwKTsKPiA+Pj4gKwl9Cj4gPj4+ICsKPiA+Pj4gKwllcnIgPSBkZXZfcG1fb3Bw X3NldF92b2x0YWdlKCZnZW5wZC0+ZGV2LCBvcHApOwo+ID4+IElJVUMsIHlvdSBpbXBsZW1lbnRl ZCB0aGlzIGNhbGxiYWNrIGJlY2F1c2UgeW91IHdhbnQgdG8gdXNlIHRoZSB2b2x0YWdlIHRyaXBs ZXQKPiA+PiBwcmVzZW50IGluIHRoZSBPUFAgdGFibGUgPwo+ID4+Cj4gPj4gQW5kIHNvIHlvdSBh cmUgc2V0dGluZyB0aGUgcmVndWxhdG9yICgicG93ZXIiKSBsYXRlciBpbiB0aGlzIHBhdGNoID8K PiA+IHllcwo+ID4gCj4gPj4gSSBhbSBub3QgaW4gZmF2b3Igb2YgaW1wbGVtZW50aW5nIHRoaXMg cm91dGluZSwgYXMgaXQganVzdCBhZGRzIGEgd3JhcHBlciBhYm92ZQo+ID4+IHRoZSByZWd1bGF0 b3IgQVBJLiBXaGF0IHlvdSBzaG91bGQgYmUgZG9pbmcgcmF0aGVyIGlzIGdldCB0aGUgcmVndWxh dG9yIGJ5Cj4gPj4geW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9Q UCBjb3JlKS4gQW5kIHRoZW4geW91IGNhbiBkbwo+ID4+IGRldl9wbV9vcHBfZ2V0X3ZvbHRhZ2Uo KSBoZXJlIGFuZCBzZXQgdGhlIHZvbHRhZ2UgeW91cnNlbGYuIFlvdSBtYXkgd2FudCB0bwo+ID4+ IGltcGxlbWVudCBhIHZlcnNpb24gc3VwcG9ydGluZyB0cmlwbGV0IGhlcmUgdGhvdWdoIGZvciB0 aGUgc2FtZS4KPiA+Pgo+ID4+IEFuZCB5b3Ugd29uJ3QgcmVxdWlyZSB0aGUgc3luYyB2ZXJzaW9u IG9mIHRoZSBBUEkgYXMgd2VsbCB0aGVuLgo+ID4+Cj4gPiBUaGF0J3Mgd2hhdCBJIGluaXRpYWxs eSBkaWQgZm9yIHRoaXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPiA+IHRv IHRoZSBpbml0aWFsIHZhcmlhbnQgaW4gdjMsIGl0IGFwcGVhcmVkIHRvIG1lIHRoYXQgaXQgd2ls bCBiZSBuaWNlcgo+ID4gYW5kIGNsZWFuZXIgdG8gaGF2ZSBPUFAgQVBJIG1hbmFnaW5nIGV2ZXJ5 dGhpbmcgaGVyZS4KPiAKPiBJIGZvcmdvdCBvbmUgaW1wb3J0YW50IGRldGFpbCAod2h5IHRoZSBp bml0aWFsIHZhcmlhbnQgd2Fzbid0IGdvb2QpLi4KPiBPUFAgZW50cmllcyB0aGF0IGhhdmUgdW5z dXBwb3J0YWJsZSB2b2x0YWdlcyBzaG91bGQgYmUgZmlsdGVyZWQgb3V0IGFuZAo+IE9QUCBjb3Jl IHBlcmZvcm1zIHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMgYXNzaWduZWQgdG8g dGhlIE9QUAo+IHRhYmxlLgo+IAo+IElmIHJlZ3VsYXRvciBpcyBhc3NpZ25lZCB0byB0aGUgT1BQ IHRhYmxlLCB0aGVuIHdlIG5lZWQgdG8gdXNlIE9QUCBBUEkKPiBmb3IgZHJpdmluZyB0aGUgcmVn dWxhdG9yLCBoZW5jZSB0aGF0J3Mgd2h5IEkgYWRkZWQKPiBkZXZfcG1fb3BwX3N5bmNfcmVndWxh dG9ycygpIGFuZCBkZXZfcG1fb3BwX3NldF92b2x0YWdlKCkuCj4gCj4gUGVyaGFwcyBpdCBzaG91 bGQgYmUgcG9zc2libGUgdG8gYWRkIGRldl9wbV9vcHBfZ2V0X3JlZ3VsYXRvcigpIHRoYXQKCldo YXQncyB3cm9uZyB3aXRoIGdldHRpbmcgdGhlIHJlZ3VsYXRvciBpbiB0aGUgZHJpdmVyIGFzIHdl bGwgPyBBcGFydCBmcm9tIHRoZQpPUFAgY29yZSA/Cgo+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFi bGUgcmVndWxhdG9yIGluIG9yZGVyIHRvIGFsbG93IGRyaXZlciB0byB1c2UgdGhlCj4gcmVndWxh dG9yIGRpcmVjdGx5LiBCdXQgSSdtIG5vdCBzdXJlIHdoZXRoZXIgdGhpcyBpcyBhIG11Y2ggYmV0 dGVyCj4gb3B0aW9uIHRoYW4gdGhlIG9wcF9zeW5jX3JlZ3VsYXRvcnMoKSBhbmQgb3BwX3NldF92 b2x0YWdlKCkgQVBJcy4KCnNldF92b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBz b21lIGRhdGEgdGhhdCB0aGUgT1BQIGNvcmUgaGFzLCBidXQKc3luY19yZWd1bGF0b3IoKSBoYXMg bm90aGluZyB0byBkbyB3aXRoIE9QUCBjb3JlLgoKQW5kIHRoaXMgbWF5IGxlYWQgdG8gbW9yZSB3 cmFwcGVyIGhlbHBlcnMgaW4gdGhlIE9QUCBjb3JlLCB3aGljaCBJIGFtIGFmcmFpZCBvZi4KQW5k IHNvIGV2ZW4gaWYgaXQgaXMgbm90IHRoZSBiZXN0LCBJIHdvdWxkIGxpa2UgdGhlIE9QUCBjb3Jl IHRvIHByb3ZpZGUgdGhlIGRhdGEKYW5kIG5vdCBnZXQgaW50byB0aGlzLiBPZmNvdXJzZSB0aGVy ZSBpcyBhbiBleGNlcHRpb24gdG8gdGhpcywgb3BwX3NldF9yYXRlLgoKLS0gCnZpcmVzaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK