From: Richard Palethorpe <rpalethorpe@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] af_alg07: Add linux-git reference to more general fix
Date: Wed, 23 Dec 2020 11:36:36 +0000 [thread overview]
Message-ID: <20201223113636.9617-1-rpalethorpe@suse.com> (raw)
While trying to reintroduce this error on kernel 5.10 I found that a
secondary fix has been applied which fixes many more socket types and
may obsolete the original fix. Ideally we would create a new test
based on Eric's reproducer, but for now I will just include a
reference to the second fix.
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Cc: Martin Doucha <mdoucha@suse.cz>
---
testcases/kernel/crypto/af_alg07.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/crypto/af_alg07.c b/testcases/kernel/crypto/af_alg07.c
index c94bb292f..ef13ad764 100644
--- a/testcases/kernel/crypto/af_alg07.c
+++ b/testcases/kernel/crypto/af_alg07.c
@@ -15,13 +15,22 @@
*
* The race window is small and it's hard to trigger a kernel crash but
* fchownat() will return ENOENT as it should only when the bug is not
- * present. Race fixed in:
+ * present. Race fixed specifically for af_alg in:
*
* commit 9060cb719e61b685ec0102574e10337fa5f445ea
* Author: Mao Wenan <maowenan@huawei.com>
* Date: Mon Feb 18 10:44:44 2019 +0800
*
* net: crypto set sk to NULL when af_alg_release.
+ *
+ * It was observed that the same bug is present on many other
+ * protocols. A more general fix is in:
+ *
+ * commit ff7b11aa481f682e0e9711abfeb7d03f5cd612bf
+ * Author: Eric Biggers <ebiggers@google.com>
+ * Date: Thu Feb 21 14:13:56 2019 -0800
+ *
+ * net: socket: set sock->sk to NULL after calling proto_ops::release()
*/
#include <sys/types.h>
@@ -118,6 +127,7 @@ static struct tst_test test = {
.min_cpus = 2,
.taint_check = TST_TAINT_W | TST_TAINT_D,
.tags = (const struct tst_tag[]) {
+ {"linux-git", "ff7b11aa481f"},
{"linux-git", "9060cb719e61"},
{"CVE", "2019-8912"},
{}
--
2.29.2
next reply other threads:[~2020-12-23 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 11:36 Richard Palethorpe [this message]
2020-12-28 20:01 ` [LTP] [PATCH] af_alg07: Add linux-git reference to more general fix Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223113636.9617-1-rpalethorpe@suse.com \
--to=rpalethorpe@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.