From: Adam Dinwoodie <adam@dinwoodie.org>
To: git@vger.kernel.org
Cc: Matheus Tavares Bernardino <matheus.bernardino@usp.br>,
Achim Gratz <Stromeko@nexgo.de>
Subject: [PATCH] t4129: fix setfacl-related permissions failure
Date: Wed, 23 Dec 2020 11:44:31 +0000 [thread overview]
Message-ID: <20201223114431.4595-1-adam@dinwoodie.org> (raw)
In-Reply-To: <CAHd-oW7XJL_a1zMAUetHzvrh8DrLT4g2awv-fjbTdeLVLKVsew@mail.gmail.com>
When running this test in Cygwin, it's necessary to remove the inherited
access control lists from the Git working directory in order for later
permissions tests to work as expected.
As such, fix an error in the test script so that the ACLs are set for
the working directory, not a nonexistent subdirectory.
Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
---
t/t4129-apply-samemode.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4129-apply-samemode.sh b/t/t4129-apply-samemode.sh
index 41818d8315..576632f868 100755
--- a/t/t4129-apply-samemode.sh
+++ b/t/t4129-apply-samemode.sh
@@ -78,7 +78,7 @@ test_expect_success POSIXPERM 'do not use core.sharedRepository for working tree
test_config core.sharedRepository 0666 &&
(
# Remove a default ACL if possible.
- (setfacl -k newdir 2>/dev/null || true) &&
+ (setfacl -k . 2>/dev/null || true) &&
umask 0077 &&
# Test both files (f1) and leading dirs (d)
--
2.30.0.rc1
next prev parent reply other threads:[~2020-12-23 11:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:23 Is git-am expected to honor core.sharedRepository? Matheus Tavares Bernardino
2020-12-01 17:58 ` Junio C Hamano
2020-12-01 23:45 ` [PATCH] apply: don't use core.sharedRepository to create working tree files Matheus Tavares
2020-12-02 0:21 ` Junio C Hamano
2020-12-19 17:51 ` Adam Dinwoodie
2020-12-19 18:12 ` Junio C Hamano
2020-12-19 18:59 ` Adam Dinwoodie
2020-12-19 18:32 ` Achim Gratz
2020-12-19 19:57 ` Adam Dinwoodie
2020-12-19 21:01 ` Achim Gratz
2020-12-22 22:24 ` Adam Dinwoodie
2020-12-22 22:49 ` Matheus Tavares Bernardino
2020-12-23 11:44 ` Adam Dinwoodie [this message]
2021-01-09 15:06 ` [PATCH] t4129: fix setfacl-related permissions failure Matheus Tavares Bernardino
2021-01-09 22:43 ` Junio C Hamano
2020-12-02 22:06 ` Is git-am expected to honor core.sharedRepository? Junio C Hamano
2020-12-03 1:44 ` Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223114431.4595-1-adam@dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=Stromeko@nexgo.de \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.