From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E20EC433E0 for ; Wed, 23 Dec 2020 20:30:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5718221F5 for ; Wed, 23 Dec 2020 20:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbgLWUaY (ORCPT ); Wed, 23 Dec 2020 15:30:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:40006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727187AbgLWUaX (ORCPT ); Wed, 23 Dec 2020 15:30:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB815221F5; Wed, 23 Dec 2020 20:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608755382; bh=EtXG9W3G1+A/sqX2J6p+P/ccEdSEfh0GmM7e1L8HOzo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Uhs0XCwswiiemTYvb3RCjqZxyfSXjWO4N1ogyHWVVaFzEc967RV+4Xa/uMR6y/u5Z KzKQvi5P3xcO/JSbFCJv4k2aaMmeAxf8XhsMUtpXIlpGiAq2HjQPcwDBO3xsQymBTA e0FQGXGKsfbtsbOmrc1S0hRLlegugx7n+FIKS7Tw= Date: Wed, 23 Dec 2020 12:29:42 -0800 From: Andrew Morton To: Helge Deller Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] proc/wchan: Use printk format instead of lookup_symbol_name() Message-Id: <20201223122942.3650e2fdf74c6e8f0a982010@linux-foundation.org> In-Reply-To: References: <20201217165413.GA1959@ls3530.fritz.box> <20201222181807.360cd9458d50b625608b8b44@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Dec 2020 10:48:10 +0100 Helge Deller wrote: > > static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns, > > struct pid *pid, struct task_struct *task) > > { > > - unsigned long wchan; > > - > > if (ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS)) > > - wchan = get_wchan(task); > > - else > > - wchan = 0; > > - > > - if (wchan) > > - seq_printf(m, "%ps", (void *) wchan); > > + seq_printf(m, "%ps", (void *)get_wchan(task)); > > else > > seq_putc(m, '0'); > > get_wchan() does return NULL sometimes, in which case with > your change now "0x0" instead of "0" gets printed. Ah, OK, ignore ;)