From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57A5C433E0 for ; Wed, 23 Dec 2020 14:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2B923159 for ; Wed, 23 Dec 2020 14:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbgLWOcn (ORCPT ); Wed, 23 Dec 2020 09:32:43 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:9399 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbgLWOcm (ORCPT ); Wed, 23 Dec 2020 09:32:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1608733962; x=1640269962; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mCXL6f9tv64JDm7NFojUga1H6cDJs67q/mMzoMR+F6o=; b=j5CXUGTzsHG+ZZZwF0FKf6ChKJABmVy9Th4TfEW1F0HurEPspl7t01b5 STtRpoQprP8MKkct3uCOG0q21Kqvn2xFNPwfyQwgRxaaMyc8i00M//Qi5 2p/mAqgUujNJn4y33Xmb8Q1NS8K/jRG0NjXpXGxXoiv//ueVbE6zWl7b2 7TrULt+6GLXXx3cVvLgS757nOD/CF8Jue2HnfKddoZ7LULkaW5EvAFlkj 5Z40KT6NqgWf8vsn9/AM33mQlL1jdT1X8rrf60jfldp2GRAlGNgl9So0n qvSaeHPvhgBIyw2s1DHnZz/jInYEnXr96YQWolLrltSrzgKBBPQQRK0dm g==; IronPort-SDR: XCNArEeyOBPN8MtiaCVgnuE8FzgmXjXzIk+Nw5p7b7ARTv2oGMHdjg0r1nMc1L7FVBYsPMaHDL 2kJGCJjInutd3mgrv1HCOhEdNFqhZBGtsP4oquGt7nPekeM9HfKwqOKHYz2jQWxDf5ofWfT3kn rQJdP5JpWHdvRneFEkxNujRqdNRtpZg2TWPUjvHTFDS7C9IC1qdl2hw5PiKyDJ+84Epm6QNP4T Fs8fmtTP2XKnU25lqZgD+df7mlkfa1+UGOzKHCJNXVi89QQ1TWgXq/aEcH7d0P2H7D36VQyKS5 BXg= X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="100844053" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Dec 2020 07:31:26 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 23 Dec 2020 07:31:26 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 23 Dec 2020 07:31:25 -0700 Date: Wed, 23 Dec 2020 15:31:24 +0100 From: Steen Hegelund To: Andrew Lunn CC: "David S. Miller" , Jakub Kicinski , Rob Herring , Device Tree List , Russell King , "Lars Povlsen" , Bjarni Jonasson , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Nicolas Ferre , Mark Einon , Masahiro Yamada , Arnd Bergmann , , , Subject: Re: [RFC PATCH v2 8/8] arm64: dts: sparx5: Add the Sparx5 switch node Message-ID: <20201223143124.tr2vejqgpf2qsot2@mchp-dev-shegelun> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-9-steen.hegelund@microchip.com> <20201219202448.GE3026679@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline In-Reply-To: <20201219202448.GE3026679@lunn.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.12.2020 21:24, Andrew Lunn wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> + port13: port@13 { >> + reg = <13>; >> + /* Example: CU SFP, 1G speed */ >> + max-speed = <10000>; > >One too many 0's for 1G. Ah, but this is allocation for the port, not the speed. This just used by the calendar module to allocate slots on the taxis as requested. So I would say it is OK to overallocate in this case (but you could argue it does not make much sense). > >> + /* 25G SFPs */ >> + port56: port@56 { >> + reg = <56>; >> + max-speed = <10000>; > >Why limit a 25G SFP to 10G? In the PCB134 case it is to keep the total allocation below 200Gbits ((12+8)*10G). There is a port mux mode that provides 8*25G on the 25G SerDes'es, but that would be a different DT. The Datasheet shows which port mux combinations are possible, and not all combinations of SerDes, Speed and interface are allowed. The PCB134 was designed to showcase this "many 10G ports" mode, so that is why we have the current DT. > > Andrew BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C45C433E0 for ; Wed, 23 Dec 2020 14:33:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 030E32332A for ; Wed, 23 Dec 2020 14:33:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 030E32332A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FKTejw9YsuGovjDT1QBiJP0e9EuIJgcbt65DUWaVlhE=; b=TU+q4IMM9PY+fIYecuhsrAQux tNFwa5Gy2OWdFE+tbeGrZ2fFnbfhbyuz+OpwkiTWUV5o7UX43UHnAEdiTzyF+PFUW/U+GmcatCKxF 79XHY+SOyYEcMq/IxU4niJrK6cjLuWuEBxCW77sUtvuAc3tWWBgTKElpO73wS77O3zfWfcHbd/b6U hcWBs2plqODiTyOJCAr/Rxk4aEy7U+pFZYOif2JSXfKE28+9pyZ2VREA4/80jyMI55Uq1XK4C5ccH NWrnM3AP/sFcdNArYysq2AjWmBuSDM9M5UDYlvU/V0JxX6y5C7L7lQ2P+TaNpAszRwR1qBZsFWwNp nTgyyQsYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks5Av-0002gg-43; Wed, 23 Dec 2020 14:31:37 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks5Ar-0002fz-KS for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 14:31:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1608733893; x=1640269893; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mCXL6f9tv64JDm7NFojUga1H6cDJs67q/mMzoMR+F6o=; b=t41C+Vtk7g1zbbKSvKRqyMUFriCdc8Al+T5PJxkOLDcpapalz1bieD/N 4OlBJVF7AnLSwJSJREqptuo9RiFq0S+Mrx3sVGr2mOjF7BrS98b9jJXPH 4MimGC6UHuy1LlB+eJBft73w6yBUEw7y+amHqLXHyUHHF+dC/FV9Ee0X7 vcsoJKop3v4leXZAQvJ6GZ4sK/vbjmCUaRjNmO1rTyQtYPiKQwiBuKFo5 pz1v8civX9wfntQYtlEDXva6Y1lIEnlBvzmznYNcqJ27XnKFwPdHdutQ8 DCnH8xrg1wLIl4wYdYIkdWgICQ/uTTxLazgXj9G+itsq16mcrYQhWsq+Y g==; IronPort-SDR: XCNArEeyOBPN8MtiaCVgnuE8FzgmXjXzIk+Nw5p7b7ARTv2oGMHdjg0r1nMc1L7FVBYsPMaHDL 2kJGCJjInutd3mgrv1HCOhEdNFqhZBGtsP4oquGt7nPekeM9HfKwqOKHYz2jQWxDf5ofWfT3kn rQJdP5JpWHdvRneFEkxNujRqdNRtpZg2TWPUjvHTFDS7C9IC1qdl2hw5PiKyDJ+84Epm6QNP4T Fs8fmtTP2XKnU25lqZgD+df7mlkfa1+UGOzKHCJNXVi89QQ1TWgXq/aEcH7d0P2H7D36VQyKS5 BXg= X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="100844053" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Dec 2020 07:31:26 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 23 Dec 2020 07:31:26 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 23 Dec 2020 07:31:25 -0700 Date: Wed, 23 Dec 2020 15:31:24 +0100 From: Steen Hegelund To: Andrew Lunn Subject: Re: [RFC PATCH v2 8/8] arm64: dts: sparx5: Add the Sparx5 switch node Message-ID: <20201223143124.tr2vejqgpf2qsot2@mchp-dev-shegelun> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-9-steen.hegelund@microchip.com> <20201219202448.GE3026679@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201219202448.GE3026679@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201223_093133_891843_ED17E9D4 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Device Tree List , Alexandre Belloni , linux-kernel@vger.kernel.org, Arnd Bergmann , Bjarni Jonasson , Madalin Bucur , netdev@vger.kernel.org, Masahiro Yamada , Russell King , Microchip Linux Driver Support , Rob Herring , linux-arm-kernel@lists.infradead.org, Mark Einon , Jakub Kicinski , "David S. Miller" , Lars Povlsen Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19.12.2020 21:24, Andrew Lunn wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> + port13: port@13 { >> + reg = <13>; >> + /* Example: CU SFP, 1G speed */ >> + max-speed = <10000>; > >One too many 0's for 1G. Ah, but this is allocation for the port, not the speed. This just used by the calendar module to allocate slots on the taxis as requested. So I would say it is OK to overallocate in this case (but you could argue it does not make much sense). > >> + /* 25G SFPs */ >> + port56: port@56 { >> + reg = <56>; >> + max-speed = <10000>; > >Why limit a 25G SFP to 10G? In the PCB134 case it is to keep the total allocation below 200Gbits ((12+8)*10G). There is a port mux mode that provides 8*25G on the 25G SerDes'es, but that would be a different DT. The Datasheet shows which port mux combinations are possible, and not all combinations of SerDes, Speed and interface are allowed. The PCB134 was designed to showcase this "many 10G ports" mode, so that is why we have the current DT. > > Andrew BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel