From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D2B3C433E0 for ; Wed, 23 Dec 2020 21:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1353224B1 for ; Wed, 23 Dec 2020 21:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729214AbgLWVGM (ORCPT ); Wed, 23 Dec 2020 16:06:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:39162 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729110AbgLWVGL (ORCPT ); Wed, 23 Dec 2020 16:06:11 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ksBJx-00Der5-RT; Wed, 23 Dec 2020 22:05:21 +0100 Date: Wed, 23 Dec 2020 22:05:21 +0100 From: Andrew Lunn To: Alexandre Belloni Cc: Steen Hegelund , "David S. Miller" , Jakub Kicinski , Russell King , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Madalin Bucur , Nicolas Ferre , Mark Einon , Masahiro Yamada , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v2 3/8] net: sparx5: add hostmode with phylink support Message-ID: <20201223210521.GB3253993@lunn.ch> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-4-steen.hegelund@microchip.com> <20201219195133.GD3026679@lunn.ch> <20201222144141.GK3107610@lunn.ch> <20201223205852.GA4138276@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201223205852.GA4138276@piout.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 09:58:52PM +0100, Alexandre Belloni wrote: > On 22/12/2020 15:41:41+0100, Andrew Lunn wrote: > > > Yes the register based injection/extration is not going to be fast, but > > > the FDMA and its driver is being sent later as separate series to keep > > > the size of this review down. > > > > FDMA? > > > > I need a bit more background here, just to make use this should be a > > pure switchdev driver and not a DSA driver. > > > > I don't think this should be a DSA driver. As for Ocelot, the CPU > port is not a MAC and in that use case, this would be like a top of the > rack switch with traffic going to the CPU port being mostly used for > managmement (dhcp, stp, etc...) as opposed to being used to forward > traffic to another interface, like WAN or wifi. > > However, I would think there will be cases where the internal CPU is not > use and instead use ths switch in a DSA setting, very much like what is > done for Felix with regards to Ocelot. >From what i have heard so far, it does seem like a pure switchdev driver is correct. So long as FDMA is not a standalone Ethernet driver, but just a DMA engine incorporated into this driver, the architecture looks correct. I was asking because from the information that was available, it was impossible to say what the correct architecture should be. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A134C433E0 for ; Wed, 23 Dec 2020 21:07:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B2DD2246B for ; Wed, 23 Dec 2020 21:07:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B2DD2246B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MAmPx76PAPBBgvHdZIbKiTTfVUs7DfGmm3qelnh3hgo=; b=deXQYOch/vSleq67euUyIFPnU tOdnp6eb5DBBGCKY246kkjn7Dwz/VZGx1uUlqYHru2hDSfRu9oYzUuVYiYfO7MfRRWOHnopoAnAvH WO7Jq7CqjXQmI/NTUq0LjF1eFJfVAFdNUBU1Ce+BZ54ydic8tV8xn/SdPH1MTXwmx7m5olBGVAgUg ayzMp88jpgYD1SzkGAutwU8iGBBPrkDzNXaiJxidBrH2p8vJ328xeO7E5nrdDJnhCI55JIsqo2Kfy A2uGX99TvHyBd5VaUDmy0/Pu0X9Ac/M4rYe4UhrBQOpMrpVBsAFxF1jDOUZqfM+bodKpmerNXA8t9 4mlbsJVug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksBKD-0002O9-5T; Wed, 23 Dec 2020 21:05:37 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksBKA-0002Nl-Us for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 21:05:36 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ksBJx-00Der5-RT; Wed, 23 Dec 2020 22:05:21 +0100 Date: Wed, 23 Dec 2020 22:05:21 +0100 From: Andrew Lunn To: Alexandre Belloni Subject: Re: [RFC PATCH v2 3/8] net: sparx5: add hostmode with phylink support Message-ID: <20201223210521.GB3253993@lunn.ch> References: <20201217075134.919699-1-steen.hegelund@microchip.com> <20201217075134.919699-4-steen.hegelund@microchip.com> <20201219195133.GD3026679@lunn.ch> <20201222144141.GK3107610@lunn.ch> <20201223205852.GA4138276@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201223205852.GA4138276@piout.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201223_160535_037315_36E71C5C X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjarni Jonasson , linux-kernel@vger.kernel.org, Arnd Bergmann , Madalin Bucur , netdev@vger.kernel.org, Steen Hegelund , Russell King , Microchip Linux Driver Support , linux-arm-kernel@lists.infradead.org, Mark Einon , Jakub Kicinski , Masahiro Yamada , "David S. Miller" , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 23, 2020 at 09:58:52PM +0100, Alexandre Belloni wrote: > On 22/12/2020 15:41:41+0100, Andrew Lunn wrote: > > > Yes the register based injection/extration is not going to be fast, but > > > the FDMA and its driver is being sent later as separate series to keep > > > the size of this review down. > > > > FDMA? > > > > I need a bit more background here, just to make use this should be a > > pure switchdev driver and not a DSA driver. > > > > I don't think this should be a DSA driver. As for Ocelot, the CPU > port is not a MAC and in that use case, this would be like a top of the > rack switch with traffic going to the CPU port being mostly used for > managmement (dhcp, stp, etc...) as opposed to being used to forward > traffic to another interface, like WAN or wifi. > > However, I would think there will be cases where the internal CPU is not > use and instead use ths switch in a DSA setting, very much like what is > done for Felix with regards to Ocelot. >From what i have heard so far, it does seem like a pure switchdev driver is correct. So long as FDMA is not a standalone Ethernet driver, but just a DMA engine incorporated into this driver, the architecture looks correct. I was asking because from the information that was available, it was impossible to say what the correct architecture should be. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel