From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358F6C4332D for ; Thu, 24 Dec 2020 06:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C6B822AED for ; Thu, 24 Dec 2020 06:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgLXG3L (ORCPT ); Thu, 24 Dec 2020 01:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbgLXG3L (ORCPT ); Thu, 24 Dec 2020 01:29:11 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3511C0617A6 for ; Wed, 23 Dec 2020 22:28:30 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id v1so639865pjr.2 for ; Wed, 23 Dec 2020 22:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=fkgyFFom2uaI6UYerCixgJyMGXGGZzyzPl2pC34SDHHWr//SHmo19YSii8QHZaSaa0 uZC2skGBke5PtP9vslEZombfKjKIAYRw9D3l2M5uGrJ+VkC9bDxNBcQDONWQUC2dmGxG 6UJpFpuY87irp1H90rXExkNF0g2y+4HLV3Ep3/gdgJBqsszg3FbKmgil0GqbQ6dTgEnh DrDRzMipJyOMadGCFG5+H9D0UVs6y0l4FAVZ+I0/J5ZdR5hXHDE2454h+0iAD/EAVgA3 IDDlN9SUV6QyhslIyk38zgEDS9uC1vEdXUB6uhGhlyh9+PUCifXrT875haF9d9ipr3qB NnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=JttFskQDkKAUNC9uSHby+GQ8gzy+ZeZorS+3K+9IlzMnTpG9zd/FDWoQCw8+FmGzMv iFqKlPhgRxCZqcV72kky66n/Jhi6PpAvVvPVQVDKPJFHGPTuqAT7cqVyGS3LQzFGxH2R D4+inaTehYvgQu+M1ouGW1Qk8xPy/4y+3XWv7S8W1LpLWhC7MeyM9bn9SalAhPeLB6UW 0610k5yIQ1/836x74ZxAYmEDGbgsV3D3+Lp96RL+M10tvCOSJTNlOaXiJTJEAyPpDBEr +45OAx1pf0Fe+P7Tl7GYSIvWj1BTE12d7WnEJrP2ldA2rMOtCD+0A4CPe2Ig1fK7NZnh s83w== X-Gm-Message-State: AOAM532uFMsW3ApGUeRSIP4Noc1uL0+3jin6BSIR2056/BWinfzmqGXd ga6Ny/jtiuJJAIIA29z9kFRUCQ== X-Google-Smtp-Source: ABdhPJwZjLbo7aGBJ7sNLaIhWcs4xnkHkI7BDfYQrcbWA55ODln8fkpMZgsIP8pDydfAZ37ygqOZVA== X-Received: by 2002:a17:90a:380c:: with SMTP id w12mr2982286pjb.117.1608791310121; Wed, 23 Dec 2020 22:28:30 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t18sm25653088pfl.138.2020.12.23.22.28.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Dec 2020 22:28:29 -0800 (PST) Date: Thu, 24 Dec 2020 11:58:27 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201224062826.frppxddfinjomfui@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> <20201223043443.rklw5er6hck3gl4y@vireshk-i7> <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 23-12-20, 23:36, Dmitry Osipenko wrote: > 23.12.2020 07:34, Viresh Kumar пишет: > > On 22-12-20, 22:19, Dmitry Osipenko wrote: > >> 22.12.2020 12:12, Viresh Kumar пишет: > >>> rate will be 0 for both the OPPs here if rate_not_available is true and so this > >>> change shouldn't be required. > >> > >> The rate_not_available is negated in the condition. This change is > >> required because both rates are 0 and then we should proceed to the > >> levels comparison. > > > > Won't that happen without this patch ? > > No This is how the code looks like currently: int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2) { if (opp1->rate != opp2->rate) return opp1->rate < opp2->rate ? -1 : 1; if (opp1->bandwidth && opp2->bandwidth && opp1->bandwidth[0].peak != opp2->bandwidth[0].peak) return opp1->bandwidth[0].peak < opp2->bandwidth[0].peak ? -1 : 1; if (opp1->level != opp2->level) return opp1->level < opp2->level ? -1 : 1; return 0; } Lets consider the case you are focussing on, where rate is 0 for both the OPPs, bandwidth isn't there and we want to run the level comparison here. Since both the rates are 0, (opp1->rate != opp2->rate) will fail and so we will move to bandwidth check which will fail too. And so we will get to the level comparison. What am I missing here ? I am sure there is something for sure as you won't have missed this.. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FCFC433DB for ; Thu, 24 Dec 2020 06:28:37 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CB2922571 for ; Thu, 24 Dec 2020 06:28:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CB2922571 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 73E0A2E158; Thu, 24 Dec 2020 06:28:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8FEVf0cgD+fi; Thu, 24 Dec 2020 06:28:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D390E2E141; Thu, 24 Dec 2020 06:28:32 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 75F1F1BF3AA for ; Thu, 24 Dec 2020 06:28:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 66E5186566 for ; Thu, 24 Dec 2020 06:28:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yXZQd7NrjtVd for ; Thu, 24 Dec 2020 06:28:30 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id A2A448649A for ; Thu, 24 Dec 2020 06:28:30 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id m5so670893pjv.5 for ; Wed, 23 Dec 2020 22:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=fkgyFFom2uaI6UYerCixgJyMGXGGZzyzPl2pC34SDHHWr//SHmo19YSii8QHZaSaa0 uZC2skGBke5PtP9vslEZombfKjKIAYRw9D3l2M5uGrJ+VkC9bDxNBcQDONWQUC2dmGxG 6UJpFpuY87irp1H90rXExkNF0g2y+4HLV3Ep3/gdgJBqsszg3FbKmgil0GqbQ6dTgEnh DrDRzMipJyOMadGCFG5+H9D0UVs6y0l4FAVZ+I0/J5ZdR5hXHDE2454h+0iAD/EAVgA3 IDDlN9SUV6QyhslIyk38zgEDS9uC1vEdXUB6uhGhlyh9+PUCifXrT875haF9d9ipr3qB NnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=e5SP4hM55sGrPjaXgnBU/MmmaQ/2G6m2D8HrETQNyWq+fZVf4OEFS0cycFsTmTuhod 4ubM+53qAWj75lTyG7Uw5c1F+/Abxrn1dZG4xSge34OmVu41wsXQZpDpRJZLa5oCb291 diBDc3twZmAQ5d5ETC2mItGCW6y6Fv8CDE78m5EKz6tPeFXmNmjhJDs8vcgXqUc0l+MM y4ANTdi5LXpSky8eem90DfdRs1u18MsM0QalUGCqRwYUN8z53VzR+KFAonHfS4URNeit m+NalcwNh73vPdrAr70VTJ4xmshm+ffN1wO7zWDdLitEVibHgamwzGjD007bAVtW9502 +Igg== X-Gm-Message-State: AOAM533qiTcVFxY3PVoTxfQGp6t24V0NJpGD/2Ti8c8079IEanVdIWQf D7oher7ue62VUEXafvNFT9CPNA== X-Google-Smtp-Source: ABdhPJwZjLbo7aGBJ7sNLaIhWcs4xnkHkI7BDfYQrcbWA55ODln8fkpMZgsIP8pDydfAZ37ygqOZVA== X-Received: by 2002:a17:90a:380c:: with SMTP id w12mr2982286pjb.117.1608791310121; Wed, 23 Dec 2020 22:28:30 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t18sm25653088pfl.138.2020.12.23.22.28.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Dec 2020 22:28:29 -0800 (PST) Date: Thu, 24 Dec 2020 11:58:27 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201224062826.frppxddfinjomfui@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> <20201223043443.rklw5er6hck3gl4y@vireshk-i7> <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMjMtMTItMjAsIDIzOjM2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjMuMTIuMjAyMCAw NzozNCwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBPbiAyMi0xMi0yMCwgMjI6MTksIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiAyMi4xMi4yMDIwIDEyOjEyLCBWaXJlc2ggS3VtYXIg 0L/QuNGI0LXRgjoKPiA+Pj4gcmF0ZSB3aWxsIGJlIDAgZm9yIGJvdGggdGhlIE9QUHMgaGVyZSBp ZiByYXRlX25vdF9hdmFpbGFibGUgaXMgdHJ1ZSBhbmQgc28gdGhpcwo+ID4+PiBjaGFuZ2Ugc2hv dWxkbid0IGJlIHJlcXVpcmVkLgo+ID4+Cj4gPj4gVGhlIHJhdGVfbm90X2F2YWlsYWJsZSBpcyBu ZWdhdGVkIGluIHRoZSBjb25kaXRpb24uIFRoaXMgY2hhbmdlIGlzCj4gPj4gcmVxdWlyZWQgYmVj YXVzZSBib3RoIHJhdGVzIGFyZSAwIGFuZCB0aGVuIHdlIHNob3VsZCBwcm9jZWVkIHRvIHRoZQo+ ID4+IGxldmVscyBjb21wYXJpc29uLgo+ID4gCj4gPiBXb24ndCB0aGF0IGhhcHBlbiB3aXRob3V0 IHRoaXMgcGF0Y2ggPwo+IAo+IE5vCgpUaGlzIGlzIGhvdyB0aGUgY29kZSBsb29rcyBsaWtlIGN1 cnJlbnRseToKCmludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAxLCBz dHJ1Y3QgZGV2X3BtX29wcCAqb3BwMikKewoJaWYgKG9wcDEtPnJhdGUgIT0gb3BwMi0+cmF0ZSkK CQlyZXR1cm4gb3BwMS0+cmF0ZSA8IG9wcDItPnJhdGUgPyAtMSA6IDE7CglpZiAob3BwMS0+YmFu ZHdpZHRoICYmIG9wcDItPmJhbmR3aWR0aCAmJgoJICAgIG9wcDEtPmJhbmR3aWR0aFswXS5wZWFr ICE9IG9wcDItPmJhbmR3aWR0aFswXS5wZWFrKQoJCXJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0u cGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5wZWFrID8gLTEgOiAxOwoJaWYgKG9wcDEtPmxldmVs ICE9IG9wcDItPmxldmVsKQoJCXJldHVybiBvcHAxLT5sZXZlbCA8IG9wcDItPmxldmVsID8gLTEg OiAxOwoJcmV0dXJuIDA7Cn0KCkxldHMgY29uc2lkZXIgdGhlIGNhc2UgeW91IGFyZSBmb2N1c3Np bmcgb24sIHdoZXJlIHJhdGUgaXMgMCBmb3IgYm90aCB0aGUgT1BQcywKYmFuZHdpZHRoIGlzbid0 IHRoZXJlIGFuZCB3ZSB3YW50IHRvIHJ1biB0aGUgbGV2ZWwgY29tcGFyaXNvbiBoZXJlLgoKU2lu Y2UgYm90aCB0aGUgcmF0ZXMgYXJlIDAsIChvcHAxLT5yYXRlICE9IG9wcDItPnJhdGUpIHdpbGwg ZmFpbCBhbmQgc28gd2Ugd2lsbAptb3ZlIHRvIGJhbmR3aWR0aCBjaGVjayB3aGljaCB3aWxsIGZh aWwgdG9vLiBBbmQgc28gd2Ugd2lsbCBnZXQgdG8gdGhlIGxldmVsCmNvbXBhcmlzb24uCgpXaGF0 IGFtIEkgbWlzc2luZyBoZXJlID8gSSBhbSBzdXJlIHRoZXJlIGlzIHNvbWV0aGluZyBmb3Igc3Vy ZSBhcyB5b3Ugd29uJ3QgaGF2ZQptaXNzZWQgdGhpcy4uCgotLSAKdmlyZXNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApk ZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJw cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7D4C433E6 for ; Fri, 25 Dec 2020 09:42:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCF9E230FF for ; Fri, 25 Dec 2020 09:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF9E230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DE2E89B9A; Fri, 25 Dec 2020 09:42:11 +0000 (UTC) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ABE689A4B for ; Thu, 24 Dec 2020 06:28:30 +0000 (UTC) Received: by mail-pl1-x62a.google.com with SMTP id r4so838217pls.11 for ; Wed, 23 Dec 2020 22:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=fkgyFFom2uaI6UYerCixgJyMGXGGZzyzPl2pC34SDHHWr//SHmo19YSii8QHZaSaa0 uZC2skGBke5PtP9vslEZombfKjKIAYRw9D3l2M5uGrJ+VkC9bDxNBcQDONWQUC2dmGxG 6UJpFpuY87irp1H90rXExkNF0g2y+4HLV3Ep3/gdgJBqsszg3FbKmgil0GqbQ6dTgEnh DrDRzMipJyOMadGCFG5+H9D0UVs6y0l4FAVZ+I0/J5ZdR5hXHDE2454h+0iAD/EAVgA3 IDDlN9SUV6QyhslIyk38zgEDS9uC1vEdXUB6uhGhlyh9+PUCifXrT875haF9d9ipr3qB NnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EjusjKqe1uD5qVIhtNFzzFr/40x6TzvZ/Sd3W/PBS+U=; b=UPvKyg++QUUW22OvdO4c88ED/JERJT/tWFuPkPL0gz8pWLpFQsSn4wl6VWpyXk7hE4 yuWapqqnUrc2IpCOUStCZYBUPhKm7cmqs/mBfYQtiRM9465HY0HrOMNMd4eva/Er8VDN tszdiGubgmaI24Y44GxAWq59kdVEpmGEFJNu92VsU51wJ4jbfMHTcej4/o6Yye0knmpa PL2aYIukK1l4QovrLPYdJMUPsV+rkQBnzSUcTA1A6biukNujuYO5tLBARkUf8YWo6+AZ VqxAXda1p6U0w7yc210Lu1BQ4A+QM2q6WBCjk658OepZOD5NifNiGFJBxQU7L9HnGcqX Gttw== X-Gm-Message-State: AOAM530Z3JML+Opo0RPGkzlACLt51FAU17keiaNHRT3XysJm28ZZGXU6 VXKbb4EZw0ey5goCkUGPKkKiPg== X-Google-Smtp-Source: ABdhPJwZjLbo7aGBJ7sNLaIhWcs4xnkHkI7BDfYQrcbWA55ODln8fkpMZgsIP8pDydfAZ37ygqOZVA== X-Received: by 2002:a17:90a:380c:: with SMTP id w12mr2982286pjb.117.1608791310121; Wed, 23 Dec 2020 22:28:30 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id t18sm25653088pfl.138.2020.12.23.22.28.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Dec 2020 22:28:29 -0800 (PST) Date: Thu, 24 Dec 2020 11:58:27 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable Message-ID: <20201224062826.frppxddfinjomfui@vireshk-i7> References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> <20201223043443.rklw5er6hck3gl4y@vireshk-i7> <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7688d6b9-52a2-d30f-123f-43c01e03b968@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-Mailman-Approved-At: Fri, 25 Dec 2020 09:42:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjMtMTItMjAsIDIzOjM2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjMuMTIuMjAyMCAw NzozNCwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBPbiAyMi0xMi0yMCwgMjI6MTksIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiAyMi4xMi4yMDIwIDEyOjEyLCBWaXJlc2ggS3VtYXIg 0L/QuNGI0LXRgjoKPiA+Pj4gcmF0ZSB3aWxsIGJlIDAgZm9yIGJvdGggdGhlIE9QUHMgaGVyZSBp ZiByYXRlX25vdF9hdmFpbGFibGUgaXMgdHJ1ZSBhbmQgc28gdGhpcwo+ID4+PiBjaGFuZ2Ugc2hv dWxkbid0IGJlIHJlcXVpcmVkLgo+ID4+Cj4gPj4gVGhlIHJhdGVfbm90X2F2YWlsYWJsZSBpcyBu ZWdhdGVkIGluIHRoZSBjb25kaXRpb24uIFRoaXMgY2hhbmdlIGlzCj4gPj4gcmVxdWlyZWQgYmVj YXVzZSBib3RoIHJhdGVzIGFyZSAwIGFuZCB0aGVuIHdlIHNob3VsZCBwcm9jZWVkIHRvIHRoZQo+ ID4+IGxldmVscyBjb21wYXJpc29uLgo+ID4gCj4gPiBXb24ndCB0aGF0IGhhcHBlbiB3aXRob3V0 IHRoaXMgcGF0Y2ggPwo+IAo+IE5vCgpUaGlzIGlzIGhvdyB0aGUgY29kZSBsb29rcyBsaWtlIGN1 cnJlbnRseToKCmludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAxLCBz dHJ1Y3QgZGV2X3BtX29wcCAqb3BwMikKewoJaWYgKG9wcDEtPnJhdGUgIT0gb3BwMi0+cmF0ZSkK CQlyZXR1cm4gb3BwMS0+cmF0ZSA8IG9wcDItPnJhdGUgPyAtMSA6IDE7CglpZiAob3BwMS0+YmFu ZHdpZHRoICYmIG9wcDItPmJhbmR3aWR0aCAmJgoJICAgIG9wcDEtPmJhbmR3aWR0aFswXS5wZWFr ICE9IG9wcDItPmJhbmR3aWR0aFswXS5wZWFrKQoJCXJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0u cGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5wZWFrID8gLTEgOiAxOwoJaWYgKG9wcDEtPmxldmVs ICE9IG9wcDItPmxldmVsKQoJCXJldHVybiBvcHAxLT5sZXZlbCA8IG9wcDItPmxldmVsID8gLTEg OiAxOwoJcmV0dXJuIDA7Cn0KCkxldHMgY29uc2lkZXIgdGhlIGNhc2UgeW91IGFyZSBmb2N1c3Np bmcgb24sIHdoZXJlIHJhdGUgaXMgMCBmb3IgYm90aCB0aGUgT1BQcywKYmFuZHdpZHRoIGlzbid0 IHRoZXJlIGFuZCB3ZSB3YW50IHRvIHJ1biB0aGUgbGV2ZWwgY29tcGFyaXNvbiBoZXJlLgoKU2lu Y2UgYm90aCB0aGUgcmF0ZXMgYXJlIDAsIChvcHAxLT5yYXRlICE9IG9wcDItPnJhdGUpIHdpbGwg ZmFpbCBhbmQgc28gd2Ugd2lsbAptb3ZlIHRvIGJhbmR3aWR0aCBjaGVjayB3aGljaCB3aWxsIGZh aWwgdG9vLiBBbmQgc28gd2Ugd2lsbCBnZXQgdG8gdGhlIGxldmVsCmNvbXBhcmlzb24uCgpXaGF0 IGFtIEkgbWlzc2luZyBoZXJlID8gSSBhbSBzdXJlIHRoZXJlIGlzIHNvbWV0aGluZyBmb3Igc3Vy ZSBhcyB5b3Ugd29uJ3QgaGF2ZQptaXNzZWQgdGhpcy4uCgotLSAKdmlyZXNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=