All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Shubin <nikita.shubin@maquefel.me>
To: unlisted-recipients:; (no To-header on input)
Cc: Nikita Shubin <nikita.shubin@maquefel.me>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first
Date: Thu, 24 Dec 2020 14:22:03 +0300	[thread overview]
Message-ID: <20201224112203.7174-4-nikita.shubin@maquefel.me> (raw)
In-Reply-To: <20201224112203.7174-1-nikita.shubin@maquefel.me>

Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE.

So we need to specify girq->first otherwise:

"If device tree is used, then first_irq will be 0 and
irqs get mapped dynamically on the fly"

And that's not the thing we want.

Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
 drivers/gpio/gpio-ep93xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 90afe07213ce..a321a7441294 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -402,6 +402,7 @@ static int ep93xx_gpio_add_f_irq_chip(struct gpio_chip *gc,
 	}
 	girq->default_type = IRQ_TYPE_NONE;
 	girq->handler = handle_level_irq;
+	girq->first = EP93XX_GPIO_F_IRQ_BASE;
 
 	return 0;
 }
-- 
2.26.2


  parent reply	other threads:[~2020-12-24 11:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 11:22 [RFC PATCH 0/3] gpio: ep93xx: convert to multi irqchips Nikita Shubin
2020-12-24 11:22 ` [RFC PATCH 1/3] " Nikita Shubin
2020-12-26 17:52   ` Andy Shevchenko
2020-12-28 15:05     ` nikita.shubin
2020-12-24 11:22 ` [RFC PATCH 2/3] gpio: ep93xx: drop to_irq binding Nikita Shubin
2020-12-27 21:21   ` Linus Walleij
2021-01-04 14:17     ` Bartosz Golaszewski
2020-12-24 11:22 ` Nikita Shubin [this message]
2020-12-27 21:22   ` [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first Linus Walleij
2020-12-26 17:34 ` [RFC PATCH 0/3] gpio: ep93xx: convert to multi irqchips Andy Shevchenko
2020-12-27 14:00   ` Linus Walleij
2020-12-27 13:55 ` Linus Walleij
2020-12-28 15:14   ` nikita.shubin
2020-12-28 20:41     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201224112203.7174-4-nikita.shubin@maquefel.me \
    --to=nikita.shubin@maquefel.me \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.