From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8E4C433E0 for ; Sat, 26 Dec 2020 17:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2A472184D for ; Sat, 26 Dec 2020 17:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgLZRtZ (ORCPT ); Sat, 26 Dec 2020 12:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgLZRtY (ORCPT ); Sat, 26 Dec 2020 12:49:24 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA53C0613C1 for ; Sat, 26 Dec 2020 09:48:43 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id j13so4204913pjz.3 for ; Sat, 26 Dec 2020 09:48:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=foWfOdT04uv80XGPsJhiNm17byd6glhsFz3LEKspRTo=; b=WfOfQn969frH+2XAgoqF9e4MdbPoaDhUBWLZAeMtmn3oU48v6Gs+D8WAJWPpEvpzXO nFCrpukOU4r53Hss9NIgShvF7rDIdHVbcSlTjoFlo900Y4Zg/J43RfCLyjrICQZS7NyT PvrM0Smr7Syr/9rmOch2nZg/hCf7E/+TItZBCe3x0x66cqKwdfIBqcRDS7YN1c10x3xU 8LcGmvD2twGwtT0VhAV+C0SgkNl980h+gA5qPlJfrYnR1vBYC9SBL592kxBtvnlHbcXA jEV9I66dL88sra8dp2c9NWH5HL40Sdcovs7Ck5xe0IfdQWnJqoqjPZTdWaG9jzUX0MX3 CqZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=foWfOdT04uv80XGPsJhiNm17byd6glhsFz3LEKspRTo=; b=i0HY22zGNo0UsKxSRy48FEWmRaiKg7McfIXvTW2qdO9NRQ31CRbjIwU1ks823Vicjt rZBHtF6U4K11PRAUGnWnpqzXOFQ+qg7ZMKcQq0fmb2IPsRrMef/zXxCWIkdJrnTNruIG e5rCpESqSOvcDDeZVCWYeEVyCNlC/6BWo1kKF8tA+pAVBEBoDQKu0yEut4Qqq+BS7EK+ SVPak7kzgmq30x2vZ6Fwjd/KAU8qmOqvBg5EW0lOAe+9vxsyFQ4XI9DKAxA+Bw+5gP4n ZYSzd5YQifh5AjuQqTVSm6XSJDcbiumYbiecWD43c4W6L5liwyiUyDuR+oU2sgOYogfz /G1w== X-Gm-Message-State: AOAM5324hSPKuAYLt52Mp8XEaLr6baXyK3ZjlAnpkARanpSCvXaZV0k5 XXRiLdqypD8rE6vJAxTxB3G+Ig== X-Google-Smtp-Source: ABdhPJwbGaiBbpek67Ai+NSo33SQHnfvIk3Mo9v6pt+Wh54Hh8aFEqjlCZLXgEPF/PFkYNPYN5vJSw== X-Received: by 2002:a17:902:6a83:b029:dc:2a2c:6b91 with SMTP id n3-20020a1709026a83b02900dc2a2c6b91mr14864645plk.8.1609004923236; Sat, 26 Dec 2020 09:48:43 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a31sm33748528pgb.93.2020.12.26.09.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Dec 2020 09:48:42 -0800 (PST) Date: Sat, 26 Dec 2020 09:48:32 -0800 From: Stephen Hemminger To: Oliver Hartkopp Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org Subject: Re: [PATCH iproute2 5.11 2/2] iplink_can: fix format output for details with statistics Message-ID: <20201226094832.2b12a20e@hermes.local> In-Reply-To: <20201225191015.3584-2-socketcan@hartkopp.net> References: <20201225191015.3584-1-socketcan@hartkopp.net> <20201225191015.3584-2-socketcan@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Fri, 25 Dec 2020 20:10:15 +0100 Oliver Hartkopp wrote: > @@ -315,10 +320,12 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) > "restart_ms", > "restart-ms %d ", > *restart_ms); > } > > + fprintf(f, "\n "); > + That will print in both JSON and non-JSON mode. You don't want to do that. It also will break in single-line mode. The iplink_can code has way too many if (is_json_context()) ... which can lead to differences in output. Ideally it should have no instances of "fprintf(f, ..."