From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C74CC433DB for ; Sat, 26 Dec 2020 12:35:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30A0E221E2 for ; Sat, 26 Dec 2020 12:35:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30A0E221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0/JJ63fswkL0r1PouE/O1js2N8awuLvUbSKGhW9Ly1w=; b=g5uWXSXPkz31IQcsfi+gSlYBS 0Cwy/k1Mqn5ZOORRNCFc1dvMDG09Xmr6UD6f5ymx6f7Rskvy3U0164knwN6roTU96C4xL6kLK42GH z8NN7tt4SsF1eOHm5gQRMFAzU93f4nciIJVIf9kIB7COSKXRd8vq8lXp3IbV4lDrhKFSWm7yEtIne jgSl22DdfqlMmdL4gbQwB6uT16s94s8rIN5nfMI2H5AUs8YUjopdNo2kzOKP45oouVkK4Eo/zZ854 aOM5+gWlIgHS7sYJ9p7gF7oFIeGUllxHf/ZfPnl3OyzA+/fR85BgfQp4RNxDfVVFU/j29pyTnm6q6 c1zMrCMtA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8mD-0007NF-CL; Sat, 26 Dec 2020 12:34:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8m9-0007Mq-VN for linux-arm-kernel@lists.infradead.org; Sat, 26 Dec 2020 12:34:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=R92bOdFq9sdUrQK3uvJW0wc2hLzmxAk291XmMgLZ8+U=; b=vhI9buBftpaVIMMq9bLEkFFTH 5OCAZ7G6qxklhzDA/hRfF0DbslqhNkBXzHi5uCYOde5DdTD5sB4YRq2Vmu7zpPw5JBbv0rTvFF+NB 346KhVqCNaTSXCcBsUFdT88NOzk9tVIQ2IIV9BZ+ZVqe+E+rjb+qvocKg1QzigOBrF6kMdOtkRpdZ PmFmri7kPv1KXMIsMYdkMdpwRiLQDn0BU0jD72o6M5mwTYlqAmuqE8+DY8xVv1brUvz8j1h1SWHbg hFmON/b1IJeCqW0/3iytBLxQY8/rga701QPCQF/WOVEy/ke0nSRBF/zaGxZIS9SCiQ704F3RugVOe FhGO9ek/w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44540) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt8m6-0003SW-KD; Sat, 26 Dec 2020 12:34:22 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kt8m5-0006q2-Jz; Sat, 26 Dec 2020 12:34:21 +0000 Date: Sat, 26 Dec 2020 12:34:21 +0000 From: Russell King - ARM Linux admin To: Michael Walle Subject: Re: Broken ethernet on SolidRun cubox-i Message-ID: <20201226123421.GD1551@shell.armlinux.org.uk> References: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201226_073426_036719_380E92BB X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matus Ujhelyi , acmattheis@gmx.net, Christoph Mattheis , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 26, 2020 at 01:18:01PM +0100, Michael Walle wrote: > Thus I suspect your commit 86b08bd5b994 ("ARM: dts: imx6-sr-som: add > ethernet PHY configuration") to be the culprit ;) This will pin the > PHY to address 0. I don't know how it was done before; like was there > autoprobing if there is no "phy-handle" or did the bootloader fix that > inplace. I don't have any cubox-i. There is the need to move the AT803x quirk handling into DT rather than using the PHY quirk system - the problem is, the PHY quirk system applies the quirks to every iMX6 platform out there, whether the quirk is right or wrong for that board. I'd forgotten that there were boards out there with this problem... the PHY address configuration is done via the LED_ACT pin, and SolidRun omitted a pull resistor on it, so it "floats" with the leakage current of the LED/pin - resulting in it sometimes appearing at address 0 and sometimes at address 4. I suppose there's no option but to revert the commit - but it needs to be properly documented /why/ that is the case, and comments added to ar8035_phy_fixup() in arch/arm/mach-imx/mach-imx6q.c to say why that quirk can't be removed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel