* [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE
@ 2020-12-26 21:04 Pali Rohár
2020-12-29 3:32 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Pali Rohár @ 2020-12-26 21:04 UTC (permalink / raw)
To: u-boot
CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled
CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.
Define this dependency in Kconfig and remove information about this
requirement from documentation file.
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
cmd/Kconfig | 1 +
| 5 -----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 1595de999b..02c28c68bd 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -279,6 +279,7 @@ source lib/efi_selftest/Kconfig
config CMD_BOOTMENU
bool "bootmenu"
select MENU
+ select CFB_CONSOLE_ANSI if CFB_CONSOLE
help
Add an ANSI terminal boot menu command.
--git a/doc/usage/bootmenu.rst b/doc/usage/bootmenu.rst
index 1f094ad6ed..1016ac8ceb 100644
--- a/doc/usage/bootmenu.rst
+++ b/doc/usage/bootmenu.rst
@@ -88,8 +88,3 @@ To run the bootmenu at startup add these additional settings::
CONFIG_AUTOBOOT_KEYED=y
CONFIG_BOOTDELAY=30
CONFIG_AUTOBOOT_MENU_SHOW=y
-
-When you intend to use the bootmenu on a color frame buffer console,
-make sure to additionally define::
-
- CONFIG_CFB_CONSOLE_ANSI=y
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE
2020-12-26 21:04 [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE Pali Rohár
@ 2020-12-29 3:32 ` Simon Glass
2020-12-29 10:42 ` Heinrich Schuchardt
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2020-12-29 3:32 UTC (permalink / raw)
To: u-boot
Hi Paul,
On Sat, 26 Dec 2020 at 14:04, Pali Roh?r <pali@kernel.org> wrote:
>
> CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled
> CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.
>
> Define this dependency in Kconfig and remove information about this
> requirement from documentation file.
>
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> ---
> cmd/Kconfig | 1 +
> doc/usage/bootmenu.rst | 5 -----
> 2 files changed, 1 insertion(+), 5 deletions(-)
This driver is past the driver model migration deadline so we
shouldn't accept patches, except perhaps to migrate or remove it.
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE
2020-12-29 3:32 ` Simon Glass
@ 2020-12-29 10:42 ` Heinrich Schuchardt
2020-12-29 11:26 ` Pali Rohár
0 siblings, 1 reply; 4+ messages in thread
From: Heinrich Schuchardt @ 2020-12-29 10:42 UTC (permalink / raw)
To: u-boot
On 12/29/20 4:32 AM, Simon Glass wrote:
> Hi Paul,
>
> On Sat, 26 Dec 2020 at 14:04, Pali Roh?r <pali@kernel.org> wrote:
>>
>> CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled
>> CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.
>>
>> Define this dependency in Kconfig and remove information about this
>> requirement from documentation file.
>>
>> Signed-off-by: Pali Roh?r <pali@kernel.org>
>> ---
>> cmd/Kconfig | 1 +
>> doc/usage/bootmenu.rst | 5 -----
>> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> This driver is past the driver model migration deadline so we
> shouldn't accept patches, except perhaps to migrate or remove it.
All boards selecting CONFIG_CFB_CONSOLE also select
CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for
existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in
doc/usage/bootmenu.rst.
Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting
used by all driver model video drivers? Shouldn't that setting be
mentioned in doc/usage/bootmenu.rst?
Best regards
Heinrich
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE
2020-12-29 10:42 ` Heinrich Schuchardt
@ 2020-12-29 11:26 ` Pali Rohár
0 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2020-12-29 11:26 UTC (permalink / raw)
To: u-boot
On Tuesday 29 December 2020 11:42:56 Heinrich Schuchardt wrote:
> On 12/29/20 4:32 AM, Simon Glass wrote:
> > Hi Paul,
> >
> > On Sat, 26 Dec 2020 at 14:04, Pali Roh?r <pali@kernel.org> wrote:
> > >
> > > CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled
> > > CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.
> > >
> > > Define this dependency in Kconfig and remove information about this
> > > requirement from documentation file.
> > >
> > > Signed-off-by: Pali Roh?r <pali@kernel.org>
> > > ---
> > > cmd/Kconfig | 1 +
> > > doc/usage/bootmenu.rst | 5 -----
> > > 2 files changed, 1 insertion(+), 5 deletions(-)
> >
> > This driver is past the driver model migration deadline so we
> > shouldn't accept patches, except perhaps to migrate or remove it.
>
> All boards selecting CONFIG_CFB_CONSOLE also select
> CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for
> existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in
> doc/usage/bootmenu.rst.
That is because I added this "hint" into Kconfig. So it does not have to
be specified in documentation rst file.
> Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting
> used by all driver model video drivers? Shouldn't that setting be
> mentioned in doc/usage/bootmenu.rst?
Because I did not know about this option. It was not mentioned in
documentation rst file.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-29 11:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 21:04 [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE Pali Rohár
2020-12-29 3:32 ` Simon Glass
2020-12-29 10:42 ` Heinrich Schuchardt
2020-12-29 11:26 ` Pali Rohár
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.