* [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses)
@ 2020-12-27 17:08 Peter Seiderer
2020-12-27 17:19 ` Peter Seiderer
2020-12-31 16:31 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Peter Seiderer @ 2020-12-27 17:08 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.net/results/26c7536b95cc475bc10d4283e93ea9ccd6ced665
.../arm-buildroot-linux-musleabihf/bin/ld: .../arm-buildroot-linux-musleabihf/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
display.c:(.text+0x1164): undefined reference to `tputs'
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...tatic-linking-readline-needs-ncurses.patch | 31 +++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
diff --git a/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch b/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
new file mode 100644
index 0000000000..a204d982b8
--- /dev/null
+++ b/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
@@ -0,0 +1,31 @@
+From 84a4eb23ccca883d3823785225858bd437e3833a Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sun, 27 Dec 2020 17:56:35 +0100
+Subject: [PATCH] iwctl: fix static linking (readline needs ncurses)
+
+Fixes:
+
+ .../arm-buildroot-linux-musleabihf/bin/ld: .../arm-buildroot-linux-musleabihf/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
+ display.c:(.text+0x1164): undefined reference to `tputs'
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 1f0b0d3..5ae4a98 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -286,7 +286,7 @@ client_iwctl_SOURCES = client/main.c \
+ client/network.h client/network.c \
+ client/properties.h client/properties.c \
+ client/wsc.c client/station.c
+-client_iwctl_LDADD = $(ell_ldadd) -lreadline
++client_iwctl_LDADD = $(ell_ldadd) -lreadline -lncurses
+
+ if MANUAL_PAGES
+ man_MANS += client/iwctl.1
+--
+2.29.2
+
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses)
2020-12-27 17:08 [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses) Peter Seiderer
@ 2020-12-27 17:19 ` Peter Seiderer
2020-12-31 16:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2020-12-27 17:19 UTC (permalink / raw)
To: buildroot
On Sun, 27 Dec 2020 18:08:32 +0100, Peter Seiderer <ps.report@gmx.net> wrote:
> Fixes:
>
> - http://autobuild.buildroot.net/results/26c7536b95cc475bc10d4283e93ea9ccd6ced665
>
> .../arm-buildroot-linux-musleabihf/bin/ld: .../arm-buildroot-linux-musleabihf/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
> display.c:(.text+0x1164): undefined reference to `tputs'
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...tatic-linking-readline-needs-ncurses.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
>
> diff --git a/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch b/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
> new file mode 100644
> index 0000000000..a204d982b8
> --- /dev/null
> +++ b/package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
> @@ -0,0 +1,31 @@
> +From 84a4eb23ccca883d3823785225858bd437e3833a Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Sun, 27 Dec 2020 17:56:35 +0100
> +Subject: [PATCH] iwctl: fix static linking (readline needs ncurses)
> +
> +Fixes:
> +
> + .../arm-buildroot-linux-musleabihf/bin/ld: .../arm-buildroot-linux-musleabihf/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
> + display.c:(.text+0x1164): undefined reference to `tputs'
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + Makefile.am | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index 1f0b0d3..5ae4a98 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -286,7 +286,7 @@ client_iwctl_SOURCES = client/main.c \
> + client/network.h client/network.c \
> + client/properties.h client/properties.c \
> + client/wsc.c client/station.c
> +-client_iwctl_LDADD = $(ell_ldadd) -lreadline
> ++client_iwctl_LDADD = $(ell_ldadd) -lreadline -lncurses
> +
> + if MANUAL_PAGES
> + man_MANS += client/iwctl.1
> +--
> +2.29.2
> +
There is already a prior (and better) fix by Fabrice Fontaine ([1]) which
is accepted upstream ([2])..., forget about this one (and sorry for the
noise)...
Regards,
Peter
[1] http://lists.busybox.net/pipermail/buildroot/2020-December/298672.html
[2] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=62d31539d6e31a40d7d33c73637e37b50c59ef40
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses)
2020-12-27 17:08 [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses) Peter Seiderer
2020-12-27 17:19 ` Peter Seiderer
@ 2020-12-31 16:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-12-31 16:31 UTC (permalink / raw)
To: buildroot
On Sun, 27 Dec 2020 18:08:32 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> Fixes:
>
> - http://autobuild.buildroot.net/results/26c7536b95cc475bc10d4283e93ea9ccd6ced665
>
> .../arm-buildroot-linux-musleabihf/bin/ld: .../arm-buildroot-linux-musleabihf/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
> display.c:(.text+0x1164): undefined reference to `tputs'
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...tatic-linking-readline-needs-ncurses.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/iwd/0001-iwctl-fix-static-linking-readline-needs-ncurses.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-31 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 17:08 [Buildroot] [PATCH v1] package/iwd: fix static linking (readline needs ncurses) Peter Seiderer
2020-12-27 17:19 ` Peter Seiderer
2020-12-31 16:31 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.