All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/4] lib/i915/perf: fill up reader devinfo default field
Date: Mon, 28 Dec 2020 05:19:39 +0200	[thread overview]
Message-ID: <20201228031940.178954-3-lionel.g.landwerlin@intel.com> (raw)
In-Reply-To: <20201228031940.178954-1-lionel.g.landwerlin@intel.com>

A bunch of fields were left to 0...

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 43116ee368585d ("lib/i915-perf: add i915 perf data reader")
---
 lib/i915/perf_data_reader.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/i915/perf_data_reader.c b/lib/i915/perf_data_reader.c
index 3b05a2e54..4b68fb502 100644
--- a/lib/i915/perf_data_reader.c
+++ b/lib/i915/perf_data_reader.c
@@ -119,12 +119,13 @@ find_metric_set(struct intel_perf *perf, const char *symbol_name)
 
 static void
 init_devinfo(struct intel_perf_devinfo *perf_devinfo,
+	     struct intel_perf *perf,
 	     const struct intel_device_info *devinfo,
 	     uint32_t devid,
 	     uint64_t timestamp_frequency)
 {
+	*perf_devinfo = perf->devinfo;
 	perf_devinfo->devid = devid;
-	perf_devinfo->gen = devinfo->gen;
 	perf_devinfo->timestamp_frequency = timestamp_frequency;
 }
 
@@ -203,15 +204,15 @@ parse_data(struct intel_perf_data_reader *reader)
 		return false;
 	}
 
-	init_devinfo(&reader->devinfo, devinfo,
-		     record_info->device_id,
-		     record_info->timestamp_frequency);
 	reader->perf = intel_perf_for_devinfo(record_info->device_id,
 					      record_info->device_revision,
 					      record_info->timestamp_frequency,
 					      record_info->gt_min_frequency,
 					      record_info->gt_max_frequency,
 					      &record_topology->topology);
+	init_devinfo(&reader->devinfo, reader->perf, devinfo,
+		     record_info->device_id,
+		     record_info->timestamp_frequency);
 
 	reader->metric_set_name = record_info->metric_set_name;
 	reader->metric_set_uuid = record_info->metric_set_uuid;
-- 
2.30.0.rc2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-12-28  3:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28  3:19 [igt-dev] [PATCH i-g-t 1/4] lib/i915/perf: fix intel_perf_devinfo gen field Lionel Landwerlin
2020-12-28  3:19 ` [igt-dev] [PATCH i-g-t 2/4] lib/i915/perf: fill up device name Lionel Landwerlin
2021-01-07  0:09   ` Umesh Nerlige Ramappa
2020-12-28  3:19 ` Lionel Landwerlin [this message]
2021-01-07  0:23   ` [igt-dev] [PATCH i-g-t 3/4] lib/i915/perf: fill up reader devinfo default field Umesh Nerlige Ramappa
2021-01-07 10:03     ` Lionel Landwerlin
2021-01-07 21:49       ` Umesh Nerlige Ramappa
2020-12-28  3:19 ` [igt-dev] [PATCH i-g-t 4/4] lib/i915/perf: don't forget last timeline element Lionel Landwerlin
2021-01-07  1:07   ` Umesh Nerlige Ramappa
2021-01-07 10:12     ` Lionel Landwerlin
2021-01-07 21:44       ` Umesh Nerlige Ramappa
2020-12-28  3:53 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/i915/perf: fix intel_perf_devinfo gen field Patchwork
2020-12-28  5:09 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-07  0:07 ` [igt-dev] [PATCH i-g-t 1/4] " Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201228031940.178954-3-lionel.g.landwerlin@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.