From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E8A3C433E0 for ; Mon, 28 Dec 2020 23:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 618ED2222A for ; Mon, 28 Dec 2020 23:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731156AbgL1W4B (ORCPT ); Mon, 28 Dec 2020 17:56:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:47772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729431AbgL1Ujr (ORCPT ); Mon, 28 Dec 2020 15:39:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC7C5222B3; Mon, 28 Dec 2020 20:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609187947; bh=VTWjReRS4Z3OBvORpv7OORcjw+MCvDX/NCFz7CoDXW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y23hlb09w0/oRIEHJpjilrTMMORnC6qmkyLC4jxkcp6YcWlpxOUcGVUOfwaKeiBl1 wUCLoLHUkWmbutS2FWw4qGTiLqMeOmyQBIQeXsL/8yAZUDdpCgYACLTW2hP1kHmds8 PZW/BaxOTU4C3glzebGFNSLrC/+mdG8urrFXmMX5QijMPTtp8ipFDf0pXw5JGh/6Az cw2cnfnEVpI7vyYDn5FLTOc67Vry3Np6zEjbWg/C/I+RoK0YH4elaiZiv7niS54D8s Lcvog+wj+cE3FpGejE1ZCExsqoA/hYzN8rPYsKD/6NbzjKfT1ZV1A/s0etGcfALlBZ ycmM9nBREEkgg== Date: Mon, 28 Dec 2020 12:39:06 -0800 From: Jakub Kicinski To: Sieng Piaw Liew Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver Message-ID: <20201228123906.69b929e5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201224142421.32350-1-liew.s.piaw@gmail.com> References: <20201224142421.32350-1-liew.s.piaw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2020 22:24:15 +0800 Sieng Piaw Liew wrote: > This patch series aim to improve the bcm63xx_enet driver by integrating the > latest networking features, i.e. batched rx processing, BQL, build_skb, etc. > > The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding > NET_IP_ALIGN padding which, combined with these patches, improved packet > processing performance by ~50% on BCM6328. > > Older non-enetsw SoCs still benefit mainly from rx batching. Performance > improvement of ~30% is observed on BCM6333. > > The BCM63xx SoCs are designed for routers. As such, having BQL is beneficial > as well as trivial to add. Hopefully we can get some reviews now, but for inclusion in the tree you'll need to repost once net-next opens (should happen in the next few days): http://vger.kernel.org/~davem/net-next.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A86FC433E0 for ; Mon, 28 Dec 2020 20:40:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5565B222B3 for ; Mon, 28 Dec 2020 20:40:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5565B222B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n4P7WUfyDa8IU2SRRbm+OE4JN/kNfGh6BLmx+DHEOT0=; b=PhdW2Aku9YT1bJ4r5MWU+lfFL QfSMkfJGpbBXM064Imgv5rQBrpwB+mc3MXMyZJWksIBVfKQRA5oL9T8FZUQtv4pLeyRoFbZb3TMP1 xrlI5xQdmhL39/pkazTZddtwbI3uh62omaDUyNleLPjaBf/wMWAiNZKYAnKjkXksyJk9hvry/Grp2 YpYOgQokRlHFsO24//2kntvo1Wqm4UaMl27G8yqoU6yBeTP5yL49yKBOk/BUxzwfXcCndMf95zMNW VgF/cwFOl2/iiuROq0QRpaXK4b/BLK5RS83Ice+sNNWkY56dhZKdRiSPIFI6VZvY8W1rbk710JHi1 zegbo2wAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktzIL-0000Yp-Fe; Mon, 28 Dec 2020 20:39:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktzIJ-0000YP-Px for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 20:39:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC7C5222B3; Mon, 28 Dec 2020 20:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609187947; bh=VTWjReRS4Z3OBvORpv7OORcjw+MCvDX/NCFz7CoDXW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y23hlb09w0/oRIEHJpjilrTMMORnC6qmkyLC4jxkcp6YcWlpxOUcGVUOfwaKeiBl1 wUCLoLHUkWmbutS2FWw4qGTiLqMeOmyQBIQeXsL/8yAZUDdpCgYACLTW2hP1kHmds8 PZW/BaxOTU4C3glzebGFNSLrC/+mdG8urrFXmMX5QijMPTtp8ipFDf0pXw5JGh/6Az cw2cnfnEVpI7vyYDn5FLTOc67Vry3Np6zEjbWg/C/I+RoK0YH4elaiZiv7niS54D8s Lcvog+wj+cE3FpGejE1ZCExsqoA/hYzN8rPYsKD/6NbzjKfT1ZV1A/s0etGcfALlBZ ycmM9nBREEkgg== Date: Mon, 28 Dec 2020 12:39:06 -0800 From: Jakub Kicinski To: Sieng Piaw Liew Subject: Re: [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver Message-ID: <20201228123906.69b929e5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201224142421.32350-1-liew.s.piaw@gmail.com> References: <20201224142421.32350-1-liew.s.piaw@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_153907_933266_53D216E8 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 24 Dec 2020 22:24:15 +0800 Sieng Piaw Liew wrote: > This patch series aim to improve the bcm63xx_enet driver by integrating the > latest networking features, i.e. batched rx processing, BQL, build_skb, etc. > > The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding > NET_IP_ALIGN padding which, combined with these patches, improved packet > processing performance by ~50% on BCM6328. > > Older non-enetsw SoCs still benefit mainly from rx batching. Performance > improvement of ~30% is observed on BCM6333. > > The BCM63xx SoCs are designed for routers. As such, having BQL is beneficial > as well as trivial to add. Hopefully we can get some reviews now, but for inclusion in the tree you'll need to repost once net-next opens (should happen in the next few days): http://vger.kernel.org/~davem/net-next.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel