From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A81C433E6 for ; Mon, 28 Dec 2020 23:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59C6F22482 for ; Mon, 28 Dec 2020 23:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731188AbgL1W4C (ORCPT ); Mon, 28 Dec 2020 17:56:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:47874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729433AbgL1UlF (ORCPT ); Mon, 28 Dec 2020 15:41:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4F98222B3; Mon, 28 Dec 2020 20:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609188025; bh=KcZQ6o41rlq4RH1a4W27CrNjjwRWrvYAisvQC5+hb/M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HRxe6sPWVmeHl9CauFK/gog0Ri0Mh//aoaIozuEbcAX8W8ciyeRbRMWxsobPxSGdh FwVl56MVcRvwQz/hIcr4yPFiuTGcxNNCW7qE6dcmBTenrelSGkW2i3xC46mpYC9Q2Q QxW2J+IMs4hOL3tGnuDpcchkjEBM5LIUKrO++DD3YMio5C42qmZP8cs7EumnsSrn0K HnCC3WGXvq79HilrAFrxu//+aX5/FhykA+hFpO0/wkyDK0XeB6DKWPVhnCkYpZL+yE YpWxbHU8YyKCkA6CYE/opNDjDPqLZPggsK5ETI1a/RNOESRBlKiidBnWfOqH3e3krc Ld+aczWEy7bfw== Date: Mon, 28 Dec 2020 12:40:24 -0800 From: Jakub Kicinski To: Sieng Piaw Liew Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support Message-ID: <20201228124024.32ceb0fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201224142421.32350-4-liew.s.piaw@gmail.com> References: <20201224142421.32350-1-liew.s.piaw@gmail.com> <20201224142421.32350-4-liew.s.piaw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2020 22:24:18 +0800 Sieng Piaw Liew wrote: > Support bulking hardware TX queue by using netdev_xmit_more(). > > Signed-off-by: Sieng Piaw Liew > --- > drivers/net/ethernet/broadcom/bcm63xx_enet.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > index 90f8214b4d22..452968f168ed 100644 > --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c > +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > @@ -633,14 +633,17 @@ bcm_enet_start_xmit(struct sk_buff *skb, struct net_device *dev) > > netdev_sent_queue(dev, skb->len); > > - /* kick tx dma */ > - enet_dmac_writel(priv, priv->dma_chan_en_mask, > - ENETDMAC_CHANCFG, priv->tx_chan); > - > /* stop queue if no more desc available */ > if (!priv->tx_desc_count) > netif_stop_queue(dev); > > + /* kick tx dma */ > + if (!netdev_xmit_more() || !priv->tx_desc_count) > + enet_dmac_writel(priv, priv->dma_chan_en_mask, > + ENETDMAC_CHANCFG, priv->tx_chan); > + > + > + > dev->stats.tx_bytes += skb->len; > dev->stats.tx_packets++; > ret = NETDEV_TX_OK; Please address checkpatch --strict issues throughout the series: ERROR: code indent should use tabs where possible #31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641: + if (!netdev_xmit_more() || !priv->tx_desc_count)$ WARNING: please, no spaces at the start of a line #31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641: + if (!netdev_xmit_more() || !priv->tx_desc_count)$ ERROR: code indent should use tabs where possible #32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642: + enet_dmac_writel(priv, priv->dma_chan_en_mask,$ WARNING: please, no spaces at the start of a line #32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642: + enet_dmac_writel(priv, priv->dma_chan_en_mask,$ ERROR: code indent should use tabs where possible #33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643: + ENETDMAC_CHANCFG, priv->tx_chan);$ WARNING: please, no spaces at the start of a line #33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643: + ENETDMAC_CHANCFG, priv->tx_chan);$ CHECK: Please don't use multiple blank lines #35: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:645: + + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED18BC433E0 for ; Mon, 28 Dec 2020 20:41:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2FAF222B3 for ; Mon, 28 Dec 2020 20:41:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2FAF222B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mna3x4XDRVoKT3Wp4vMf+cBZH72xH4MEqMZZRO1SSZs=; b=D8AY0SmZ2cbDhaYanOjnFeXCb RBhRlnovQ4qSppm89z1zF5zuJjlj7hsLgDgoKSg4EwuWDfWFn+eDAeJQM16A8UXe81e1y+VeTB8mw tVP6yiG1AlU9fErhcwubnJAAJVGlRfvnPIr0orH66+pqdAbDGz2TXUvUsjzwKpRdbda0CLy2Vmx3J TSZj2Rk4gGnaAwW54zFTGHreJs2fuB99Wi79sbZebsnumR4woN4Yb+XvYKngYt/jRllY8YL82cRML PJiPxwCNyBXrIhBUy7mh6olAqAzHEuwNnNSYsqdtdkod/kyWGn/cm2OHAOji8DU2QI7TU8fyo/H8j 9lYGP8Yvg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktzJb-0000lw-Ll; Mon, 28 Dec 2020 20:40:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktzJZ-0000lI-SC for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 20:40:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4F98222B3; Mon, 28 Dec 2020 20:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609188025; bh=KcZQ6o41rlq4RH1a4W27CrNjjwRWrvYAisvQC5+hb/M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HRxe6sPWVmeHl9CauFK/gog0Ri0Mh//aoaIozuEbcAX8W8ciyeRbRMWxsobPxSGdh FwVl56MVcRvwQz/hIcr4yPFiuTGcxNNCW7qE6dcmBTenrelSGkW2i3xC46mpYC9Q2Q QxW2J+IMs4hOL3tGnuDpcchkjEBM5LIUKrO++DD3YMio5C42qmZP8cs7EumnsSrn0K HnCC3WGXvq79HilrAFrxu//+aX5/FhykA+hFpO0/wkyDK0XeB6DKWPVhnCkYpZL+yE YpWxbHU8YyKCkA6CYE/opNDjDPqLZPggsK5ETI1a/RNOESRBlKiidBnWfOqH3e3krc Ld+aczWEy7bfw== Date: Mon, 28 Dec 2020 12:40:24 -0800 From: Jakub Kicinski To: Sieng Piaw Liew Subject: Re: [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support Message-ID: <20201228124024.32ceb0fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201224142421.32350-4-liew.s.piaw@gmail.com> References: <20201224142421.32350-1-liew.s.piaw@gmail.com> <20201224142421.32350-4-liew.s.piaw@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_154026_004996_476395CB X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 24 Dec 2020 22:24:18 +0800 Sieng Piaw Liew wrote: > Support bulking hardware TX queue by using netdev_xmit_more(). > > Signed-off-by: Sieng Piaw Liew > --- > drivers/net/ethernet/broadcom/bcm63xx_enet.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > index 90f8214b4d22..452968f168ed 100644 > --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c > +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > @@ -633,14 +633,17 @@ bcm_enet_start_xmit(struct sk_buff *skb, struct net_device *dev) > > netdev_sent_queue(dev, skb->len); > > - /* kick tx dma */ > - enet_dmac_writel(priv, priv->dma_chan_en_mask, > - ENETDMAC_CHANCFG, priv->tx_chan); > - > /* stop queue if no more desc available */ > if (!priv->tx_desc_count) > netif_stop_queue(dev); > > + /* kick tx dma */ > + if (!netdev_xmit_more() || !priv->tx_desc_count) > + enet_dmac_writel(priv, priv->dma_chan_en_mask, > + ENETDMAC_CHANCFG, priv->tx_chan); > + > + > + > dev->stats.tx_bytes += skb->len; > dev->stats.tx_packets++; > ret = NETDEV_TX_OK; Please address checkpatch --strict issues throughout the series: ERROR: code indent should use tabs where possible #31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641: + if (!netdev_xmit_more() || !priv->tx_desc_count)$ WARNING: please, no spaces at the start of a line #31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641: + if (!netdev_xmit_more() || !priv->tx_desc_count)$ ERROR: code indent should use tabs where possible #32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642: + enet_dmac_writel(priv, priv->dma_chan_en_mask,$ WARNING: please, no spaces at the start of a line #32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642: + enet_dmac_writel(priv, priv->dma_chan_en_mask,$ ERROR: code indent should use tabs where possible #33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643: + ENETDMAC_CHANCFG, priv->tx_chan);$ WARNING: please, no spaces at the start of a line #33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643: + ENETDMAC_CHANCFG, priv->tx_chan);$ CHECK: Please don't use multiple blank lines #35: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:645: + + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel