From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509EAC433E9 for ; Mon, 28 Dec 2020 16:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33877208B6 for ; Mon, 28 Dec 2020 16:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633610AbgL1Q3P (ORCPT ); Mon, 28 Dec 2020 11:29:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:37112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633593AbgL1Q3J (ORCPT ); Mon, 28 Dec 2020 11:29:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 88697221F0; Mon, 28 Dec 2020 16:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609172909; bh=VxLb1NE5v3gUQB+uN9sYmxNLNiDC+v0OejAmpaBY2jU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BxsD43eSjbT4RSvYseAjen0QXSJvvyGe5XMmO00tHelZvwDBYwKhZGEyE6okn2CLT DSOFVu0whrMHOwy6aV2OnxgULNod+u6ADc/2f23hC1O8gYd8fdUjzGKHo701kmMc6t qL6vUIbLJEqTkAHsFuf/dhQhhIExQpENU+W9aH65+bxoizh2amiGp7doti9aw/TiCt kinZxltZ+xUyXri1L/OOIbPC1xIKm6bTqv6bATeMFyeEPeqRyjn1hwsEXBFxQkBvHk cgmcu4aFoVPo/HyCCCxk4pNTD8ozsUsV2o+FALQaBUNvpNRJgqpfqfQ+R3EF5hT7x0 NqD2cfNioV5EA== Date: Mon, 28 Dec 2020 16:28:07 +0000 From: Mark Brown To: Hans de Goede Cc: Lee Jones , MyungJoo Ham , Chanwoo Choi , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona Message-ID: <20201228162807.GE5352@sirena.org.uk> References: <20201227211232.117801-1-hdegoede@redhat.com> <20201227211232.117801-2-hdegoede@redhat.com> <20201228122138.GA5352@sirena.org.uk> <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline In-Reply-To: <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> X-Cookie: To see you is to sympathize. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: > And more in general AFAIK extcon is sort of deprecated and it is > not advised to use it for new code. I would esp. not expect it to > be used for new jack-detection code since we already have standard > uAPI support for that through sound/core/jack.c . Has Android been fixed to use the ALSA/input layer interfaces? That's why that code is there, long term the goal was to have ALSA generate extcon events too so userspace could fall over to using that. The basic thing at the time was that nobody liked any of the existing interfaces (the input layer thing is a total bodge stemming from it having been easy to hack in a key for GPIO detection and using ALSA controls means having to link against alsa-lib which is an awful faff for system level UI stuff) and there were three separate userspace interfaces used by different software stacks which needed to be joined together, extcon was felt to be a bit more designed and is a superset so that was the direction we were heading in. --9l24NVCWtSuIVIod Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/qB5YACgkQJNaLcl1U h9DqBwf9HlPB/OmyZntM7voe64geHoxkfPxY7efoEImrcbnYvzdEY/pdORxcLO00 98rT1ezO5jFJHAbH3sO8fz0m/93Yk0z3IDSuLexoQhtP9bK3hDs5u5jWrYlHMOFz 3OFcOctzSUSfOapMPJFQXzxjEiSnNyAdJterGKhHAB+qDkxi29C6iLl7fW7k7ymT lHgKGSNor058sVZbrajgw2J8iG0aXrEvW9Tau4/pAt1TVF6FmQLj0pQXjo7r/9ga gkp6C2bsLSeCx3WSujI/MllT94v48jbPZY1801oxseN7c68+gNF2m2lEmvIr03LS eAdKVMt/V2KU2wSqSn6Z2iWJj7aHvA== =/OaN -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D49C433DB for ; Mon, 28 Dec 2020 16:29:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42F27208B6 for ; Mon, 28 Dec 2020 16:29:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42F27208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 22B6A1743; Mon, 28 Dec 2020 17:28:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 22B6A1743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609172974; bh=VxLb1NE5v3gUQB+uN9sYmxNLNiDC+v0OejAmpaBY2jU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cAakgXmLJlc4JVCLKJex0c5SsOvtQOrD+F/SeQu6DtaaASMBm80Ps5WDS8aG/S7kA 8hC7LASHjF2EpS2lFIrn29qC1TSi3QNuSUd4Yb1EeeS3uy2kO7AiXoXKLoaJRpPhl+ tWXzZL+p/cCsAFsCbkmTNP1nFHYqR+I+H4j48y+o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 76A3AF801ED; Mon, 28 Dec 2020 17:28:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA4FEF801F5; Mon, 28 Dec 2020 17:28:36 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 60ABBF80143 for ; Mon, 28 Dec 2020 17:28:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 60ABBF80143 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BxsD43eS" Received: by mail.kernel.org (Postfix) with ESMTPSA id 88697221F0; Mon, 28 Dec 2020 16:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609172909; bh=VxLb1NE5v3gUQB+uN9sYmxNLNiDC+v0OejAmpaBY2jU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BxsD43eSjbT4RSvYseAjen0QXSJvvyGe5XMmO00tHelZvwDBYwKhZGEyE6okn2CLT DSOFVu0whrMHOwy6aV2OnxgULNod+u6ADc/2f23hC1O8gYd8fdUjzGKHo701kmMc6t qL6vUIbLJEqTkAHsFuf/dhQhhIExQpENU+W9aH65+bxoizh2amiGp7doti9aw/TiCt kinZxltZ+xUyXri1L/OOIbPC1xIKm6bTqv6bATeMFyeEPeqRyjn1hwsEXBFxQkBvHk cgmcu4aFoVPo/HyCCCxk4pNTD8ozsUsV2o+FALQaBUNvpNRJgqpfqfQ+R3EF5hT7x0 NqD2cfNioV5EA== Date: Mon, 28 Dec 2020 16:28:07 +0000 From: Mark Brown To: Hans de Goede Subject: Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona Message-ID: <20201228162807.GE5352@sirena.org.uk> References: <20201227211232.117801-1-hdegoede@redhat.com> <20201227211232.117801-2-hdegoede@redhat.com> <20201228122138.GA5352@sirena.org.uk> <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline In-Reply-To: <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> X-Cookie: To see you is to sympathize. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Cezary Rojewski , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Chanwoo Choi , MyungJoo Ham , Lee Jones X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: > And more in general AFAIK extcon is sort of deprecated and it is > not advised to use it for new code. I would esp. not expect it to > be used for new jack-detection code since we already have standard > uAPI support for that through sound/core/jack.c . Has Android been fixed to use the ALSA/input layer interfaces? That's why that code is there, long term the goal was to have ALSA generate extcon events too so userspace could fall over to using that. The basic thing at the time was that nobody liked any of the existing interfaces (the input layer thing is a total bodge stemming from it having been easy to hack in a key for GPIO detection and using ALSA controls means having to link against alsa-lib which is an awful faff for system level UI stuff) and there were three separate userspace interfaces used by different software stacks which needed to be joined together, extcon was felt to be a bit more designed and is a superset so that was the direction we were heading in. --9l24NVCWtSuIVIod Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/qB5YACgkQJNaLcl1U h9DqBwf9HlPB/OmyZntM7voe64geHoxkfPxY7efoEImrcbnYvzdEY/pdORxcLO00 98rT1ezO5jFJHAbH3sO8fz0m/93Yk0z3IDSuLexoQhtP9bK3hDs5u5jWrYlHMOFz 3OFcOctzSUSfOapMPJFQXzxjEiSnNyAdJterGKhHAB+qDkxi29C6iLl7fW7k7ymT lHgKGSNor058sVZbrajgw2J8iG0aXrEvW9Tau4/pAt1TVF6FmQLj0pQXjo7r/9ga gkp6C2bsLSeCx3WSujI/MllT94v48jbPZY1801oxseN7c68+gNF2m2lEmvIr03LS eAdKVMt/V2KU2wSqSn6Z2iWJj7aHvA== =/OaN -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod--