Re: [PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3898 bytes --]

Hi Hans,

I love your patch! Yet something to improve:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on chanwoo-extcon/extcon-next asoc/for-next v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/MFD-extcon-ASoC-Add-support-for-Intel-Bay-Trail-boards-with-WM5102-codec/20201228-051806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: alpha-randconfig-r035-20201228 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bc64046ad088b340f127f9eefdb8f941c03dcb53
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hans-de-Goede/MFD-extcon-ASoC-Add-support-for-Intel-Bay-Trail-boards-with-WM5102-codec/20201228-051806
        git checkout bc64046ad088b340f127f9eefdb8f941c03dcb53
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mfd/arizona-spi.c: In function 'arizona_spi_probe':
>> drivers/mfd/arizona-spi.c:192:7: error: void value not ignored as it ought to be
     192 |   ret = arizona_spi_acpi_probe(arizona);
         |       ^


vim +192 drivers/mfd/arizona-spi.c

   133	
   134	static int arizona_spi_probe(struct spi_device *spi)
   135	{
   136		const struct spi_device_id *id = spi_get_device_id(spi);
   137		struct arizona *arizona;
   138		const struct regmap_config *regmap_config = NULL;
   139		unsigned long type;
   140		int ret;
   141	
   142		if (spi->dev.of_node)
   143			type = arizona_of_get_type(&spi->dev);
   144		else if (ACPI_COMPANION(&spi->dev))
   145			type = (unsigned long)acpi_device_get_match_data(&spi->dev);
   146		else
   147			type = id->driver_data;
   148	
   149		switch (type) {
   150		case WM5102:
   151			if (IS_ENABLED(CONFIG_MFD_WM5102))
   152				regmap_config = &wm5102_spi_regmap;
   153			break;
   154		case WM5110:
   155		case WM8280:
   156			if (IS_ENABLED(CONFIG_MFD_WM5110))
   157				regmap_config = &wm5110_spi_regmap;
   158			break;
   159		case WM1831:
   160		case CS47L24:
   161			if (IS_ENABLED(CONFIG_MFD_CS47L24))
   162				regmap_config = &cs47l24_spi_regmap;
   163			break;
   164		default:
   165			dev_err(&spi->dev, "Unknown device type %ld\n", type);
   166			return -EINVAL;
   167		}
   168	
   169		if (!regmap_config) {
   170			dev_err(&spi->dev,
   171				"No kernel support for device type %ld\n", type);
   172			return -EINVAL;
   173		}
   174	
   175		arizona = devm_kzalloc(&spi->dev, sizeof(*arizona), GFP_KERNEL);
   176		if (arizona == NULL)
   177			return -ENOMEM;
   178	
   179		arizona->regmap = devm_regmap_init_spi(spi, regmap_config);
   180		if (IS_ERR(arizona->regmap)) {
   181			ret = PTR_ERR(arizona->regmap);
   182			dev_err(&spi->dev, "Failed to allocate register map: %d\n",
   183				ret);
   184			return ret;
   185		}
   186	
   187		arizona->type = type;
   188		arizona->dev = &spi->dev;
   189		arizona->irq = spi->irq;
   190	
   191		if (ACPI_COMPANION(&spi->dev)) {
 > 192			ret = arizona_spi_acpi_probe(arizona);
   193			if (ret)
   194				return ret;
   195		}
   196	
   197		return arizona_dev_init(arizona);
   198	}
   199	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29140 bytes --]