From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB654C433E0 for ; Tue, 29 Dec 2020 23:14:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 15C5721D1B for ; Tue, 29 Dec 2020 23:14:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15C5721D1B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DABB52B91; Wed, 30 Dec 2020 00:14:02 +0100 (CET) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by dpdk.org (Postfix) with ESMTP id B6DBC2B8E for ; Wed, 30 Dec 2020 00:14:00 +0100 (CET) Received: by mail-lf1-f47.google.com with SMTP id h205so34087227lfd.5 for ; Tue, 29 Dec 2020 15:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rAAZDTqJeMYi2ogScS+DddIUx/QKxLJToKADznq/SJE=; b=Jdpt6XdP+m1R3tFBSN5LeI0RtOWkEO75mHbhpWdS9Ep5EQmb9ENUaMF63G/BFa7NPL 7EjAd7YWI5d/4z7sNR25JXM2KYfC44D3439d5Ek58zMU7nd5hAGQVNqlrmEIiKNzN20O QmVOQCEjwM27MJJ3fH8IM3KbSFY04lS2jxnpGjyLayp2vwv4+TrTLNSd5Cb7f2mgPJCR azm+0RJpImgc73Mx2wzkfnXP727Fwyh90C2QX1I5bmAe4gRFHNiiikNrHMvp9xe0pXLd XlPpfTR/cHFZ2hgh+nMwDExzEbrhbcF35Mz3oEmMyl3691uID9+4n+z5pDiZ0OOVmqIi Vh3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rAAZDTqJeMYi2ogScS+DddIUx/QKxLJToKADznq/SJE=; b=sLO3ytT1EUIDyMCD/5XuPhuD6IrtXGlpf/IoVZgyPWE1qESaR1dt1vBsNGntAiU14i +VmxxJkmmJ592tKUHSvW1XKYm/kbbumzNL1yRhUhXSIHUj7zAZ3E7lzJHAGFX+Iqi9Sm pr8sQQm/tUT+YqEeBS+zpaeoOGJbyD+FTBmAX61kV3QkkLD2mN9kPtpmjYU9nHQeJaOq q7Xho9H88GACtIPI5LetucAir2/c9ZadUFX2zMq5aPpXwp3Abrqq2oE4PiZ+fpknqX8T 5Pko1dmY+R9cLojuK4BA+aqKwBJ2Y988o5e2pfRJyK0gHQzIDaibkhOL3wEAtJiZVI25 ToTA== X-Gm-Message-State: AOAM533TXmGEJhmuOXHHErfuPKnc8GP+2M/ezoz8QVF+N8PtNDLudbKH EvWelbAY3aq2nFBWQbVTLbM= X-Google-Smtp-Source: ABdhPJzv+0vzUTTQxDO9kBebHq3QPPI29zCNKRhB7qjOQzY7ZwUj2FSnxXXzbIFNgby3I2lf7ayCUg== X-Received: by 2002:a2e:900c:: with SMTP id h12mr24293287ljg.451.1609283639241; Tue, 29 Dec 2020 15:13:59 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id c24sm7031307ljn.116.2020.12.29.15.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 15:13:58 -0800 (PST) Date: Wed, 30 Dec 2020 02:13:57 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com Message-ID: <20201230021357.3d6ca19e@sovereign> In-Reply-To: <20201226160848.9824-1-talshn@nvidia.com> References: <20201222073044.9084-1-talshn@nvidia.com> <20201226160848.9824-1-talshn@nvidia.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] eal: add generic thread-local-storage functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 26 Dec 2020 18:08:48 +0200, Tal Shnaiderman wrote: > diff --git a/lib/librte_eal/windows/meson.build b/lib/librte_eal/windows/meson.build > index 3b2faf29eb..f4c3e2f12c 100644 > --- a/lib/librte_eal/windows/meson.build > +++ b/lib/librte_eal/windows/meson.build > @@ -21,4 +21,10 @@ sources += files( > 'getopt.c', > ) > > +if (dpdk_conf.has('use_windows_pthread')) > + sources += 'librte_eal/common/rte_thread.c' > +else > + sources += 'librte_eal/windows/rte_thread.c' > +endif > + You need get_option(), not dpdk_conf (apologies again for not being precise when I drafted the approach): --- a/lib/librte_eal/windows/meson.build +++ b/lib/librte_eal/windows/meson.build @@ -21,7 +21,7 @@ sources += files( 'getopt.c', ) -if (dpdk_conf.has('use_windows_pthread')) +if get_option('use_windows_pthread') sources += 'librte_eal/common/rte_thread.c' else sources += 'librte_eal/windows/rte_thread.c' Worse, with -Duse_windows_pthread=true file in common directory includes , but it finds pthread shim from windows subdirectory, not the file from external library or MinGW toolchain. So the option is not usable until the shim exists. I suggest removing the option for now, let's reintroduce it when rte_thread.h grows and the shim goes away.