From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3977AC433E6 for ; Wed, 30 Dec 2020 08:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDCD8207A9 for ; Wed, 30 Dec 2020 08:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgL3ItQ (ORCPT ); Wed, 30 Dec 2020 03:49:16 -0500 Received: from muru.com ([72.249.23.125]:40560 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgL3ItP (ORCPT ); Wed, 30 Dec 2020 03:49:15 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6407780BA; Wed, 30 Dec 2020 08:48:47 +0000 (UTC) Date: Wed, 30 Dec 2020 10:48:30 +0200 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Andreas Kemnade , kernel@pyra-handheld.com, stable@vger.kernel.org Subject: Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low Message-ID: <20201230084830.GG26857@atomide.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [201223 12:33]: > With the arrival of > > commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors") > > it was clarified what the proper state for cs-gpios should be, even if the > flag is ignored. The driver code is doing the right thing since > > 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") > > The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high; > attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for > the client device description to be fully consistent. Applying into fixes thanks. Tony