All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
@ 2020-12-30 10:37 Chris Wilson
  2020-12-30 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Chris Wilson @ 2020-12-30 10:37 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

The timeouts are frequent and expected. We will complain if we retry so
often as to lose patience and give up, so the cacophony from individual
complaints is redundant.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 8ae769b18879..704e4cebf7f3 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	/* Timeouts occur when the device isn't connected, so they're
 	 * "normal" -- don't fill the kernel log with these */
 	if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
-		drm_dbg_kms(&i915->drm, "%s: timeout (status 0x%08x)\n",
-			    intel_dp->aux.name, status);
 		ret = -ETIMEDOUT;
 		goto out;
 	}
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-30 10:37 [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message Chris Wilson
@ 2020-12-30 12:20 ` Patchwork
  2020-12-30 13:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  2020-12-31  0:02 ` [Intel-gfx] [PATCH] " Matt Roper
  2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-30 12:20 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 3241 bytes --]

== Series Details ==

Series: drm/i915/dp: Remove aux xfer timeout debug message
URL   : https://patchwork.freedesktop.org/series/85313/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9533 -> Patchwork_19226
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/index.html

Known issues
------------

  Here are the changes found in Patchwork_19226 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gem:
    - fi-bsw-n3050:       [PASS][1] -> [DMESG-WARN][2] ([i915#2826])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/fi-bsw-n3050/igt@i915_selftest@live@gem.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/fi-bsw-n3050/igt@i915_selftest@live@gem.html

  * igt@i915_selftest@live@gem_contexts:
    - fi-bsw-n3050:       [PASS][3] -> [INCOMPLETE][4] ([i915#2369])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/fi-bsw-n3050/igt@i915_selftest@live@gem_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/fi-bsw-n3050/igt@i915_selftest@live@gem_contexts.html

  * igt@prime_self_import@basic-with_one_bo:
    - fi-tgl-y:           [PASS][5] -> [DMESG-WARN][6] ([i915#402])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html

  * igt@runner@aborted:
    - fi-bsw-n3050:       NOTRUN -> [FAIL][7] ([i915#1436] / [i915#483])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/fi-bsw-n3050/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@prime_vgem@basic-fence-flip:
    - fi-tgl-y:           [DMESG-WARN][8] ([i915#402]) -> [PASS][9] +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html

  
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
  [i915#2826]: https://gitlab.freedesktop.org/drm/intel/issues/2826
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483


Participating hosts (42 -> 37)
------------------------------

  Missing    (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_9533 -> Patchwork_19226

  CI-20190529: 20190529
  CI_DRM_9533: 1ebc67e5e636a2422ac68d93b87e236dcf645da0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5928: 7813bb74aec408055d564fa6a270526822cfbc0e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19226: 10dcc8bfb71c1a6b5122fcf486ffa184c081c383 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

10dcc8bfb71c drm/i915/dp: Remove aux xfer timeout debug message

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/index.html

[-- Attachment #1.2: Type: text/html, Size: 4020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-30 10:37 [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message Chris Wilson
  2020-12-30 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-12-30 13:36 ` Patchwork
  2020-12-31  0:02 ` [Intel-gfx] [PATCH] " Matt Roper
  2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-30 13:36 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 18610 bytes --]

== Series Details ==

Series: drm/i915/dp: Remove aux xfer timeout debug message
URL   : https://patchwork.freedesktop.org/series/85313/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9533_full -> Patchwork_19226_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_19226_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [PASS][1] -> [SKIP][2] ([i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-tglb2/igt@gem_huc_copy@huc-copy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-tglb6/igt@gem_huc_copy@huc-copy.html

  * igt@gen7_exec_parse@basic-offset:
    - shard-skl:          NOTRUN -> [SKIP][3] ([fdo#109271]) +23 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl9/igt@gen7_exec_parse@basic-offset.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-glk:          [PASS][4] -> [DMESG-WARN][5] ([i915#1436] / [i915#716])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-glk9/igt@gen9_exec_parse@allowed-single.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-glk5/igt@gen9_exec_parse@allowed-single.html
    - shard-skl:          [PASS][6] -> [DMESG-WARN][7] ([i915#1436] / [i915#716])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl6/igt@gen9_exec_parse@allowed-single.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl5/igt@gen9_exec_parse@allowed-single.html

  * igt@kms_ccs@pipe-c-missing-ccs-buffer:
    - shard-skl:          NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111304])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl9/igt@kms_ccs@pipe-c-missing-ccs-buffer.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
    - shard-skl:          [PASS][9] -> [FAIL][10] ([i915#54]) +7 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][11] -> [FAIL][12] ([i915#2370])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
    - shard-skl:          [PASS][13] -> [FAIL][14] ([i915#79])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html

  * igt@kms_flip@plain-flip-ts-check@a-edp1:
    - shard-skl:          [PASS][15] -> [FAIL][16] ([i915#2122])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl1/igt@kms_flip@plain-flip-ts-check@a-edp1.html

  * igt@kms_hdr@bpc-switch-dpms:
    - shard-skl:          [PASS][17] -> [FAIL][18] ([i915#1188]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
    - shard-skl:          NOTRUN -> [FAIL][19] ([fdo#108145] / [i915#265])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#265])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [PASS][22] -> [SKIP][23] ([fdo#109642] / [fdo#111068])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb2/igt@kms_psr2_su@page_flip.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb5/igt@kms_psr2_su@page_flip.html

  
#### Possible fixes ####

  * {igt@gem_exec_balancer@fairslice}:
    - shard-iclb:         [FAIL][24] ([i915#2802]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb4/igt@gem_exec_balancer@fairslice.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb6/igt@gem_exec_balancer@fairslice.html

  * igt@gem_exec_capture@pi@vecs0:
    - shard-skl:          [INCOMPLETE][26] ([i915#198] / [i915#2624]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl7/igt@gem_exec_capture@pi@vecs0.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl2/igt@gem_exec_capture@pi@vecs0.html

  * {igt@gem_exec_fair@basic-none-solo@rcs0}:
    - shard-glk:          [FAIL][28] ([i915#2842]) -> [PASS][29] +2 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-glk5/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-glk3/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * {igt@gem_exec_fair@basic-pace-solo@rcs0}:
    - shard-tglb:         [FAIL][30] ([i915#2842]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-tglb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * {igt@gem_exec_fair@basic-pace@rcs0}:
    - shard-kbl:          [SKIP][32] ([fdo#109271]) -> [PASS][33] +2 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html

  * {igt@gem_exec_fair@basic-throttle@rcs0}:
    - shard-iclb:         [FAIL][34] ([i915#2842]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html

  * {igt@gem_exec_schedule@u-fairslice@vcs0}:
    - shard-skl:          [DMESG-WARN][36] -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl5/igt@gem_exec_schedule@u-fairslice@vcs0.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl9/igt@gem_exec_schedule@u-fairslice@vcs0.html

  * {igt@gem_vm_create@destroy-race}:
    - shard-tglb:         [TIMEOUT][38] ([i915#2795]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-tglb5/igt@gem_vm_create@destroy-race.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-tglb8/igt@gem_vm_create@destroy-race.html

  * igt@kms_async_flips@alternate-sync-async-flip:
    - shard-skl:          [FAIL][40] ([i915#2521]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html

  * igt@kms_big_fb@y-tiled-32bpp-rotate-180:
    - shard-glk:          [DMESG-FAIL][42] ([i915#118] / [i915#95]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-glk2/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-glk9/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html

  * igt@kms_color@pipe-a-ctm-green-to-red:
    - shard-skl:          [DMESG-WARN][44] ([i915#1982]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl4/igt@kms_color@pipe-a-ctm-green-to-red.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl1/igt@kms_color@pipe-a-ctm-green-to-red.html

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
    - shard-skl:          [FAIL][46] ([i915#54]) -> [PASS][47] +7 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html

  * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
    - shard-tglb:         [FAIL][48] ([i915#2346]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
    - shard-skl:          [FAIL][50] ([i915#79]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html

  * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
    - shard-glk:          [FAIL][52] ([i915#79]) -> [PASS][53] +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html

  * igt@kms_flip@plain-flip-fb-recreate@b-edp1:
    - shard-skl:          [FAIL][54] ([i915#2122]) -> [PASS][55] +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-snb:          [SKIP][56] ([fdo#109271]) -> [PASS][57] +3 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-snb6/igt@kms_frontbuffer_tracking@basic.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-snb7/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][58] ([fdo#108145] / [i915#265]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][60] ([fdo#109441]) -> [PASS][61] +3 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][62] ([i915#1804] / [i915#2684]) -> [WARN][63] ([i915#2684])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_async_flips@test-time-stamp:
    - shard-tglb:         [FAIL][64] ([i915#2597]) -> [FAIL][65] ([i915#2574])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-tglb2/igt@kms_async_flips@test-time-stamp.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-tglb5/igt@kms_async_flips@test-time-stamp.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-kbl:          [DMESG-WARN][66] ([i915#1602]) -> [INCOMPLETE][67] ([i915#155])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][68], [FAIL][69]) ([i915#1814] / [i915#2295] / [i915#483]) -> [FAIL][70] ([i915#2295] / [i915#483])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-kbl7/igt@runner@aborted.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-kbl2/igt@runner@aborted.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-kbl3/igt@runner@aborted.html
    - shard-iclb:         ([FAIL][71], [FAIL][72]) ([i915#1814] / [i915#2295] / [i915#2724] / [i915#483]) -> ([FAIL][73], [FAIL][74], [FAIL][75]) ([i915#1814] / [i915#2295] / [i915#2426] / [i915#2724] / [i915#483])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb1/igt@runner@aborted.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-iclb1/igt@runner@aborted.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb6/igt@runner@aborted.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb6/igt@runner@aborted.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-iclb2/igt@runner@aborted.html
    - shard-apl:          ([FAIL][76], [FAIL][77]) ([i915#1814] / [i915#2295]) -> ([FAIL][78], [FAIL][79], [FAIL][80]) ([i915#1610] / [i915#1814] / [i915#2295] / [i915#2426])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-apl2/igt@runner@aborted.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-apl3/igt@runner@aborted.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-apl3/igt@runner@aborted.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-apl7/igt@runner@aborted.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-apl1/igt@runner@aborted.html
    - shard-skl:          ([FAIL][81], [FAIL][82]) ([i915#2295] / [i915#2426]) -> ([FAIL][83], [FAIL][84]) ([i915#1436] / [i915#2295] / [i915#483])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl5/igt@runner@aborted.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9533/shard-skl8/igt@runner@aborted.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl5/igt@runner@aborted.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/shard-skl1/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2574]: https://gitlab.freedesktop.org/drm/intel/issues/2574
  [i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
  [i915#2624]: https://gitlab.freedesktop.org/drm/intel/issues/2624
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
  [i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
  [i915#2802]: https://gitlab.freedesktop.org/drm/intel/issues/2802
  [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9533 -> Patchwork_19226

  CI-20190529: 20190529
  CI_DRM_9533: 1ebc67e5e636a2422ac68d93b87e236dcf645da0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5928: 7813bb74aec408055d564fa6a270526822cfbc0e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19226: 10dcc8bfb71c1a6b5122fcf486ffa184c081c383 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19226/index.html

[-- Attachment #1.2: Type: text/html, Size: 22619 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-30 10:37 [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message Chris Wilson
  2020-12-30 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
  2020-12-30 13:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-12-31  0:02 ` Matt Roper
  2020-12-31  1:24   ` Almahallawy, Khaled
  2 siblings, 1 reply; 8+ messages in thread
From: Matt Roper @ 2020-12-31  0:02 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Wed, Dec 30, 2020 at 10:37:42AM +0000, Chris Wilson wrote:
> The timeouts are frequent and expected. We will complain if we retry so
> often as to lose patience and give up, so the cacophony from individual
> complaints is redundant.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 8ae769b18879..704e4cebf7f3 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
>  	/* Timeouts occur when the device isn't connected, so they're
>  	 * "normal" -- don't fill the kernel log with these */
>  	if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> -		drm_dbg_kms(&i915->drm, "%s: timeout (status 0x%08x)\n",
> -			    intel_dp->aux.name, status);
>  		ret = -ETIMEDOUT;
>  		goto out;
>  	}
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-31  0:02 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2020-12-31  1:24   ` Almahallawy, Khaled
  2020-12-31  9:17     ` Chris Wilson
  0 siblings, 1 reply; 8+ messages in thread
From: Almahallawy, Khaled @ 2020-12-31  1:24 UTC (permalink / raw)
  To: ville.syrjala, Roper, Matthew D, Deak, Imre, chris, Souza, Jose
  Cc: intel-gfx, Lin,  Charlton

On Wed, 2020-12-30 at 16:02 -0800, Matt Roper wrote:
> On Wed, Dec 30, 2020 at 10:37:42AM +0000, Chris Wilson wrote:
> > The timeouts are frequent and expected. We will complain if we
> > retry so
> > often as to lose patience and give up, so the cacophony from
> > individual
> > complaints is redundant.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 8ae769b18879..704e4cebf7f3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> >  	/* Timeouts occur when the device isn't connected, so they're
> >  	 * "normal" -- don't fill the kernel log with these */
> >  	if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> > -		drm_dbg_kms(&i915->drm, "%s: timeout (status
> > 0x%08x)\n",
> > -			    intel_dp->aux.name, status);

AUX timeout logs are very important for TGL TCSS Display debugging. We
actually can get AUX timeout when the display is connected for the
following reasons:
* If AUX orientation is not configured correctly in BIOS
* If USB3 dock is downgraded to USB2 and SBU/AUX lines are disabled
* When LTTPR/Retimer started to act funny and not configured correctly
by EC
* When we have a bug in the PMC mux configuration because of bug in the
following files: drivers/usb/typec/mux/intel_pmc_mux.c and
drivers/platform/x86/intel_scu_ipc.c
* When user space is not cleanly disconnected all MST connectors for
disconnected MST hub with 2+ display. We will be left with enabled
pipes although the cable is disconnected and next connect of type-c
display will give aux timeout: 
  ** User space fix in Chrome: 
https://chromium-review.googlesource.com/c/chromium/src/+/2512550/ 
  ** WA in driver: https://patchwork.freedesktop.org/patch/395901/ 

These logs are especially important for Chrome based platforms with
type-C. Seeing these logs we can know who is screwing up (TCSS driver,
CB, or EC).

By removing this log we are left with a generic error from
drm_dp_dpcd_access:	
DRM_DEBUG_KMS("%s: Too many retries, giving up. First error: %d\n",
		      aux->name, err);

I know these Aux timeout logs are annoying, but at least can we use the
same log level used for printing aux transaction in
drm_dp_helper.c/drm_dp_dump_access (DRM_DEBUG_DP)
            if (ret > 0)
		DRM_DEBUG_DP("%s: 0x%05x AUX %s (ret=%3d) %*ph\n",
			     aux->name, offset, arrow, ret, min(ret,
20), buffer);
	else
		DRM_DEBUG_DP("%s: 0x%05x AUX %s (ret=%3d)\n",
			     aux->name, offset, arrow, ret);

Thanks
Khaled
> >  		ret = -ETIMEDOUT;
> >  		goto out;
> >  	}
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-31  1:24   ` Almahallawy, Khaled
@ 2020-12-31  9:17     ` Chris Wilson
  2021-01-04 14:50       ` Souza, Jose
  0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2020-12-31  9:17 UTC (permalink / raw)
  To: Almahallawy, Khaled, Deak, Imre, Roper, Matthew D, Souza, Jose,
	ville.syrjala
  Cc: intel-gfx, Lin, Charlton

Quoting Almahallawy, Khaled (2020-12-31 01:24:34)
> On Wed, 2020-12-30 at 16:02 -0800, Matt Roper wrote:
> > On Wed, Dec 30, 2020 at 10:37:42AM +0000, Chris Wilson wrote:
> > > The timeouts are frequent and expected. We will complain if we
> > > retry so
> > > often as to lose patience and give up, so the cacophony from
> > > individual
> > > complaints is redundant.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > 
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_dp.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > > b/drivers/gpu/drm/i915/display/intel_dp.c
> > > index 8ae769b18879..704e4cebf7f3 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > @@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> > >     /* Timeouts occur when the device isn't connected, so they're
> > >      * "normal" -- don't fill the kernel log with these */
> > >     if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> > > -           drm_dbg_kms(&i915->drm, "%s: timeout (status
> > > 0x%08x)\n",
> > > -                       intel_dp->aux.name, status);
> 
> AUX timeout logs are very important for TGL TCSS Display debugging. We
> actually can get AUX timeout when the display is connected for the
> following reasons:
> * If AUX orientation is not configured correctly in BIOS
> * If USB3 dock is downgraded to USB2 and SBU/AUX lines are disabled
> * When LTTPR/Retimer started to act funny and not configured correctly
> by EC
> * When we have a bug in the PMC mux configuration because of bug in the
> following files: drivers/usb/typec/mux/intel_pmc_mux.c and
> drivers/platform/x86/intel_scu_ipc.c
> * When user space is not cleanly disconnected all MST connectors for
> disconnected MST hub with 2+ display. We will be left with enabled
> pipes although the cable is disconnected and next connect of type-c
> display will give aux timeout: 
>   ** User space fix in Chrome: 
> https://chromium-review.googlesource.com/c/chromium/src/+/2512550/ 
>   ** WA in driver: https://patchwork.freedesktop.org/patch/395901/ 
> 
> These logs are especially important for Chrome based platforms with
> type-C. Seeing these logs we can know who is screwing up (TCSS driver,
> CB, or EC).

Then capture the information you require to analyse your failures.
Flooding the debug log makes debugging everything else much, much harder.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
  2020-12-31  9:17     ` Chris Wilson
@ 2021-01-04 14:50       ` Souza, Jose
  2021-01-04 14:57         ` Chris Wilson
  0 siblings, 1 reply; 8+ messages in thread
From: Souza, Jose @ 2021-01-04 14:50 UTC (permalink / raw)
  To: ville.syrjala, Almahallawy, Khaled, Roper, Matthew D, Deak, Imre, chris
  Cc: intel-gfx, Lin,  Charlton

On Thu, 2020-12-31 at 09:17 +0000, Chris Wilson wrote:
> Quoting Almahallawy, Khaled (2020-12-31 01:24:34)
> > On Wed, 2020-12-30 at 16:02 -0800, Matt Roper wrote:
> > > On Wed, Dec 30, 2020 at 10:37:42AM +0000, Chris Wilson wrote:
> > > > The timeouts are frequent and expected. We will complain if we
> > > > retry so
> > > > often as to lose patience and give up, so the cacophony from
> > > > individual
> > > > complaints is redundant.
> > > > 
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > 
> > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > > 
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_dp.c | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > index 8ae769b18879..704e4cebf7f3 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > @@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> > > >     /* Timeouts occur when the device isn't connected, so they're
> > > >      * "normal" -- don't fill the kernel log with these */
> > > >     if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> > > > -           drm_dbg_kms(&i915->drm, "%s: timeout (status
> > > > 0x%08x)\n",
> > > > -                       intel_dp->aux.name, status);
> > 
> > AUX timeout logs are very important for TGL TCSS Display debugging. We
> > actually can get AUX timeout when the display is connected for the
> > following reasons:
> > * If AUX orientation is not configured correctly in BIOS
> > * If USB3 dock is downgraded to USB2 and SBU/AUX lines are disabled
> > * When LTTPR/Retimer started to act funny and not configured correctly
> > by EC
> > * When we have a bug in the PMC mux configuration because of bug in the
> > following files: drivers/usb/typec/mux/intel_pmc_mux.c and
> > drivers/platform/x86/intel_scu_ipc.c
> > * When user space is not cleanly disconnected all MST connectors for
> > disconnected MST hub with 2+ display. We will be left with enabled
> > pipes although the cable is disconnected and next connect of type-c
> > display will give aux timeout: 
> >   ** User space fix in Chrome: 
> > https://chromium-review.googlesource.com/c/chromium/src/+/2512550/ 
> >   ** WA in driver: https://patchwork.freedesktop.org/patch/395901/ 
> > 
> > These logs are especially important for Chrome based platforms with
> > type-C. Seeing these logs we can know who is screwing up (TCSS driver,
> > CB, or EC).
> 
> Then capture the information you require to analyse your failures.
> Flooding the debug log makes debugging everything else much, much harder.
> -Chris

I agree with Khaled this message is helpful to debug why display is not coming up.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message
  2021-01-04 14:50       ` Souza, Jose
@ 2021-01-04 14:57         ` Chris Wilson
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-04 14:57 UTC (permalink / raw)
  To: Almahallawy, Khaled, Deak, Imre, Roper, Matthew D, Souza, Jose,
	ville.syrjala
  Cc: intel-gfx, Lin, Charlton

Quoting Souza, Jose (2021-01-04 14:50:59)
> On Thu, 2020-12-31 at 09:17 +0000, Chris Wilson wrote:
> > Quoting Almahallawy, Khaled (2020-12-31 01:24:34)
> > > On Wed, 2020-12-30 at 16:02 -0800, Matt Roper wrote:
> > > > On Wed, Dec 30, 2020 at 10:37:42AM +0000, Chris Wilson wrote:
> > > > > The timeouts are frequent and expected. We will complain if we
> > > > > retry so
> > > > > often as to lose patience and give up, so the cacophony from
> > > > > individual
> > > > > complaints is redundant.
> > > > > 
> > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > 
> > > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > > > 
> > > > > ---
> > > > >  drivers/gpu/drm/i915/display/intel_dp.c | 2 --
> > > > >  1 file changed, 2 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > index 8ae769b18879..704e4cebf7f3 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > @@ -1613,8 +1613,6 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> > > > >     /* Timeouts occur when the device isn't connected, so they're
> > > > >      * "normal" -- don't fill the kernel log with these */
> > > > >     if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> > > > > -           drm_dbg_kms(&i915->drm, "%s: timeout (status
> > > > > 0x%08x)\n",
> > > > > -                       intel_dp->aux.name, status);
> > > 
> > > AUX timeout logs are very important for TGL TCSS Display debugging. We
> > > actually can get AUX timeout when the display is connected for the
> > > following reasons:
> > > * If AUX orientation is not configured correctly in BIOS
> > > * If USB3 dock is downgraded to USB2 and SBU/AUX lines are disabled
> > > * When LTTPR/Retimer started to act funny and not configured correctly
> > > by EC
> > > * When we have a bug in the PMC mux configuration because of bug in the
> > > following files: drivers/usb/typec/mux/intel_pmc_mux.c and
> > > drivers/platform/x86/intel_scu_ipc.c
> > > * When user space is not cleanly disconnected all MST connectors for
> > > disconnected MST hub with 2+ display. We will be left with enabled
> > > pipes although the cable is disconnected and next connect of type-c
> > > display will give aux timeout: 
> > >   ** User space fix in Chrome: 
> > > https://chromium-review.googlesource.com/c/chromium/src/+/2512550/ 
> > >   ** WA in driver: https://patchwork.freedesktop.org/patch/395901/ 
> > > 
> > > These logs are especially important for Chrome based platforms with
> > > type-C. Seeing these logs we can know who is screwing up (TCSS driver,
> > > CB, or EC).
> > 
> > Then capture the information you require to analyse your failures.
> > Flooding the debug log makes debugging everything else much, much harder.
> > -Chris
> 
> I agree with Khaled this message is helpful to debug why display is not coming up.

Isn't that the case where it falls through to the later timeout warning?

If there's some information in there to explain a display failure, can
it be extracted automatically? Or to turn the table around, if it is so
useful to debug failures, why do we still see it in CI?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-01-04 14:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 10:37 [Intel-gfx] [PATCH] drm/i915/dp: Remove aux xfer timeout debug message Chris Wilson
2020-12-30 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-30 13:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-31  0:02 ` [Intel-gfx] [PATCH] " Matt Roper
2020-12-31  1:24   ` Almahallawy, Khaled
2020-12-31  9:17     ` Chris Wilson
2021-01-04 14:50       ` Souza, Jose
2021-01-04 14:57         ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.