* [PATCH net] selftests: mlxsw: Set headroom size of correct port
@ 2020-12-30 11:42 Ido Schimmel
2021-01-04 21:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Ido Schimmel @ 2020-12-30 11:42 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, petrm, mlxsw, Ido Schimmel
From: Ido Schimmel <idosch@nvidia.com>
The test was setting the headroom size of the wrong port. This was not
visible because of a firmware bug that canceled this bug.
Set the headroom size of the correct port, so that the test will pass
with both old and new firmware versions.
Fixes: bfa804784e32 ("selftests: mlxsw: Add a PFC test")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
---
tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh b/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
index 4d900bc1f76c..5c7700212f75 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
@@ -230,7 +230,7 @@ switch_create()
__mlnx_qos -i $swp4 --pfc=0,1,0,0,0,0,0,0 >/dev/null
# PG0 will get autoconfigured to Xoff, give PG1 arbitrarily 100K, which
# is (-2*MTU) about 80K of delay provision.
- __mlnx_qos -i $swp3 --buffer_size=0,$_100KB,0,0,0,0,0,0 >/dev/null
+ __mlnx_qos -i $swp4 --buffer_size=0,$_100KB,0,0,0,0,0,0 >/dev/null
# bridges
# -------
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] selftests: mlxsw: Set headroom size of correct port
2020-12-30 11:42 [PATCH net] selftests: mlxsw: Set headroom size of correct port Ido Schimmel
@ 2021-01-04 21:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-04 21:40 UTC (permalink / raw)
To: Ido Schimmel; +Cc: netdev, davem, kuba, petrm, mlxsw, idosch
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 30 Dec 2020 13:42:51 +0200 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> The test was setting the headroom size of the wrong port. This was not
> visible because of a firmware bug that canceled this bug.
>
> Set the headroom size of the correct port, so that the test will pass
> with both old and new firmware versions.
>
> [...]
Here is the summary with links:
- [net] selftests: mlxsw: Set headroom size of correct port
https://git.kernel.org/netdev/net/c/2ff2c7e27439
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-04 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 11:42 [PATCH net] selftests: mlxsw: Set headroom size of correct port Ido Schimmel
2021-01-04 21:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.