From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16488C433DB for ; Wed, 30 Dec 2020 12:22:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D370F2222A for ; Wed, 30 Dec 2020 12:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726552AbgL3MWB (ORCPT ); Wed, 30 Dec 2020 07:22:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:46282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgL3MWB (ORCPT ); Wed, 30 Dec 2020 07:22:01 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35E3D22209; Wed, 30 Dec 2020 12:21:19 +0000 (UTC) Date: Wed, 30 Dec 2020 12:21:14 +0000 From: Jonathan Cameron To: Rob Herring Cc: "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org, Jonathan Cameron , "Andrew F . Davis" Subject: Re: [PATCH 08/46] dt-bindings:iio:health:ti,afe4404: txt to yaml conversion Message-ID: <20201230122114.12e6957f@archlinux> In-Reply-To: References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-9-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 18 Dec 2020 13:42:19 -0600 Rob Herring wrote: > On Sat, Oct 31, 2020 at 1:51 PM Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > This basically has same questions as for the afe4403. We could combine > > the two bindings, but as the drivers are separate and it would be a little > > fiddly due to different buses let's keep the separating. > > To repeat questions from the ti,afe4403 binding. > > > > A few questions came up whilst converting this one. > > 1) What is actually required? > > - Checking Linux driver, interrupt is not, and the tx-supply could > > be supplied by a stub regulator as long as it's always on. > > As such I have reduced the required list to just compatible and reg. > > 2) What is the regulator called? > > - It's tx-supply in the binding doc, but the driver request tx_sup > > I've left this alone for now. Andrew could you confirm what is > > intended for this? > > > > Signed-off-by: Jonathan Cameron > > Cc: Andrew F. Davis > > --- > > .../bindings/iio/health/afe4404.txt | 29 ----------- > > .../bindings/iio/health/ti,afe4404.yaml | 51 +++++++++++++++++++ > > 2 files changed, 51 insertions(+), 29 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/health/afe4404.txt b/Documentation/devicetree/bindings/iio/health/afe4404.txt > > deleted file mode 100644 > > index 0b52830a0d9c..000000000000 > > --- a/Documentation/devicetree/bindings/iio/health/afe4404.txt > > +++ /dev/null > > @@ -1,29 +0,0 @@ > > -Texas Instruments AFE4404 Heart rate and Pulse Oximeter > > - > > -Required properties: > > - - compatible : Should be "ti,afe4404". > > - - reg : I2C address of the device. > > - - tx-supply : Regulator supply to transmitting LEDs. > > - - interrupts : The interrupt line the device ADC_RDY pin is > > - connected to. For details refer to, > > - ../interrupt-controller/interrupts.txt. > > - > > -Optional properties: > > - - reset-gpios : GPIO used to reset the device. > > - For details refer to, ../gpio/gpio.txt. > > - > > -Example: > > - > > -&i2c2 { > > - heart_mon@58 { > > - compatible = "ti,afe4404"; > > - reg = <0x58>; > > - > > - tx-supply = <&vbat>; > > - > > - interrupt-parent = <&gpio1>; > > - interrupts = <28 IRQ_TYPE_EDGE_RISING>; > > - > > - reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > > new file mode 100644 > > index 000000000000..187b99b22312 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Texas Instruments AFE4404 Heart rate and Pulse Oximeter > > + > > +maintainers: > > + - Andrew F. Davis > > + > > +properties: > > + compatible: > > + const: ti,afe4403 > > Typo here, which causes this warning: > > Documentation/devicetree/bindings/iio/health/ti,afe4403.example.dt.yaml: > heart_mon@0: 'spi-max-frequency' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Took me a minute staring at ti,afe4403.yaml to figure out what was happening. Doh! Patch on it's way. Thanks, Jonathan > > Rob