From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F38EC433DB for ; Wed, 30 Dec 2020 13:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA77E217BA for ; Wed, 30 Dec 2020 13:17:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgL3NRL (ORCPT ); Wed, 30 Dec 2020 08:17:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:59648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbgL3NRK (ORCPT ); Wed, 30 Dec 2020 08:17:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F6E3217BA; Wed, 30 Dec 2020 13:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609334190; bh=AkIQMFW3uBWg0gGY3L1pmtX/HhTTMeoRJWJ7Vk4TO1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L58OaIVOcbGms4rTCqXro1aX5Njbgnj7qwZGelpPOPbnR1t/lDqUf6tyKZD4gsBDD ixbe0WZ8l/uJjQr6Pb8vzd1Bpt1RWP2jUbAbKeHk0KLdmJcOX25Wrf1hNpFE4zA4fK n/I1CTf9GNSBVfectAvujzS3E7f7EqySg3M+SEEKb07fcCl6lgbfPgf+fm9qqiqETd fFcry8suuTC2IRaZ/CaEDI4oMBgnpBPZN/9+WNuNa6fOJKc+Uwx4YF5dRLocmxx1Kj KCIqYSG9ZdFNqCz9/duIitFMosFtv26TBvajZ3w1WFKZYKqu4KFIkpm3KDZRMNbWjx A34fAkEaDfNgQ== Date: Wed, 30 Dec 2020 13:16:05 +0000 From: Mark Brown To: Richard Fitzgerald Cc: Hans de Goede , Charles Keepax , Lee Jones , MyungJoo Ham , Chanwoo Choi , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona Message-ID: <20201230131605.GB4428@sirena.org.uk> References: <20201227211232.117801-2-hdegoede@redhat.com> <20201228122138.GA5352@sirena.org.uk> <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> <20201228162807.GE5352@sirena.org.uk> <20201229130657.GN9673@ediswmail.ad.cirrus.com> <19c2d056-4f71-2c4c-c243-cdcc0115876c@redhat.com> <20201229150635.GP9673@ediswmail.ad.cirrus.com> <20201229151548.GG4786@sirena.org.uk> <1d982dd1-eb02-e7c7-357e-83cf5003c624@redhat.com> <21333e30-1e7a-2c95-9e7c-6325c7e78f9a@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: <21333e30-1e7a-2c95-9e7c-6325c7e78f9a@opensource.cirrus.com> X-Cookie: Above all things, reverence yourself. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 29, 2020 at 04:51:57PM +0000, Richard Fitzgerald wrote: > On 29/12/2020 15:40, Hans de Goede wrote: > > I guess we should move it out of drivers/extcon then though. > > I suggest using: sound/soc/cirrus/arizona-jack-detect.c > > Note that sound/soc/cirrus is a new dir here. Would that work > > for you ? > Shouldn't it be sound/soc/codecs/arizona-jack.c so that it is with all > the other code for those codecs? That is what I would expect too. --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/sfZUACgkQJNaLcl1U h9CFSgf/f+vIYBwZ3rH9QPaqfupdc6tEu8+Fq4isSWufnfyuPY3KAZouiqdbNv8p 0Rm9lfFQ67lJLEktLfFXwC7v43abUZrh9Ms6MrfEMVVoJcVVs+u4wuHUraq32VE4 QFzIPPcQm+kNT5npR0y9dSAW5JVg6q6/iyY9Taxaw/72r78+5Rw00XkLkMwTeifR Y25bS7zfNSUNKuCLVKrCMY6w1q9ufLX2ekPOdgz0oPn/99Q2VhCCvrPVnVJi98PL AF/DNWxYUHxP+5LZZUyZneUw2jckwVvPMLeERLE4ADd7MEgZU3BGTQcxo3F8QTgc 0INXfUZy2WdHt/+8QmfkSAmBXs0DGQ== =zAvb -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAD7C433E0 for ; Wed, 30 Dec 2020 13:17:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E2932220B for ; Wed, 30 Dec 2020 13:17:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E2932220B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C2956183A; Wed, 30 Dec 2020 14:16:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C2956183A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609334247; bh=AkIQMFW3uBWg0gGY3L1pmtX/HhTTMeoRJWJ7Vk4TO1M=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j8jYxrfVyCkmFlI5hROwti5AxxtNywsuKLWacckxTeQdB1OlEiwoItl7HqvDqmce4 nqSqF0JLJRZ4ptk2eRjq4Gvwu8IlkIy2C7EX5m1qjlOvDvixy/Q9ZivZ8py5A6gL0n UWovlyaM1yRfkok1bFay9NqNMGmnGwjbcgrTnXhg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3B478F801ED; Wed, 30 Dec 2020 14:16:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B6C1BF801F5; Wed, 30 Dec 2020 14:16:35 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1B879F80132 for ; Wed, 30 Dec 2020 14:16:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1B879F80132 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L58OaIVO" Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F6E3217BA; Wed, 30 Dec 2020 13:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609334190; bh=AkIQMFW3uBWg0gGY3L1pmtX/HhTTMeoRJWJ7Vk4TO1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L58OaIVOcbGms4rTCqXro1aX5Njbgnj7qwZGelpPOPbnR1t/lDqUf6tyKZD4gsBDD ixbe0WZ8l/uJjQr6Pb8vzd1Bpt1RWP2jUbAbKeHk0KLdmJcOX25Wrf1hNpFE4zA4fK n/I1CTf9GNSBVfectAvujzS3E7f7EqySg3M+SEEKb07fcCl6lgbfPgf+fm9qqiqETd fFcry8suuTC2IRaZ/CaEDI4oMBgnpBPZN/9+WNuNa6fOJKc+Uwx4YF5dRLocmxx1Kj KCIqYSG9ZdFNqCz9/duIitFMosFtv26TBvajZ3w1WFKZYKqu4KFIkpm3KDZRMNbWjx A34fAkEaDfNgQ== Date: Wed, 30 Dec 2020 13:16:05 +0000 From: Mark Brown To: Richard Fitzgerald Subject: Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona Message-ID: <20201230131605.GB4428@sirena.org.uk> References: <20201227211232.117801-2-hdegoede@redhat.com> <20201228122138.GA5352@sirena.org.uk> <44f84485-8efc-39f9-d0a7-cb8db2ea3faa@redhat.com> <20201228162807.GE5352@sirena.org.uk> <20201229130657.GN9673@ediswmail.ad.cirrus.com> <19c2d056-4f71-2c4c-c243-cdcc0115876c@redhat.com> <20201229150635.GP9673@ediswmail.ad.cirrus.com> <20201229151548.GG4786@sirena.org.uk> <1d982dd1-eb02-e7c7-357e-83cf5003c624@redhat.com> <21333e30-1e7a-2c95-9e7c-6325c7e78f9a@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: <21333e30-1e7a-2c95-9e7c-6325c7e78f9a@opensource.cirrus.com> X-Cookie: Above all things, reverence yourself. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Cezary Rojewski , Charles Keepax , alsa-devel@alsa-project.org, Chanwoo Choi , patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Hans de Goede , MyungJoo Ham , Lee Jones X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 29, 2020 at 04:51:57PM +0000, Richard Fitzgerald wrote: > On 29/12/2020 15:40, Hans de Goede wrote: > > I guess we should move it out of drivers/extcon then though. > > I suggest using: sound/soc/cirrus/arizona-jack-detect.c > > Note that sound/soc/cirrus is a new dir here. Would that work > > for you ? > Shouldn't it be sound/soc/codecs/arizona-jack.c so that it is with all > the other code for those codecs? That is what I would expect too. --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/sfZUACgkQJNaLcl1U h9CFSgf/f+vIYBwZ3rH9QPaqfupdc6tEu8+Fq4isSWufnfyuPY3KAZouiqdbNv8p 0Rm9lfFQ67lJLEktLfFXwC7v43abUZrh9Ms6MrfEMVVoJcVVs+u4wuHUraq32VE4 QFzIPPcQm+kNT5npR0y9dSAW5JVg6q6/iyY9Taxaw/72r78+5Rw00XkLkMwTeifR Y25bS7zfNSUNKuCLVKrCMY6w1q9ufLX2ekPOdgz0oPn/99Q2VhCCvrPVnVJi98PL AF/DNWxYUHxP+5LZZUyZneUw2jckwVvPMLeERLE4ADd7MEgZU3BGTQcxo3F8QTgc 0INXfUZy2WdHt/+8QmfkSAmBXs0DGQ== =zAvb -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--