From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5E2C433E0 for ; Thu, 31 Dec 2020 07:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 041CB207C8 for ; Thu, 31 Dec 2020 07:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbgLaH2A (ORCPT ); Thu, 31 Dec 2020 02:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbgLaH17 (ORCPT ); Thu, 31 Dec 2020 02:27:59 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AEBCC061573 for ; Wed, 30 Dec 2020 23:27:19 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id c79so10891846pfc.2 for ; Wed, 30 Dec 2020 23:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L3rchCgn60UXSNg/RkUXBGhv13ATR5wc8YM8fhcBkn4=; b=x4261brrKoUTmGEcVb8b6y4YuUMUAwI/WAJ6I3alcPunXupX7CbORvMgruLH8gs0G9 GwtAdwg8P7p1mHxUw/4OjxCjrbB2Z6g0cRSNkwaHoeZLFAUmcIha8qokVnKxlGudDett NukWnXz3y8QOnK6oc4/j3OYiFTlktdT5Mt0cPNhPrgfxMQCi/6+N2kH9KDUFXU6XgX+s aYxuDapL2VXTwKbOY7j2bfYQsKO5xJ8fMXkC9iDdf2Wn2K+WiHAVzpNHAKfRvcILbixJ FxRUmWQgSOwAu5wVXBSHsjxxccz/qZU19+Esh9YYtfzQcMjhtI3eq5yp0tHQWs3XXBZ0 F4ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L3rchCgn60UXSNg/RkUXBGhv13ATR5wc8YM8fhcBkn4=; b=a4qxNulhNpdwKnBDNKJqEUd/TgSm2khbEnhllbMV+9mxS5QoTvliArlRuRD276S3I/ ci4b8MvHybbz8woimVsjRUAOQWj8QLEGTXv6GLo8EJ/Puqswo7K2/gpyCwDUek9vgtZy jiz7p23KdMZaJiFuVnw+iONfAXC9XLV9UCyx6U1yun74s33tT7PCav+cc0YGF6/fsIXP cKuPpoX/vJmgyimD3kbC4zCowg4j/iRXqjAUo4TNuvwcg+YZR2tK/vr0ErWZ9HfWm7+F lcQUE7xZqN7EGa0PhMZRliXGiIsqpmEDAUZl3216BtxMqeBVYj8s5/cOIhyQohFRg6jn NxNw== X-Gm-Message-State: AOAM532XatvAuVC6X+O9D5NGpinOYFqDHU74j0qKUDXFgC4e+1m/OIIM wsc9T1ugx804QFdFH/mu9U32 X-Google-Smtp-Source: ABdhPJyjSzd1B+plpmbHvjXcunIxJaD12PEru1NpFPYDBdpPKuhm2hQA1BpegeJ7YX2dsMxLKgqq+w== X-Received: by 2002:a63:4559:: with SMTP id u25mr26577840pgk.306.1609399639035; Wed, 30 Dec 2020 23:27:19 -0800 (PST) Received: from thinkpad ([2409:4072:6d1f:be3b:71a9:d2bf:a32d:897d]) by smtp.gmail.com with ESMTPSA id j14sm9532596pjm.10.2020.12.30.23.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 23:27:18 -0800 (PST) Date: Thu, 31 Dec 2020 12:57:10 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/13] arm: dts: owl-s500-roseapplepi: Add uSD support Message-ID: <20201231072710.GF7345@thinkpad> References: <47ee9695e89198ec2fbc4ab6188f1d0ad0424b2f.1609263738.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47ee9695e89198ec2fbc4ab6188f1d0ad0424b2f.1609263738.git.cristian.ciocaltea@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 29, 2020 at 11:17:26PM +0200, Cristian Ciocaltea wrote: > Add uSD support for RoseapplePi SBC using a fixed regulator as a > temporary solution until PMIC support becomes available. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Changes in v3: > - None > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index 800edf5d2d12..fe9ae3619422 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -14,6 +14,7 @@ / { > model = "Roseapple Pi"; > > aliases { > + mmc0 = &mmc0; > serial2 = &uart2; > }; > > @@ -25,6 +26,55 @@ memory@0 { > device_type = "memory"; > reg = <0x0 0x80000000>; /* 2GB */ > }; > + > + /* Fixed regulator used in the absence of PMIC */ > + sd_vcc: sd-vcc { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.1V"; > + regulator-min-microvolt = <3100000>; > + regulator-max-microvolt = <3100000>; > + regulator-always-on; > + }; > +}; > + > +&pinctrl { > + mmc0_pins: mmc0-pins { > + pinmux { > + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", > + "sd0_cmd_mfp", "sd0_clk_mfp"; > + function = "sd0"; > + }; > + > + drv-pinconf { > + groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv"; > + drive-strength = <8>; > + }; > + > + bias0-pinconf { > + pins = "sd0_d0", "sd0_d1", "sd0_d2", > + "sd0_d3", "sd0_cmd"; > + bias-pull-up; > + }; > + > + bias1-pinconf { > + pins = "sd0_clk"; > + bias-pull-down; > + }; > + }; > +}; > + > +/* uSD */ > +&mmc0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + no-sdio; > + no-mmc; > + no-1-8-v; > + cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + vmmc-supply = <&sd_vcc>; > + vqmmc-supply = <&sd_vcc>; > }; > > &twd_timer { > -- > 2.30.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719F7C433DB for ; Thu, 31 Dec 2020 07:29:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F368C22287 for ; Thu, 31 Dec 2020 07:29:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F368C22287 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lBUhugy0yvyKvpoePNXuSqOjlkWUyuwiaiuF0/JaaIk=; b=vaCa29JTYXsy75n1GChjsSrwd 2e375i74TDxsSpT21PnRqgWL2KVacfrJrdw0wRsv8SeW1/RZmFQUzBA1pqZasxN3EcLc49C/wvjng ijwM1ivIIoD4lF3VR/Aw2GKczOgWe86mCvquXyjB79gDJLMZIgOykWVgVCDtmAM2Rwai9H/o45cLv xrS9EKTu8zp60IX54tCQaFIpP26+xi0OiOpxjkdJ98OlMCOgMDjgLpX1TqC6AbBs1p2hEG2yRJyeh I7N+JZhfaA7UtC50TQ7sjbOtO8c7H/UAwgDy4EuT5QyK0HkqU8sWmdDEXW7ycoi3cnk+lb03KHs+J mO/yW50jQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kusMn-0007B1-E3; Thu, 31 Dec 2020 07:27:25 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kusMk-0007AJ-SU for linux-arm-kernel@lists.infradead.org; Thu, 31 Dec 2020 07:27:23 +0000 Received: by mail-pg1-x531.google.com with SMTP id n7so12698075pgg.2 for ; Wed, 30 Dec 2020 23:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L3rchCgn60UXSNg/RkUXBGhv13ATR5wc8YM8fhcBkn4=; b=x4261brrKoUTmGEcVb8b6y4YuUMUAwI/WAJ6I3alcPunXupX7CbORvMgruLH8gs0G9 GwtAdwg8P7p1mHxUw/4OjxCjrbB2Z6g0cRSNkwaHoeZLFAUmcIha8qokVnKxlGudDett NukWnXz3y8QOnK6oc4/j3OYiFTlktdT5Mt0cPNhPrgfxMQCi/6+N2kH9KDUFXU6XgX+s aYxuDapL2VXTwKbOY7j2bfYQsKO5xJ8fMXkC9iDdf2Wn2K+WiHAVzpNHAKfRvcILbixJ FxRUmWQgSOwAu5wVXBSHsjxxccz/qZU19+Esh9YYtfzQcMjhtI3eq5yp0tHQWs3XXBZ0 F4ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L3rchCgn60UXSNg/RkUXBGhv13ATR5wc8YM8fhcBkn4=; b=uYUqD3oYPL/x2jjiwKhrP+aPDCJo2nOqeitACaDECAXwJ/qlCxazESJVQ9cP3kQ5zb a3bn4MqIi5EWKpicfkNwr+ZGUPDnAKOmCrbHV1FdFj3drZiddM6B3PO0O72EV2jEosI9 i3+sqrWcCkmMjO07wIyBbAgWc33fFUNaLazloVgWSp9Ya0H+r1FKeuDjAuHw9VP0uS5k jdNmwF5TMFWRb/99fdkaznm5d3QDoQo8B/Qqs49OfWJ2fCkVRWLKnwNn9qRNvdId70+7 FRLfMlgl3ugLeEzSklNWTj4vqHkkK6umgxHmdn85Y6KOSJDcUJWnM+8vQmFD7Lg4ZyK6 /XGg== X-Gm-Message-State: AOAM533rR9PtZu4up8sf65Iz48c9BPzHnXokoqAoTohsieT917TXJFn1 I8piJDw8fMiAQNlDH3yKjy2e X-Google-Smtp-Source: ABdhPJyjSzd1B+plpmbHvjXcunIxJaD12PEru1NpFPYDBdpPKuhm2hQA1BpegeJ7YX2dsMxLKgqq+w== X-Received: by 2002:a63:4559:: with SMTP id u25mr26577840pgk.306.1609399639035; Wed, 30 Dec 2020 23:27:19 -0800 (PST) Received: from thinkpad ([2409:4072:6d1f:be3b:71a9:d2bf:a32d:897d]) by smtp.gmail.com with ESMTPSA id j14sm9532596pjm.10.2020.12.30.23.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 23:27:18 -0800 (PST) Date: Thu, 31 Dec 2020 12:57:10 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Subject: Re: [PATCH v3 11/13] arm: dts: owl-s500-roseapplepi: Add uSD support Message-ID: <20201231072710.GF7345@thinkpad> References: <47ee9695e89198ec2fbc4ab6188f1d0ad0424b2f.1609263738.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <47ee9695e89198ec2fbc4ab6188f1d0ad0424b2f.1609263738.git.cristian.ciocaltea@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201231_022722_993792_64DB053A X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 11:17:26PM +0200, Cristian Ciocaltea wrote: > Add uSD support for RoseapplePi SBC using a fixed regulator as a > temporary solution until PMIC support becomes available. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Changes in v3: > - None > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index 800edf5d2d12..fe9ae3619422 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -14,6 +14,7 @@ / { > model = "Roseapple Pi"; > > aliases { > + mmc0 = &mmc0; > serial2 = &uart2; > }; > > @@ -25,6 +26,55 @@ memory@0 { > device_type = "memory"; > reg = <0x0 0x80000000>; /* 2GB */ > }; > + > + /* Fixed regulator used in the absence of PMIC */ > + sd_vcc: sd-vcc { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.1V"; > + regulator-min-microvolt = <3100000>; > + regulator-max-microvolt = <3100000>; > + regulator-always-on; > + }; > +}; > + > +&pinctrl { > + mmc0_pins: mmc0-pins { > + pinmux { > + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", > + "sd0_cmd_mfp", "sd0_clk_mfp"; > + function = "sd0"; > + }; > + > + drv-pinconf { > + groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv"; > + drive-strength = <8>; > + }; > + > + bias0-pinconf { > + pins = "sd0_d0", "sd0_d1", "sd0_d2", > + "sd0_d3", "sd0_cmd"; > + bias-pull-up; > + }; > + > + bias1-pinconf { > + pins = "sd0_clk"; > + bias-pull-down; > + }; > + }; > +}; > + > +/* uSD */ > +&mmc0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + no-sdio; > + no-mmc; > + no-1-8-v; > + cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + vmmc-supply = <&sd_vcc>; > + vqmmc-supply = <&sd_vcc>; > }; > > &twd_timer { > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel