From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6AFC433DB for ; Sat, 2 Jan 2021 17:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D38B8224D2 for ; Sat, 2 Jan 2021 17:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbhABRJZ (ORCPT ); Sat, 2 Jan 2021 12:09:25 -0500 Received: from mga05.intel.com ([192.55.52.43]:47109 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbhABRJZ (ORCPT ); Sat, 2 Jan 2021 12:09:25 -0500 IronPort-SDR: MoabWB71FKseD7fb+AdSUrQypGT5w9oJS1Wy2UwFW8Muk1cyFxbesU9x1q6ZWV904Aj+QmJzX0 kSLzFC3qToGg== X-IronPort-AV: E=McAfee;i="6000,8403,9852"; a="261584912" X-IronPort-AV: E=Sophos;i="5.78,470,1599548400"; d="scan'208";a="261584912" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2021 09:07:39 -0800 IronPort-SDR: fwJSomnSF/y6+hHAl/Wvfe+88D95eUwIF55usTYH5kRi3sl+70frRvBRIA57qSnRaRAqdM3H0k t0W9ogWd1Yaw== X-IronPort-AV: E=Sophos;i="5.78,470,1599548400"; d="scan'208";a="401489679" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2021 09:07:33 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 9E9E0207BF; Sat, 2 Jan 2021 19:07:31 +0200 (EET) Date: Sat, 2 Jan 2021 19:07:31 +0200 From: Sakari Ailus To: Daniel Scally Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Message-ID: <20210102170731.GD11878@paasikivi.fi.intel.com> References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Daniel, On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > >>> +#define CIO2_NUM_PORTS 4 > > > > This is already defined in ipu3-cio2.h. Could you include that instead? > > Yes; but I'd need to also include media/v4l2-device.h and > media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > moment). It didn't seem worth it; but I can move those two includes from > the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > > Which do you prefer? Seems you got answers already... :-) splitting the header in two seems good to me. But IMO it doesn't have to be a part of this set. -- Sakari Ailus