From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E541C43381 for ; Sat, 2 Jan 2021 17:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00BF420791 for ; Sat, 2 Jan 2021 17:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbhABRXh (ORCPT ); Sat, 2 Jan 2021 12:23:37 -0500 Received: from mga02.intel.com ([134.134.136.20]:22783 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbhABRXg (ORCPT ); Sat, 2 Jan 2021 12:23:36 -0500 IronPort-SDR: pRH8RLejw1rxv/mbPUkEHO4PH0BW62zrNW5hAvHR/bWf0qxXNakReJ3h7TYdJadyUADvL9EdL1 ZXMexGvhiAPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9852"; a="163895332" X-IronPort-AV: E=Sophos;i="5.78,470,1599548400"; d="scan'208";a="163895332" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2021 09:21:50 -0800 IronPort-SDR: EPjvPP5vEZ0hdOwXHXakBXOGtZvsyYJQmeVfzjNQ0xP3EGcDuZWRN8g8RDov7eybLzsjb9Y1Sx nd2j+N6LAosg== X-IronPort-AV: E=Sophos;i="5.78,470,1599548400"; d="scan'208";a="401492940" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2021 09:21:43 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id CF8CB207BF; Sat, 2 Jan 2021 19:21:41 +0200 (EET) Date: Sat, 2 Jan 2021 19:21:41 +0200 From: Sakari Ailus To: Daniel Scally Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Message-ID: <20210102172141.GE11878@paasikivi.fi.intel.com> References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20210102170731.GD11878@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sat, Jan 02, 2021 at 05:12:47PM +0000, Daniel Scally wrote: > Hi Sakari > > On 02/01/2021 17:07, Sakari Ailus wrote: > > Hi Daniel, > > > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > >>>>> +#define CIO2_NUM_PORTS 4 > >>> This is already defined in ipu3-cio2.h. Could you include that instead? > >> Yes; but I'd need to also include media/v4l2-device.h and > >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > >> moment). It didn't seem worth it; but I can move those two includes from > >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > >> > >> Which do you prefer? > > Seems you got answers already... :-) splitting the header in two seems good > > to me. But IMO it doesn't have to be a part of this set. > > > Yeah I've been hesitating over this; if we chose not to do it in this > set though, how would you want me to deal with the double definition of > CIO2_NUM_PORTS How about prepending Andy's patch to the set and including the header? -- Sakari Ailus