From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/php: needs pcre2
Date: Sat, 2 Jan 2021 22:05:46 +0100 [thread overview]
Message-ID: <20210102210546.GE2997@scaer> (raw)
In-Reply-To: <20201228223627.51a0a518@windsurf.home>
Thomas, Bernd, All,
On 2020-12-28 22:36 +0100, Thomas Petazzoni spake thusly:
> On Sun, 27 Dec 2020 19:31:45 +0100
> Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> > -### Use external PCRE if it's available
> > -ifeq ($(BR2_PACKAGE_PCRE2),y)
> > -PHP_CONF_OPTS += --with-pcre-regex=$(STAGING_DIR)/usr
> > -PHP_DEPENDENCIES += pcre2
> > -
> > -ifeq ($(BR2_PACKAGE_PCRE2_JIT),y)
> > -PHP_CONF_OPTS += --with-pcre-jit=yes
> > -PHP_CONF_ENV += ac_cv_have_pcre2_jit=yes
> > -else
> > -PHP_CONF_OPTS += --with-pcre-jit=no
> > -PHP_CONF_ENV += ac_cv_have_pcre2_jit=no
> > -endif
>
> Are you sure this is no longer needed ? According to
> https://github.com/php/php-src/commit/c1a22f3d4e69cb87f8deeed7d03d9434e6901537
> that you are pointing, the --with-pcre-jit option is not only for the
> bundled PCRE.
In fact, when cross-compiling, php will rely on a hard-coded list of
architectures for which it believes JIT is available:
https://github.com/php/php-src/blob/3e2e0b58484c5364aca026b7b3df769a63dc5389/ext/pcre/config0.m4#L24
Note that they got an incomplete list, as AArch64 does has JIT support,
but it is not in PHP's whitelist.
So we indeed still need to explicitly enable or disable JIT *and*
continue to pass the cache-variable to ocverride autodetection.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-01-02 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 18:31 [Buildroot] [PATCH 1/2] package/pcre2: remove empty line from Config.in Bernd Kuhls
2020-12-27 18:31 ` [Buildroot] [PATCH 2/2] package/php: needs pcre2 Bernd Kuhls
2020-12-28 21:36 ` Thomas Petazzoni
2021-01-02 21:05 ` Yann E. MORIN [this message]
2021-01-02 21:12 ` Yann E. MORIN
2020-12-28 21:35 ` [Buildroot] [PATCH 1/2] package/pcre2: remove empty line from Config.in Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210102210546.GE2997@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.