All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
	Merlijn Wajer <merlijn@wizzup.org>
Subject: Re: [PATCH] power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression
Date: Sun, 3 Jan 2021 02:57:52 +0100	[thread overview]
Message-ID: <20210103015752.gzonx5h54v4mseye@earth.universe> (raw)
In-Reply-To: <20201230101911.11747-1-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

Hi Tony,

On Wed, Dec 30, 2020 at 12:19:11PM +0200, Tony Lindgren wrote:
> Commit 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT") started causing
> errors loading phy-cpcap-usb driver:
> 
> cpcap_battery cpcap_battery.0: failed to register power supply
> genirq: Flags mismatch irq 211. 00002080 (se0conn) vs. 00000080 (se0conn)
> cpcap-usb-phy cpcap-usb-phy.0: could not get irq se0conn: -16
> 
> Let's fix this by adding the missing IRQF_ONESHOT to also cpcap-battery
> and cpcap-charger drivers.
> 
> Fixes: 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT")
> Reported-by: Merlijn Wajer <merlijn@wizzup.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/cpcap-battery.c | 2 +-
>  drivers/power/supply/cpcap-charger.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> --- a/drivers/power/supply/cpcap-battery.c
> +++ b/drivers/power/supply/cpcap-battery.c
> @@ -666,7 +666,7 @@ static int cpcap_battery_init_irq(struct platform_device *pdev,
>  
>  	error = devm_request_threaded_irq(ddata->dev, irq, NULL,
>  					  cpcap_battery_irq_thread,
> -					  IRQF_SHARED,
> +					  IRQF_SHARED | IRQF_ONESHOT,
>  					  name, ddata);
>  	if (error) {
>  		dev_err(ddata->dev, "could not get irq %s: %i\n",
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -708,7 +708,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
>  
>  	error = devm_request_threaded_irq(ddata->dev, irq, NULL,
>  					  cpcap_charger_irq_thread,
> -					  IRQF_SHARED,
> +					  IRQF_SHARED | IRQF_ONESHOT,
>  					  name, ddata);
>  	if (error) {
>  		dev_err(ddata->dev, "could not get irq %s: %i\n",
> -- 
> 2.29.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-01-03  1:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 10:19 [PATCH] power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression Tony Lindgren
2021-01-03  1:57 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210103015752.gzonx5h54v4mseye@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.