All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12
@ 2021-01-03 13:52 Fabrice Fontaine
  2021-01-03 17:16 ` Леонид Юрьев (Leonid Yuriev)
  2021-01-03 20:47 ` Yann E. MORIN
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-01-03 13:52 UTC (permalink / raw)
  To: buildroot

Set CMAKE_BUILD_TYPE to Release to avoid the following build failure
with glibc < 2.12:

/home/buildroot/autobuild/run/instance-1/output-1/build/libmdbx-0.9.2/mdbx.c:487:5: error: #warning "libmdbx was only tested with GLIBC >= 2.12." [-Werror=cpp]
 #   warning "libmdbx was only tested with GLIBC >= 2.12."
     ^~~~~~~
cc1: all warnings being treated as errors

Fixes:
 - http://autobuild.buildroot.org/results/1a60b2c3d2f276f99a22da48e8e16fcf5744eba0

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libmdbx/libmdbx.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/libmdbx/libmdbx.mk b/package/libmdbx/libmdbx.mk
index 878ea87c07..370df2eaa3 100644
--- a/package/libmdbx/libmdbx.mk
+++ b/package/libmdbx/libmdbx.mk
@@ -14,7 +14,10 @@ LIBMDBX_REDISTRIBUTE = YES
 LIBMDBX_STRIP_COMPONENTS = 0
 LIBMDBX_INSTALL_STAGING = YES
 
+# Set CMAKE_BUILD_TYPE to Release to remove -Werror and avoid a build failure
+# with glibc < 2.12
 LIBMDBX_CONF_OPTS = \
+	-DCMAKE_BUILD_TYPE=Release \
 	-DMDBX_INSTALL_MANPAGES=OFF \
 	-DBUILD_FOR_NATIVE_CPU=OFF \
 	-DMDBX_BUILD_CXX=$(if $(BR2_PACKAGE_LIBMDBX_CXX),ON,OFF) \
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12
  2021-01-03 13:52 [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12 Fabrice Fontaine
@ 2021-01-03 17:16 ` Леонид Юрьев (Leonid Yuriev)
  2021-01-03 20:47 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Леонид Юрьев (Leonid Yuriev) @ 2021-01-03 17:16 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 3, 2021 at 4:53 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Set CMAKE_BUILD_TYPE to Release to avoid the following build failure
> with glibc < 2.12:
>
> /home/buildroot/autobuild/run/instance-1/output-1/build/libmdbx-0.9.2/mdbx.c:487:5: error: #warning "libmdbx was only tested with GLIBC >= 2.12." [-Werror=cpp]
>  #   warning "libmdbx was only tested with GLIBC >= 2.12."
>      ^~~~~~~
> cc1: all warnings being treated as errors
>
> Fixes:
>  - http://autobuild.buildroot.org/results/1a60b2c3d2f276f99a22da48e8e16fcf5744eba0
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libmdbx/libmdbx.mk | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/package/libmdbx/libmdbx.mk b/package/libmdbx/libmdbx.mk
> index 878ea87c07..370df2eaa3 100644
> --- a/package/libmdbx/libmdbx.mk
> +++ b/package/libmdbx/libmdbx.mk
> @@ -14,7 +14,10 @@ LIBMDBX_REDISTRIBUTE = YES
>  LIBMDBX_STRIP_COMPONENTS = 0
>  LIBMDBX_INSTALL_STAGING = YES
>
> +# Set CMAKE_BUILD_TYPE to Release to remove -Werror and avoid a build failure
> +# with glibc < 2.12
>  LIBMDBX_CONF_OPTS = \
> +       -DCMAKE_BUILD_TYPE=Release \
>         -DMDBX_INSTALL_MANPAGES=OFF \
>         -DBUILD_FOR_NATIVE_CPU=OFF \
>         -DMDBX_BUILD_CXX=$(if $(BR2_PACKAGE_LIBMDBX_CXX),ON,OFF) \
> --
> 2.29.2

Acked-by: Leonid Yuriev <leo@yuriev.ru>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12
  2021-01-03 13:52 [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12 Fabrice Fontaine
  2021-01-03 17:16 ` Леонид Юрьев (Leonid Yuriev)
@ 2021-01-03 20:47 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-01-03 20:47 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2021-01-03 14:52 +0100, Fabrice Fontaine spake thusly:
> Set CMAKE_BUILD_TYPE to Release to avoid the following build failure
> with glibc < 2.12:
> 
> /home/buildroot/autobuild/run/instance-1/output-1/build/libmdbx-0.9.2/mdbx.c:487:5: error: #warning "libmdbx was only tested with GLIBC >= 2.12." [-Werror=cpp]
>  #   warning "libmdbx was only tested with GLIBC >= 2.12."
>      ^~~~~~~
> cc1: all warnings being treated as errors
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/1a60b2c3d2f276f99a22da48e8e16fcf5744eba0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libmdbx/libmdbx.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libmdbx/libmdbx.mk b/package/libmdbx/libmdbx.mk
> index 878ea87c07..370df2eaa3 100644
> --- a/package/libmdbx/libmdbx.mk
> +++ b/package/libmdbx/libmdbx.mk
> @@ -14,7 +14,10 @@ LIBMDBX_REDISTRIBUTE = YES
>  LIBMDBX_STRIP_COMPONENTS = 0
>  LIBMDBX_INSTALL_STAGING = YES
>  
> +# Set CMAKE_BUILD_TYPE to Release to remove -Werror and avoid a build failure
> +# with glibc < 2.12
>  LIBMDBX_CONF_OPTS = \
> +	-DCMAKE_BUILD_TYPE=Release \
>  	-DMDBX_INSTALL_MANPAGES=OFF \
>  	-DBUILD_FOR_NATIVE_CPU=OFF \
>  	-DMDBX_BUILD_CXX=$(if $(BR2_PACKAGE_LIBMDBX_CXX),ON,OFF) \
> -- 
> 2.29.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-03 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03 13:52 [Buildroot] [PATCH 1/1] package/libmdbx: fix build with glibc < 2.12 Fabrice Fontaine
2021-01-03 17:16 ` Леонид Юрьев (Leonid Yuriev)
2021-01-03 20:47 ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.