From: Masami Hiramatsu <mhiramat@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
David Miller <davem@davemloft.net>,
x86@kernel.org
Subject: Re: [PATCH -tip v2] x86/kprobes: Do not decode opcode in resume_execution()
Date: Mon, 4 Jan 2021 12:45:58 +0900 [thread overview]
Message-ID: <20210104124558.7c89fb6fa305507c098f0d85@kernel.org> (raw)
In-Reply-To: <20201231160923.GB4504@zn.tnic>
On Thu, 31 Dec 2020 17:09:23 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Dec 18, 2020 at 11:12:05PM +0900, Masami Hiramatsu wrote:
> > @@ -467,8 +489,8 @@ static int arch_copy_kprobe(struct kprobe *p)
> > */
> > len = prepare_boost(buf, p, &insn);
> >
> > - /* Check whether the instruction modifies Interrupt Flag or not */
> > - p->ainsn.if_modifier = is_IF_modifier(buf);
> > + /* Analyze the opcode and set resume flags */
> > + set_resume_flags(p, &insn);
>
> So this function wants to be called something like analyze_insn() or so
> then? set_resume_flags() is kinda misleading as a name.
Hrm, I meant setting the flags used in the resume_execution() afterwards.
Since the instruction itself (not only opcode but also oprands) was
also analyzed in other places, so I like the set_resume_flags() for it.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-01-04 3:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 14:11 [PATCH 0/1] x86/kprobes: Classify opcode while preparing kprobe Masami Hiramatsu
2020-12-06 14:11 ` [PATCH 1/1] x86/kprobes: Do not decode opcode in resume_execution() Masami Hiramatsu
2020-12-07 20:28 ` Steven Rostedt
2020-12-18 1:02 ` [x86/kprobes] 413d31338f: kernel_BUG_at_mm/vmalloc.c kernel test robot
2020-12-18 1:02 ` kernel test robot
2020-12-18 12:44 ` Masami Hiramatsu
2020-12-18 12:44 ` Masami Hiramatsu
2020-12-18 14:12 ` [PATCH -tip v2] x86/kprobes: Do not decode opcode in resume_execution() Masami Hiramatsu
2020-12-31 16:09 ` Borislav Petkov
2021-01-04 3:45 ` Masami Hiramatsu [this message]
2021-01-04 18:40 ` Borislav Petkov
2021-01-05 14:47 ` [tip: perf/kprobes] " tip-bot2 for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104124558.7c89fb6fa305507c098f0d85@kernel.org \
--to=mhiramat@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.