From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E01BC433E6 for ; Mon, 4 Jan 2021 13:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD522221F9 for ; Mon, 4 Jan 2021 13:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbhADN5x (ORCPT ); Mon, 4 Jan 2021 08:57:53 -0500 Received: from mga06.intel.com ([134.134.136.31]:42214 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbhADN5x (ORCPT ); Mon, 4 Jan 2021 08:57:53 -0500 IronPort-SDR: ajTwUpv9vdDukyjkbw7QYVjJCYPZ6AjJp2bk8B8GqGKIsgH6KcWU3OIWZjmUjDx2VOcOgNOnuY XSN6eWXjg2nA== X-IronPort-AV: E=McAfee;i="6000,8403,9853"; a="238504381" X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="238504381" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 05:56:06 -0800 IronPort-SDR: 2Vbt0yhUumUuuxHYcnaUFIXxXKYUTubjc2t3IONfE5l9Op3sI71pHqEty7ZDY4aWzCPELH1EMl UxtERwrEo5Vg== X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="565109341" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 05:56:05 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id A4CBA206FD; Mon, 4 Jan 2021 15:55:33 +0200 (EET) Date: Mon, 4 Jan 2021 15:55:33 +0200 From: Sakari Ailus To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Benoit Parrot Subject: Re: [PATCH 2/2] media: i2c: Add OV1063x sensor driver Message-ID: <20210104135533.GM11878@paasikivi.fi.intel.com> References: <20210104053945.12409-1-laurent.pinchart@ideasonboard.com> <20210104053945.12409-3-laurent.pinchart@ideasonboard.com> <20210104124700.GL11878@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 04, 2021 at 03:05:05PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Mon, Jan 04, 2021 at 02:47:00PM +0200, Sakari Ailus wrote: > > Hi Laurent, > > > > On Mon, Jan 04, 2021 at 07:39:45AM +0200, Laurent Pinchart wrote: > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > > index 878f66ef2719..84a97989775e 100644 > > > --- a/drivers/media/i2c/Kconfig > > > +++ b/drivers/media/i2c/Kconfig > > > @@ -1050,6 +1050,18 @@ config VIDEO_OV9650 > > > This is a V4L2 sensor driver for the Omnivision > > > OV9650 and OV9652 camera sensors. > > > > > > +config VIDEO_OV10633 > > > + tristate "OmniVision OV10633/OV10635 sensor support" > > > + depends on I2C && VIDEO_V4L2 > > > + depends on GPIOLIB && OF > > > + select MEDIA_CONTROLLER > > > + select REGMAP_I2C > > > > Should this be SCCB instead? > > > > Likewise for the driver. > > The OV1063x has 16-bit register addresses, and, unless I'm mistaken, > regmap_sccb assumes register addresses to be 8-bit long. It seems so. I wonder what's the meaning of SCCB in this case. A number of drivers (three) require REGMAP_SCCB instead of REGMAP_I2C. Could it just be someone needed those drivers on controllers with just SMBUS functionality? I guess this is fine then. -- Sakari Ailus