From: Christoph Hellwig <hch@lst.de>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed
Date: Mon, 4 Jan 2021 18:11:41 +0100 [thread overview]
Message-ID: <20210104171141.GB27235@lst.de> (raw)
In-Reply-To: <20210104171108.GA27235@lst.de>
On Mon, Jan 04, 2021 at 06:11:08PM +0100, Christoph Hellwig wrote:
> On Mon, Jan 04, 2021 at 10:06:59PM +0900, Minwoo Im wrote:
> > + if (q->backing_dev_info && q->backing_dev_info->owner &&
> > + limits->logical_block_size != size) {
> > + bdev = blkdev_get_no_open(q->backing_dev_info->owner->devt);
> > + bdev->bd_disk->flags |= GENHD_FL_BLOCK_SIZE_CHANGED;
> > + blkdev_put_no_open(bdev);
> > + }
>
> We really need the backpointer from the queue to the gendisk I've wanted
> to add for a while. Can we at least restrict this to a live gendisk?
Alternatively we could make this request_queue QUEUE* flag for now.
next prev parent reply other threads:[~2021-01-04 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 13:06 [RFC PATCH V3 0/1] block: fix I/O errors in BLKRRPART Minwoo Im
2021-01-04 13:06 ` [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed Minwoo Im
2021-01-04 17:11 ` Christoph Hellwig
2021-01-04 17:11 ` Christoph Hellwig [this message]
2021-01-05 1:04 ` Minwoo Im
2021-01-05 7:50 ` Christoph Hellwig
2021-01-05 10:12 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104171141.GB27235@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minwoo.im.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.