* [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround
@ 2021-01-04 17:12 Fabrice Fontaine
2021-01-25 21:39 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-01-04 17:12 UTC (permalink / raw)
To: buildroot
Drop workaround for cmake < 3.10 (not needed since commit
d4773b610a40be1d3ac7d793033abaf4eb2491ed)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libssh/libssh.mk | 3 ---
1 file changed, 3 deletions(-)
diff --git a/package/libssh/libssh.mk b/package/libssh/libssh.mk
index 67e3ad9f91..15b1302a01 100644
--- a/package/libssh/libssh.mk
+++ b/package/libssh/libssh.mk
@@ -16,9 +16,6 @@ LIBSSH_CONF_OPTS = \
-DWITH_STACK_PROTECTOR=OFF \
-DWITH_EXAMPLES=OFF
-# cmake older than 3.10 require this to avoid try_run() in FindThreads
-LIBSSH_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
-
ifeq ($(BR2_PACKAGE_LIBSSH_SERVER),y)
LIBSSH_CONF_OPTS += -DWITH_SERVER=ON
else
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround
2021-01-04 17:12 [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround Fabrice Fontaine
@ 2021-01-25 21:39 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-01-25 21:39 UTC (permalink / raw)
To: buildroot
On Mon, 4 Jan 2021 18:12:31 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Drop workaround for cmake < 3.10 (not needed since commit
> d4773b610a40be1d3ac7d793033abaf4eb2491ed)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libssh/libssh.mk | 3 ---
> 1 file changed, 3 deletions(-)
Applied to master, thanks.
However, a quick git grep shows:
package/exiv2/exiv2.mk:EXIV2_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/i2pd/i2pd.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/i2pd/i2pd.mk:I2PD_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/librtlsdr/librtlsdr.mk:LIBRTLSDR_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/paho-mqtt-cpp/paho-mqtt-cpp.mk:PAHO_MQTT_CPP_CONF_OPTS = -DTHREADS_PTHREAD_ARG=OFF
package/poppler/poppler.mk:POPPLER_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/rabbitmq-c/rabbitmq-c.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/rabbitmq-c/rabbitmq-c.mk:RABBITMQ_C_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/uvw/uvw.mk:UVW_CONF_OPTS = -DTHREADS_PTHREAD_ARG=OFF
package/xerces/xerces.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/xerces/xerces.mk:XERCES_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/znc/znc.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/znc/znc.mk:ZNC_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
So there's perhaps some more cleaning that is possible ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-25 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-04 17:12 [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround Fabrice Fontaine
2021-01-25 21:39 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.